| Message ID | 20170121181944.24672-1-chris@chris-wilson.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Chris Wilson <chris@chris-wilson.co.uk> writes: > The prototypes were moved to a new header, but the function definitions > were not updated to pull in the declarations. > > drivers/gpu/drm/drm_cache.c:79:1: warning: no previous prototype for ‘drm_clflush_pages’ [-Wmissing-prototypes] > drivers/gpu/drm/drm_cache.c:120:1: warning: no previous prototype for ‘drm_clflush_sg’ [-Wmissing-prototypes] > drivers/gpu/drm/drm_cache.c:152:1: warning: no previous prototype for ‘drm_clflush_virt_range’ [-Wmissing-prototypes] > > Fixes: f9a87bd7d5b6 ("drm: Move drm_clflush prototypes to drm_cache header file") > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Gabriel Krisman Bertazi <krisman@collabora.co.uk> > Cc: Alex Deucher <alexander.deucher@amd.com> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Patch is good, though I'm Embarrassed that I didn't have -Wmissing-prototypes enabled when testing this. Thanks Chris. Reviewed-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk> -- Gabriel Krisman Bertazi
On Sat, Jan 21, 2017 at 06:05:05PM -0200, Gabriel Krisman Bertazi wrote: > Chris Wilson <chris@chris-wilson.co.uk> writes: > > > The prototypes were moved to a new header, but the function definitions > > were not updated to pull in the declarations. > > > > drivers/gpu/drm/drm_cache.c:79:1: warning: no previous prototype for ‘drm_clflush_pages’ [-Wmissing-prototypes] > > drivers/gpu/drm/drm_cache.c:120:1: warning: no previous prototype for ‘drm_clflush_sg’ [-Wmissing-prototypes] > > drivers/gpu/drm/drm_cache.c:152:1: warning: no previous prototype for ‘drm_clflush_virt_range’ [-Wmissing-prototypes] > > > > Fixes: f9a87bd7d5b6 ("drm: Move drm_clflush prototypes to drm_cache header file") > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > > Cc: Gabriel Krisman Bertazi <krisman@collabora.co.uk> > > Cc: Alex Deucher <alexander.deucher@amd.com> > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > > Patch is good, though I'm Embarrassed that I didn't have -Wmissing-prototypes > enabled when testing this. Thanks Chris. > > Reviewed-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk> Applied to drm-misc, thx. -Daniel
diff --git a/drivers/gpu/drm/drm_cache.c b/drivers/gpu/drm/drm_cache.c index 5066638928ec..c3b9aaccdf42 100644 --- a/drivers/gpu/drm/drm_cache.c +++ b/drivers/gpu/drm/drm_cache.c @@ -29,7 +29,9 @@ */ #include <linux/export.h> -#include <drm/drmP.h> +#include <linux/highmem.h> + +#include <drm/drm_cache.h> #if defined(CONFIG_X86) #include <asm/smp.h>
The prototypes were moved to a new header, but the function definitions were not updated to pull in the declarations. drivers/gpu/drm/drm_cache.c:79:1: warning: no previous prototype for ‘drm_clflush_pages’ [-Wmissing-prototypes] drivers/gpu/drm/drm_cache.c:120:1: warning: no previous prototype for ‘drm_clflush_sg’ [-Wmissing-prototypes] drivers/gpu/drm/drm_cache.c:152:1: warning: no previous prototype for ‘drm_clflush_virt_range’ [-Wmissing-prototypes] Fixes: f9a87bd7d5b6 ("drm: Move drm_clflush prototypes to drm_cache header file") Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Gabriel Krisman Bertazi <krisman@collabora.co.uk> Cc: Alex Deucher <alexander.deucher@amd.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> --- drivers/gpu/drm/drm_cache.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)