From patchwork Sun Jan 22 17:55:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcos Paulo de Souza X-Patchwork-Id: 9531221 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 505BD601D4 for ; Sun, 22 Jan 2017 17:56:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 35F42271FD for ; Sun, 22 Jan 2017 17:56:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 14F2527F93; Sun, 22 Jan 2017 17:56:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AA74B271FD for ; Sun, 22 Jan 2017 17:56:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751160AbdAVR4P (ORCPT ); Sun, 22 Jan 2017 12:56:15 -0500 Received: from mail-qt0-f193.google.com ([209.85.216.193]:32918 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751047AbdAVR4O (ORCPT ); Sun, 22 Jan 2017 12:56:14 -0500 Received: by mail-qt0-f193.google.com with SMTP id n13so12082762qtc.0; Sun, 22 Jan 2017 09:56:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Lp1UX8VxjAB8ANsGTMSQXdxEmVZqY8NG89+IOw17CK4=; b=mjAO0wFEKxQXVJEzy1gZQKTHx2OFvHAEsgJa+tZ8vLBF8S0NjHR+JplDismgi9QE0/ QQf5rMvX0xIFqZN9aKGJSDBkPkKiSsN0LggTczq7m39Cew9yv4tHgANdIMe1MP+JcTWF F4rRmjftGqMXNZHV3YwhuG5bwCCXU0GW5c1s7a5BB3sTK1KDNf8PrJzP5V6isq0gwRoR w0oLP4Vr4Oj697v+pCdkqHS3UuWwgvnzZbgddT/czBRu5rt5Cdia2HTTiZ9kAa/IF+qQ 3hVYsisax/tJS3qHcBAwthAebcNpNDlmrl/lF/sl5FjJ4FCcxcu8xBcuadetlVo5+tO7 eFEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Lp1UX8VxjAB8ANsGTMSQXdxEmVZqY8NG89+IOw17CK4=; b=oJUFoMf5PdTKuO3yiZ8IpaupFb4s3CcVFZM69RDnMdJzg/V2FHxbxhypbOsXYyRh0z wxt1qcithYQyBIFyyEQx+EmELcVKTeN44wa7OEFbZobZwAMUu/lu8DVJaTZPxi+hTwRy Dsl3H0LNizaOtP6se6fN3CMEhI5SINOEPCcgK4gbrEXFLM6dax+8PSSkBKGAo3MHVihX QDuib/0i6EzHfJEwzK/LLySG0MTm0QhklTthiMI4MuP4l2tW3IqP80wQiTGtJhV7FKds 3L5lV3kqPvz5OJe7gEnHvLX5efDy7o3ZyRFe+RD7cOeQUKzPxF3GiV4rK4rnWkr9AI6z +v/g== X-Gm-Message-State: AIkVDXJL3v4V67B7i62Iq+irhCmWnR92s1K4NAh/Lo0dVKFnGeGxW/idRC1n0rFezk40Gg== X-Received: by 10.237.62.182 with SMTP id n51mr20832612qtf.252.1485107773566; Sun, 22 Jan 2017 09:56:13 -0800 (PST) Received: from localhost.localdomain ([186.212.94.212]) by smtp.gmail.com with ESMTPSA id 43sm11316879qty.26.2017.01.22.09.56.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 22 Jan 2017 09:56:13 -0800 (PST) From: Marcos Paulo de Souza Cc: Marcos Paulo de Souza , Dmitry Torokhov , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH -v2] Input: i8042: Add dbg msg when a command can't write its parameter Date: Sun, 22 Jan 2017 15:55:19 -0200 Message-Id: <20170122175557.29008-1-marcos.souza.org@gmail.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20161206234531.4320-1-marcos.souza.org@gmail.com> References: <20161206234531.4320-1-marcos.souza.org@gmail.com> To: unlisted-recipients:; (no To-header on input) Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This can happen in cases like bug #102951[1], so add a proper debug msg as done in wait_read. Also, change wait_read debug message to differ from wait_write. [1] https://bugzilla.kernel.org/show_bug.cgi?id=102951 Signed-off-by: Marcos Paulo de Souza --- Changes from v1: * use dbg instead of pr_warn drivers/input/serio/i8042.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c index 62685a7..cba6831 100644 --- a/drivers/input/serio/i8042.c +++ b/drivers/input/serio/i8042.c @@ -312,8 +312,10 @@ static int __i8042_command(unsigned char *param, int command) for (i = 0; i < ((command >> 12) & 0xf); i++) { error = i8042_wait_write(); - if (error) + if (error) { + dbg(" -- i8042 (timeout wait_write)\n"); return error; + } dbg("%02x -> i8042 (parameter)\n", param[i]); i8042_write_data(param[i]); } @@ -321,7 +323,7 @@ static int __i8042_command(unsigned char *param, int command) for (i = 0; i < ((command >> 8) & 0xf); i++) { error = i8042_wait_read(); if (error) { - dbg(" -- i8042 (timeout)\n"); + dbg(" -- i8042 (timeout wait_read)\n"); return error; }