[v2] ALSA: ymfpci: Handle return NULL error from ioremap_nocache
diff mbox

Message ID 1485156988-24137-1-git-send-email-arvind.yadav.cs@gmail.com
State New
Headers show

Commit Message

Arvind Yadav Jan. 23, 2017, 7:36 a.m. UTC
Here, If ioremap_nocache will fail. It will return NULL.
Kernel can run into a NULL-pointer dereference.
This error check will avoid NULL pointer dereference.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 sound/pci/ymfpci/ymfpci_main.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Takashi Iwai Jan. 23, 2017, 1:20 p.m. UTC | #1
On Mon, 23 Jan 2017 08:36:28 +0100,
Arvind Yadav wrote:
> 
> Here, If ioremap_nocache will fail. It will return NULL.
> Kernel can run into a NULL-pointer dereference.
> This error check will avoid NULL pointer dereference.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  sound/pci/ymfpci/ymfpci_main.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/sound/pci/ymfpci/ymfpci_main.c b/sound/pci/ymfpci/ymfpci_main.c
> index ffee284..8590c3f 100644
> --- a/sound/pci/ymfpci/ymfpci_main.c
> +++ b/sound/pci/ymfpci/ymfpci_main.c
> @@ -2392,6 +2392,10 @@ int snd_ymfpci_create(struct snd_card *card,
>  	chip->rev = pci->revision;
>  	chip->reg_area_phys = pci_resource_start(pci, 0);
>  	chip->reg_area_virt = ioremap_nocache(chip->reg_area_phys, 0x8000);
> +	if (!chip->reg_area_virt) {
> +		pci_disable_device(pci);
> +		return -ENOMEM;

You forgot to release chip.  Otherwise it leads memory.


thanks,

Takashi

Patch
diff mbox

diff --git a/sound/pci/ymfpci/ymfpci_main.c b/sound/pci/ymfpci/ymfpci_main.c
index ffee284..8590c3f 100644
--- a/sound/pci/ymfpci/ymfpci_main.c
+++ b/sound/pci/ymfpci/ymfpci_main.c
@@ -2392,6 +2392,10 @@  int snd_ymfpci_create(struct snd_card *card,
 	chip->rev = pci->revision;
 	chip->reg_area_phys = pci_resource_start(pci, 0);
 	chip->reg_area_virt = ioremap_nocache(chip->reg_area_phys, 0x8000);
+	if (!chip->reg_area_virt) {
+		pci_disable_device(pci);
+		return -ENOMEM;
+	}
 	pci_set_master(pci);
 	chip->src441_used = -1;