diff mbox

regulator: tps65217: Allow DCDC1 and DCDC3 up to 3.3V

Message ID 20170123102810.6810-1-mans.andersson@nibe.se (mailing list archive)
State New, archived
Headers show

Commit Message

=?ISO-8859-1?Q?=20M=C3=A5ns?=@vger.kernel.org, Andersson@vger.kernel.org Jan. 23, 2017, 10:28 a.m. UTC 
From: Måns Andersson <mans.andersson@nibe.se>

The data sheet statement that DCDC1 and DCDC3 only can be set in the range
0.9V - 1.5V refers to storage on its internal EEPROM and therefore cold boot
configuration. After power-on the device can be reconfigured over i2c and
DCDC1/3 set up to 3.3V.

Signed-off-by: Måns Andersson <mans.andersson@nibe.se>
---
 drivers/regulator/tps65217-regulator.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Mark Brown Jan. 23, 2017, 5:48 p.m. UTC | #1 
On Mon, Jan 23, 2017 at 11:28:10AM +0100, MånsAndersson wrote:
> From: Måns Andersson <mans.andersson@nibe.se>
> 
> The data sheet statement that DCDC1 and DCDC3 only can be set in the range
> 0.9V - 1.5V refers to storage on its internal EEPROM and therefore cold boot
> configuration. After power-on the device can be reconfigured over i2c and
> DCDC1/3 set up to 3.3V.
> 
> Signed-off-by: Måns Andersson <mans.andersson@nibe.se>

Your git configuration is broken, you don't provide an e-mail address in
the From.  Please check this and fix for future submissions, it's
confusing and a bit of a red flag.
diff mbox

Patch

diff --git a/drivers/regulator/tps65217-regulator.c b/drivers/regulator/tps65217-regulator.c
index 2d12b9a..5324dc9 100644
--- a/drivers/regulator/tps65217-regulator.c
+++ b/drivers/regulator/tps65217-regulator.c
@@ -179,7 +179,8 @@  static const struct regulator_desc regulators[] = {
 	TPS65217_REGULATOR("DCDC1", TPS65217_DCDC_1, "dcdc1",
 			   tps65217_pmic_ops, 64, TPS65217_REG_DEFDCDC1,
 			   TPS65217_DEFDCDCX_DCDC_MASK, TPS65217_ENABLE_DC1_EN,
-			   NULL, tps65217_uv1_ranges, 2, TPS65217_REG_SEQ1,
+			   NULL, tps65217_uv1_ranges,
+			   ARRAY_SIZE(tps65217_uv1_ranges), TPS65217_REG_SEQ1,
 			   TPS65217_SEQ1_DC1_SEQ_MASK),
 	TPS65217_REGULATOR("DCDC2", TPS65217_DCDC_2, "dcdc2",
 			   tps65217_pmic_ops, 64, TPS65217_REG_DEFDCDC2,
@@ -190,7 +191,8 @@  static const struct regulator_desc regulators[] = {
 	TPS65217_REGULATOR("DCDC3", TPS65217_DCDC_3, "dcdc3",
 			   tps65217_pmic_ops, 64, TPS65217_REG_DEFDCDC3,
 			   TPS65217_DEFDCDCX_DCDC_MASK, TPS65217_ENABLE_DC3_EN,
-			   NULL, tps65217_uv1_ranges, 1, TPS65217_REG_SEQ2,
+			   NULL, tps65217_uv1_ranges,
+			   ARRAY_SIZE(tps65217_uv1_ranges), TPS65217_REG_SEQ2,
 			   TPS65217_SEQ2_DC3_SEQ_MASK),
 	TPS65217_REGULATOR("LDO1", TPS65217_LDO_1, "ldo1",
 			   tps65217_pmic_ldo1_ops, 16, TPS65217_REG_DEFLDO1,