From patchwork Tue Jan 24 20:35:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuck Lever X-Patchwork-Id: 9535857 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 18990604A0 for ; Tue, 24 Jan 2017 20:35:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 073FC26E51 for ; Tue, 24 Jan 2017 20:35:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F01C726E81; Tue, 24 Jan 2017 20:35:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AE7D626E51 for ; Tue, 24 Jan 2017 20:35:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750751AbdAXUfG (ORCPT ); Tue, 24 Jan 2017 15:35:06 -0500 Received: from mail-io0-f194.google.com ([209.85.223.194]:35507 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750715AbdAXUfF (ORCPT ); Tue, 24 Jan 2017 15:35:05 -0500 Received: by mail-io0-f194.google.com with SMTP id m98so19811247iod.2; Tue, 24 Jan 2017 12:35:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:from:to:date:message-id:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=gFIzOrEEu2bNfMDfu2weW9b9ZtGUg12ujFBQ3h/jGSA=; b=gx8SM1IJC3gZ3upNtL0dOv6okKNuYagEy4x1jBSe8g2A++qjo2Kso528991mGM8T4v HtPkLQwTE0zrAkl1gKT26OJBtdUc14mZRY4RzYjj/JEHnNbAeUs6aHg3rwsaydBwZH3T ohmo89/7Z8cs5k8ILsr/2RM/YHxbXs6StHurCCgTQY9TFSPmU6YDiF1w27XPX2rOZEsB qHsseEmX/Pn56hdYFw59YWBflvcu6nJAmmiGWONJVfuqCduskq7nRaHUwWRuXZ83sgJy 1KLAPttg0IN88KNP3cErA8QACQVm+wdWCF6k7WCYG79YTV0T39DlmrPqcbO2+hnED9LS ZLgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:from:to:date:message-id :in-reply-to:references:user-agent:mime-version :content-transfer-encoding; bh=gFIzOrEEu2bNfMDfu2weW9b9ZtGUg12ujFBQ3h/jGSA=; b=YGLNOki1dOMS5YfWZnFFQzlKm/LXi9fGzuGiT0Lc37gR10vlHSSDRKoKQfsLXFuiqo Js+jJbPqcGYmfQaHAch8k7c45ZrM/PMuUzkqGeoFn7GpLRBYFVkhw2sSr8wqig/gESli m1ynpByTZII2mOUiIhzB9Cds4SnLE+cYewY3m87s7f+rYGjsotm7nlXi+b6p6vDr4xIW OFtjORWSaAnV0M+Lw8CzdCPXuXkwbKrp34fxl0V+E0TOAYmyubn81dzYZDuhuE+21M2H PLtt8n9kkH8QOh0MJcui/1F5488JvyAcallFY2ikf8IhAKY0FJ1Dd7MCTlvR847C7Clx spCg== X-Gm-Message-State: AIkVDXKr2qDXLtjz/+DulEtJ1eY/CP6H4hsM8kxeQDP2ggkd4F/KrR/V5xqM9hKV+Lv1mA== X-Received: by 10.107.165.146 with SMTP id o140mr23958671ioe.42.1485290104481; Tue, 24 Jan 2017 12:35:04 -0800 (PST) Received: from klimt.1015granger.net ([2604:8800:100:81fc:ec4:7aff:fe6c:6aa0]) by smtp.gmail.com with ESMTPSA id p124sm12077750ioe.37.2017.01.24.12.35.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Jan 2017 12:35:04 -0800 (PST) Subject: [PATCH v1 4/7] svcrdma: Clean up backchannel send header encoding From: Chuck Lever To: linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org Date: Tue, 24 Jan 2017 15:35:03 -0500 Message-ID: <20170124203503.11807.89180.stgit@klimt.1015granger.net> In-Reply-To: <20170124193242.11807.91861.stgit@klimt.1015granger.net> References: <20170124193242.11807.91861.stgit@klimt.1015granger.net> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Replace C structure-based XDR decoding with pointer arithmetic. Pointer arithmetic is considered more portable. Signed-off-by: Chuck Lever --- net/sunrpc/xprtrdma/svc_rdma_backchannel.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/sunrpc/xprtrdma/svc_rdma_backchannel.c b/net/sunrpc/xprtrdma/svc_rdma_backchannel.c index 288e35c..abfce04 100644 --- a/net/sunrpc/xprtrdma/svc_rdma_backchannel.c +++ b/net/sunrpc/xprtrdma/svc_rdma_backchannel.c @@ -200,19 +200,20 @@ static int svc_rdma_bc_sendto(struct svcxprt_rdma *rdma, { struct rpc_xprt *xprt = rqst->rq_xprt; struct rpcrdma_xprt *r_xprt = rpcx_to_rdmax(xprt); - struct rpcrdma_msg *headerp = (struct rpcrdma_msg *)rqst->rq_buffer; + __be32 *p; int rc; /* Space in the send buffer for an RPC/RDMA header is reserved * via xprt->tsh_size. */ - headerp->rm_xid = rqst->rq_xid; - headerp->rm_vers = rpcrdma_version; - headerp->rm_credit = cpu_to_be32(r_xprt->rx_buf.rb_bc_max_requests); - headerp->rm_type = rdma_msg; - headerp->rm_body.rm_chunks[0] = xdr_zero; - headerp->rm_body.rm_chunks[1] = xdr_zero; - headerp->rm_body.rm_chunks[2] = xdr_zero; + p = (__be32 *)rqst->rq_buffer; + *p++ = rqst->rq_xid; + *p++ = rpcrdma_version; + *p++ = cpu_to_be32(r_xprt->rx_buf.rb_bc_max_requests); + *p++ = rdma_msg; + *p++ = xdr_zero; + *p++ = xdr_zero; + *p = xdr_zero; #ifdef SVCRDMA_BACKCHANNEL_DEBUG pr_info("%s: %*ph\n", __func__, 64, rqst->rq_buffer);