[02/15] drm/bridge: Use recommened kerneldoc for struct member refs
diff mbox

Message ID 20170125062657.19270-3-daniel.vetter@ffwll.ch
State New
Headers show

Commit Message

Daniel Vetter Jan. 25, 2017, 6:26 a.m. UTC
I just learned that &struct_name.member_name works and looks pretty
even. It doesn't (yet) link to the member directly though, which would
be really good for big structures or vfunc tables (where the
per-member kerneldoc tends to be long).

Also some minor drive-by polish where it makes sense, I read a lot
of docs ...

Cc: Archit Taneja <architt@codeaurora.org>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 include/drm/drm_bridge.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Archit Taneja Jan. 25, 2017, 9:33 a.m. UTC | #1
On 01/25/2017 11:56 AM, Daniel Vetter wrote:
> I just learned that &struct_name.member_name works and looks pretty
> even. It doesn't (yet) link to the member directly though, which would
> be really good for big structures or vfunc tables (where the
> per-member kerneldoc tends to be long).
>
> Also some minor drive-by polish where it makes sense, I read a lot
> of docs ...

This seems like a leftover from the older version of the patch, which
we decided to not take. I guess we could drop it.

Archit

>
> Cc: Archit Taneja <architt@codeaurora.org>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>  include/drm/drm_bridge.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
> index fdd82fcbf168..1595a57dfbf2 100644
> --- a/include/drm/drm_bridge.h
> +++ b/include/drm/drm_bridge.h
> @@ -87,9 +87,9 @@ struct drm_bridge_funcs {
>  	 * True if an acceptable configuration is possible, false if the modeset
>  	 * operation should be rejected.
>  	 */
> -	bool (*mode_fixup)(struct drm_bridge *bridge,
> -			   const struct drm_display_mode *mode,
> -			   struct drm_display_mode *adjusted_mode);
> +	bool (*mode_fixup)(struct drm_bridge *bridge, const struct
> +			   drm_display_mode *mode, struct drm_display_mode
> +			   *adjusted_mode);
>  	/**
>  	 * @disable:
>  	 *
>
Daniel Vetter Jan. 25, 2017, 12:40 p.m. UTC | #2
On Wed, Jan 25, 2017 at 03:03:42PM +0530, Archit Taneja wrote:
> 
> 
> On 01/25/2017 11:56 AM, Daniel Vetter wrote:
> > I just learned that &struct_name.member_name works and looks pretty
> > even. It doesn't (yet) link to the member directly though, which would
> > be really good for big structures or vfunc tables (where the
> > per-member kerneldoc tends to be long).
> > 
> > Also some minor drive-by polish where it makes sense, I read a lot
> > of docs ...
> 
> This seems like a leftover from the older version of the patch, which
> we decided to not take. I guess we could drop it.

Right, this was a rebase oversight, thanks a lot for catching it. I'l drop
it now to make sure it won't resurface :-)
-Daniel

> 
> Archit
> 
> > 
> > Cc: Archit Taneja <architt@codeaurora.org>
> > Cc: Jani Nikula <jani.nikula@linux.intel.com>
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > ---
> >  include/drm/drm_bridge.h | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
> > index fdd82fcbf168..1595a57dfbf2 100644
> > --- a/include/drm/drm_bridge.h
> > +++ b/include/drm/drm_bridge.h
> > @@ -87,9 +87,9 @@ struct drm_bridge_funcs {
> >  	 * True if an acceptable configuration is possible, false if the modeset
> >  	 * operation should be rejected.
> >  	 */
> > -	bool (*mode_fixup)(struct drm_bridge *bridge,
> > -			   const struct drm_display_mode *mode,
> > -			   struct drm_display_mode *adjusted_mode);
> > +	bool (*mode_fixup)(struct drm_bridge *bridge, const struct
> > +			   drm_display_mode *mode, struct drm_display_mode
> > +			   *adjusted_mode);
> >  	/**
> >  	 * @disable:
> >  	 *
> > 
> 
> -- 
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project

Patch
diff mbox

diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
index fdd82fcbf168..1595a57dfbf2 100644
--- a/include/drm/drm_bridge.h
+++ b/include/drm/drm_bridge.h
@@ -87,9 +87,9 @@  struct drm_bridge_funcs {
 	 * True if an acceptable configuration is possible, false if the modeset
 	 * operation should be rejected.
 	 */
-	bool (*mode_fixup)(struct drm_bridge *bridge,
-			   const struct drm_display_mode *mode,
-			   struct drm_display_mode *adjusted_mode);
+	bool (*mode_fixup)(struct drm_bridge *bridge, const struct
+			   drm_display_mode *mode, struct drm_display_mode
+			   *adjusted_mode);
 	/**
 	 * @disable:
 	 *