diff mbox

alsaloop: Correct check in if condition

Message ID caf13bb7-1481-1328-163f-68c3eb80abb7@molgen.mpg.de (mailing list archive)
State New, archived
Headers show

Commit Message

Paul Menzel Jan. 23, 2017, 11:08 a.m. UTC 
Date: Mon, 23 Jan 2017 11:45:13 +0100

Fix the error below found by gcc (Debian 6.3.0-4) 6.3.0 20170121.

```
gcc -DHAVE_CONFIG_H -I. -I../include  -I../include  -D_GNU_SOURCE -O2 
-Wall -pipe -g -MT pcmjob.o -MD -MP -MF .deps/pcmjob.Tpo -c -o pcmjob.o 
pcmjob.c
pcmjob.c: In function 'pcmjob_start':
pcmjob.c:1482:27: warning: self-comparison always evaluates to true 
[-Wtautological-compare]
       loop->play->channels == loop->play->channels &&
                            ^~
```

Judging from the surrounding code, the check should make sure the
channels of the play and capture device are equal.

Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
I hope, this patch gets through without any mangling from Mozilla 
Thunderbird.

  alsaloop/pcmjob.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox

Patch

diff --git a/alsaloop/pcmjob.c b/alsaloop/pcmjob.c
index 4df59e8..2be0732 100644
--- a/alsaloop/pcmjob.c
+++ b/alsaloop/pcmjob.c
@@ -1479,7 +1479,7 @@  __again:
  	if (loop->play->access == loop->capt->access &&
  	    loop->play->format == loop->capt->format &&
  	    loop->play->rate == loop->capt->rate &&
-	    loop->play->channels == loop->play->channels &&
+	    loop->play->channels == loop->capt->channels &&
  	    loop->sync != SYNC_TYPE_SAMPLERATE) {
  		if (verbose > 1)
  			snd_output_printf(loop->output, "shared buffer!!!\n");