| Message ID | 20170125233646.2243-3-bart.vanassche@sandisk.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On 01/26/2017 12:36 AM, Bart Van Assche wrote: > This patch avoids that smatch complains about inconsistent > indentation in iscsi_target_start_negotiation(). > > Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> > Cc: Nicholas A. Bellinger <nab@linux-iscsi.org> > --- > drivers/target/iscsi/iscsi_target_nego.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/target/iscsi/iscsi_target_nego.c b/drivers/target/iscsi/iscsi_target_nego.c > index 46388c9e08da..5269e9ef031c 100644 > --- a/drivers/target/iscsi/iscsi_target_nego.c > +++ b/drivers/target/iscsi/iscsi_target_nego.c > @@ -1249,16 +1249,16 @@ int iscsi_target_start_negotiation( > { > int ret; > > - if (conn->sock) { > - struct sock *sk = conn->sock->sk; > + if (conn->sock) { > + struct sock *sk = conn->sock->sk; > > - write_lock_bh(&sk->sk_callback_lock); > - set_bit(LOGIN_FLAGS_READY, &conn->login_flags); > - write_unlock_bh(&sk->sk_callback_lock); > - } > + write_lock_bh(&sk->sk_callback_lock); > + set_bit(LOGIN_FLAGS_READY, &conn->login_flags); > + write_unlock_bh(&sk->sk_callback_lock); > + } > > - ret = iscsi_target_do_login(conn, login); > - if (ret < 0) { > + ret = iscsi_target_do_login(conn, login); > + if (ret < 0) { > cancel_delayed_work_sync(&conn->login_work); > cancel_delayed_work_sync(&conn->login_cleanup_work); > iscsi_target_restore_sock_callbacks(conn); > Reviewed-by: Hannes Reinecke <hare@suse.com> Cheers, Hannes
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/target/iscsi/iscsi_target_nego.c b/drivers/target/iscsi/iscsi_target_nego.c index 46388c9e08da..5269e9ef031c 100644 --- a/drivers/target/iscsi/iscsi_target_nego.c +++ b/drivers/target/iscsi/iscsi_target_nego.c @@ -1249,16 +1249,16 @@ int iscsi_target_start_negotiation( { int ret; - if (conn->sock) { - struct sock *sk = conn->sock->sk; + if (conn->sock) { + struct sock *sk = conn->sock->sk; - write_lock_bh(&sk->sk_callback_lock); - set_bit(LOGIN_FLAGS_READY, &conn->login_flags); - write_unlock_bh(&sk->sk_callback_lock); - } + write_lock_bh(&sk->sk_callback_lock); + set_bit(LOGIN_FLAGS_READY, &conn->login_flags); + write_unlock_bh(&sk->sk_callback_lock); + } - ret = iscsi_target_do_login(conn, login); - if (ret < 0) { + ret = iscsi_target_do_login(conn, login); + if (ret < 0) { cancel_delayed_work_sync(&conn->login_work); cancel_delayed_work_sync(&conn->login_cleanup_work); iscsi_target_restore_sock_callbacks(conn);
This patch avoids that smatch complains about inconsistent indentation in iscsi_target_start_negotiation(). Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> Cc: Nicholas A. Bellinger <nab@linux-iscsi.org> --- drivers/target/iscsi/iscsi_target_nego.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)