From patchwork Tue Feb 7 13:46:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kinglong Mee X-Patchwork-Id: 9560141 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E157460434 for ; Tue, 7 Feb 2017 13:46:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D3081283CA for ; Tue, 7 Feb 2017 13:46:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C7CC4283E7; Tue, 7 Feb 2017 13:46:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C178D283CA for ; Tue, 7 Feb 2017 13:46:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753850AbdBGNqv (ORCPT ); Tue, 7 Feb 2017 08:46:51 -0500 Received: from mail-io0-f193.google.com ([209.85.223.193]:34379 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753825AbdBGNqu (ORCPT ); Tue, 7 Feb 2017 08:46:50 -0500 Received: by mail-io0-f193.google.com with SMTP id c80so12849543iod.1 for ; Tue, 07 Feb 2017 05:46:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=4G4vemZn5JTOCzXbT2vjzBZrW/rhqhfyxjH0LfEWfFg=; b=vEjVP+TVpjFzLWXjYc+cWUKWnp9c+BJB2NESJ5cMUbMf6hXUGwqyXlKlAhfgPRMAgQ FHJCnDyn3OvmQP2QWCmOIqOOwEeAXPlBNBfojknkjqB3LdVWfjyXS+7CfZVdsE717BkM ND6M5MpzvkLrWP677sLOmqkz87Spx4iOrOV5MRAWlMDjXkSMX+GZ2qjtTAMwO0aJqkxh DNKXJdZoQ6kW6TcEDzSQ1CR4El5YI+kc9EIeUar+yRiJizDtF3n7KTgEfNO2Ci8s7H1W l2gnzr0g4ihRLpQcVdy8fupl0U8eHek8U6R/YI5CcbogcIOK4It3HMLfKusPhkjM5Bzr jHTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=4G4vemZn5JTOCzXbT2vjzBZrW/rhqhfyxjH0LfEWfFg=; b=YrRI3MMZNAWBfRbnQnuncKJAi2GEz6guX0y3t/7IOHonf5qZh3Ow/F82YlzuAigQcY Emo3UmCIMRlPL6SsZ8roU52gN1r898HhKaEQmnEbsl9zV1EbnGvrkwDpUj0RhmeijgeF WHJkMfPQ0ASVOgn+eMWjYde0E7FM2bTQJsP6JCfNKevYt9brIg2PFdo9KN9Ug1ADHAz1 QDp/QVrHSsRJk5JLVON1LLCGS4w/NhYQPAFv/ZXU9EVGbt2syq3FLzcNHz1Somh1jXCc 67AT69T77P1XWYxSTAKzjDSb9nx9Doh0BSx4cCXo5IHfX7g/eVrVut1Ipt4YCSua0DpN Uxow== X-Gm-Message-State: AMke39mSLipi3JaxgvKWJvGOhG2Tsvr9D968dhGIwiMuXSabVbccsypiJKThZG+Tog0trA== X-Received: by 10.107.10.198 with SMTP id 67mr3964287iok.81.1486475209797; Tue, 07 Feb 2017 05:46:49 -0800 (PST) Received: from [192.168.0.107] ([182.139.118.29]) by smtp.gmail.com with ESMTPSA id v85sm9543683iov.34.2017.02.07.05.46.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Feb 2017 05:46:49 -0800 (PST) Subject: [PATCH 1/7] sunrpc: error out if register_shrinker fail To: "J. Bruce Fields" , linux-nfs@vger.kernel.org References: <59432847-8e45-4423-c441-0c67ee645f38@gmail.com> Cc: Trond Myklebust , Kinglong Mee From: Kinglong Mee Message-ID: <03bfbff3-958a-0ae9-fbd9-1eba53fa1735@gmail.com> Date: Tue, 7 Feb 2017 21:46:39 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <59432847-8e45-4423-c441-0c67ee645f38@gmail.com> Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP register_shrinker may return error when register fail, error out. Signed-off-by: Kinglong Mee --- net/sunrpc/auth.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/net/sunrpc/auth.c b/net/sunrpc/auth.c index a7d03ea..4aa6ef1 100644 --- a/net/sunrpc/auth.c +++ b/net/sunrpc/auth.c @@ -873,8 +873,12 @@ int __init rpcauth_init_module(void) err = rpc_init_generic_auth(); if (err < 0) goto out2; - register_shrinker(&rpc_cred_shrinker); + err = register_shrinker(&rpc_cred_shrinker); + if (err < 0) + goto out3; return 0; +out3: + rpc_destroy_generic_auth(); out2: rpc_destroy_authunix(); out1: