From patchwork Tue Feb 7 19:16:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rafael Tinoco X-Patchwork-Id: 9560919 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EC195602B1 for ; Tue, 7 Feb 2017 19:16:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DC9042847D for ; Tue, 7 Feb 2017 19:16:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D067628484; Tue, 7 Feb 2017 19:16:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4DC552847D for ; Tue, 7 Feb 2017 19:16:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755046AbdBGTQz (ORCPT ); Tue, 7 Feb 2017 14:16:55 -0500 Received: from mail-qt0-f176.google.com ([209.85.216.176]:34329 "EHLO mail-qt0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754715AbdBGTQy (ORCPT ); Tue, 7 Feb 2017 14:16:54 -0500 Received: by mail-qt0-f176.google.com with SMTP id w20so139260853qtb.1 for ; Tue, 07 Feb 2017 11:16:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=rU5siUELY8T233/GqOGiNLey1zfDrB+9LBy4lJ9V9n4=; b=qIXXZUczepWdGkgWIPo2a7oOU6Idr/t6DJwha8ygtQ7ZHv7c9GHnm6wBZg70u6QX0i F9iB5vtj02M5JVCCUc1hSnRj3iEklf27DGzZnyd71W0m6hGmPaob68bOjzLxB4DkZQ/W g5v9B4rTN99dllL04QxDBhrwYSyKlvJdOQnBv9d6PGSujgf29g+LxAVxk/NriczA2Clx XgDXC4XlUSocRVQvMvLSTfByXQXxn3kvDcDoyw4d+kTUO4g7M8C4Kp4FM10Y5A32GMOc /yhwFg4GCT/GiDWw4MhG97xU7gC/iIMcQnrTt3gNsQ1eeoOXO7nqIf5aVeZEucqDc7Xc HyYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=rU5siUELY8T233/GqOGiNLey1zfDrB+9LBy4lJ9V9n4=; b=KXDKANGabxCHRGICXRSCvYNotLF1Gnae3dH3GrahakiiasMqBY9tFiBxH/MlQGr3CF QuLd7+hC4wWLy3dCbGblvMTDv2CLVYbiiVr7Paw6IPkmboOqFElSO+rKKEj9ecDjA0mb qOiE8vGH70VHblv+4eDREcdUN06paLXfMg/fT6uzI4GWWk18IvfTJ/IyPMqgJ8aaN6Qp yG3t+e7z0UoiOrEsg7V0O8z8P0Ge5sRuuMe3b7T7cwB97K+V1aGyw1sGSrQ50DFUC4ib w+T38UMeYplUATpdFKkqeJd233nbznGfLUFq3Jk57XFKL5gOz681Ivinwbk5GgsL5CtG xzcw== X-Gm-Message-State: AMke39k+agS8P86uHd2CK6QNJ+EHzREv3xY7qnnjBapRp2EthJ1mvmeFdVTgMuPjgU/Xjkjh X-Received: by 10.237.41.229 with SMTP id o92mr15029731qtd.223.1486495013325; Tue, 07 Feb 2017 11:16:53 -0800 (PST) Received: from workstation.internal.cu ([152.254.219.119]) by smtp.gmail.com with ESMTPSA id b190sm4139871qkg.32.2017.02.07.11.16.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Feb 2017 11:16:52 -0800 (PST) From: Rafael David Tinoco To: linux-nfs@vger.kernel.org Cc: neilb@suse.com Subject: [PATCH] Fix nfs-mountd dependency on rpcbind Date: Tue, 7 Feb 2017 17:16:50 -0200 Message-Id: <20170207191650.19219-1-rafael.tinoco@canonical.com> X-Mailer: git-send-email 2.9.3 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Following commit 91da135f - it replaced "rpcbind.target" by "rpcbind.socket" in some unit files - "rpcbind.socket" should also be added to "nfs-mountd.service" as a dependency to avoid race conditions. Usually "rpcbind.socket" is either started as a "sockets.target" dependency, or as a dependency for "nfs-server.service", when unit files include it in "BindsTo" or "After". Unfortunately there is a possilibility to have "nfs-mountd.service" started when the rpcbind socket is not yet created: systemd[1]: Starting NFS Mount Daemon... systemd[1]: nfs-mountd.service: Control process exited, code=exited status=1 systemd[1]: Failed to start NFS Mount Daemon. systemd[1]: nfs-mountd.service: Unit entered failed state. systemd[1]: nfs-mountd.service: Failed with result 'exit-code'. Nowadays "nfs-mountd.service" uses "BindTo" directive to "nfs-server.service". That, per se, doesn't guarantee ordering for NFS server to start rpcbind and for nfs-mountd to depend on it. https://bugs.launchpad.net/bugs/1590799 Signed-off-by: Rafael David Tinoco --- systemd/nfs-mountd.service | 1 + 1 file changed, 1 insertion(+) diff --git a/systemd/nfs-mountd.service b/systemd/nfs-mountd.service index 15e828b..b0a8bc0 100644 --- a/systemd/nfs-mountd.service +++ b/systemd/nfs-mountd.service @@ -4,6 +4,7 @@ DefaultDependencies=no Requires=proc-fs-nfsd.mount After=proc-fs-nfsd.mount After=network.target local-fs.target +After=rpcbind.socket BindsTo=nfs-server.service [Service]