From patchwork Thu Feb 9 15:32:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 9564899 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D9FEB60216 for ; Thu, 9 Feb 2017 15:32:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C7F6A2853A for ; Thu, 9 Feb 2017 15:32:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BB5412853C; Thu, 9 Feb 2017 15:32:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 477E02853A for ; Thu, 9 Feb 2017 15:32:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753560AbdBIPc2 (ORCPT ); Thu, 9 Feb 2017 10:32:28 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:33972 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753534AbdBIPc1 (ORCPT ); Thu, 9 Feb 2017 10:32:27 -0500 Received: by mail-pf0-f193.google.com with SMTP id y143so439178pfb.1 for ; Thu, 09 Feb 2017 07:32:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=8KIeo29iLfI/EKD9Ev0hr5vg3HJ7n9Hd+eCgEKD2uxg=; b=TzMh0SIFH4a0Yz45A+L3RqlYsfaTYQrVehYyN76mI294fn2uVf1bVXM6UlnK8Vca2P F7wYnAot5zXOm3I9EOjdUL9f607CbMxmB5Li7BYNjFxIrbqKpeoyMLOBVLWxh4LclCYv /LxES10BZBYERmMCqzTXdOW2alVT1TZksQXprEadTwnRGS1CpY+JaHV55M4MoK38A7jd BSDp1zv9M0uLn+3Z6QSTdWGyxC0/UpTzV5b9iYDOlmHQdNSC+pTV2I46gsASp0YzyNtD ny44qq3DyqC8DO9+wUQi5H01ZJXjVo23Cj/66A07BR3HKMuRbS2gUMNwigwhtP5ZVFF7 xJfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=8KIeo29iLfI/EKD9Ev0hr5vg3HJ7n9Hd+eCgEKD2uxg=; b=KShSkd1Cc3qQMmFWgJhxki9O91P7voMa1cR9U4zPsp3B08OlDYl+L+F+xce6Gr5fWv b4tkznPptRu7LtsS8bjtE+lAsgathDG7RxZ/d6Dw5ZRwtULx/x1PGZMTdo6TCnv+QLCG seC01jrxVQV5IatJITN3UeIQ2Otpk6gNQRmkSVgI8gll4z1KX7Wc7kwcZS9TwraM/MNm 3KXVUY0QtpgyukVonRA044jPNdeNGhXEOg8YDQLZCk8qqtGJ7nJH9W339kFS+TcPQ75L M5oXeJMzZzzedVSnIwdYP/s8KK6ruk22ZQkESfrRWDS9QFOZioQkHiAZKWera2uv58C2 nHsA== X-Gm-Message-State: AMke39nXDCB5r9FmOD4YALjc6RG8JRSxSajCX23Dgcqr2ddQCt5d08FlAPXZLVPUjFK2DQ== X-Received: by 10.84.209.203 with SMTP id y69mr4906961plh.115.1486654346781; Thu, 09 Feb 2017 07:32:26 -0800 (PST) Received: from 192.168.0.37 (ec2-52-192-197-227.ap-northeast-1.compute.amazonaws.com. [52.192.197.227]) by smtp.gmail.com with ESMTPSA id o24sm29916189pfj.78.2017.02.09.07.32.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Feb 2017 07:32:26 -0800 (PST) From: Wei Yongjun To: Mark Brown Cc: Wei Yongjun , linux-spi@vger.kernel.org Subject: [PATCH -next] spi: bcm-qspi: Remove unnecessary platform_set_drvdata() Date: Thu, 9 Feb 2017 15:32:21 +0000 Message-Id: <20170209153221.2698-1-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.9.3 MIME-Version: 1.0 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Wei Yongjun The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Wei Yongjun --- drivers/spi/spi-bcm-qspi.c | 1 - 1 file changed, 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/spi/spi-bcm-qspi.c b/drivers/spi/spi-bcm-qspi.c index 227096a..b3745d4 100644 --- a/drivers/spi/spi-bcm-qspi.c +++ b/drivers/spi/spi-bcm-qspi.c @@ -1399,7 +1399,6 @@ int bcm_qspi_remove(struct platform_device *pdev) { struct bcm_qspi *qspi = platform_get_drvdata(pdev); - platform_set_drvdata(pdev, NULL); bcm_qspi_hw_uninit(qspi); clk_disable_unprepare(qspi->clk); kfree(qspi->dev_ids);