| Message ID | 1486659308-41163-1-git-send-email-bryantly@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
On Thu, 2017-02-09 at 10:55 -0600, Bryant G. Ly wrote: > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_rdma': > warning: unused variable 'srp' [-Wunused-variable] > struct srp_cmd *srp = (struct srp_cmd *)iue->sbuf->buf; > > Signed-off-by: Bryant G. Ly <bryantly@linux.vnet.ibm.com> > --- > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c > index 4bb5635..fe4ad65 100644 > --- a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c > +++ b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c > @@ -3083,9 +3083,6 @@ static int ibmvscsis_rdma(struct ibmvscsis_cmd *cmd, struct scatterlist *sg, > vscsi->dds.window[LOCAL].liobn, > server_ioba); > } else { > - /* write to client */ > - struct srp_cmd *srp = (struct srp_cmd *)iue->sbuf->buf; > - > /* The h_copy_rdma will cause phyp, running in another > * partition, to read memory, so we need to make sure > * the data has been written out, hence these syncs. Applied. Thanks Bryant. -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 2017-02-09 at 17:23 -0800, Nicholas A. Bellinger wrote: > On Thu, 2017-02-09 at 10:55 -0600, Bryant G. Ly wrote: > > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_rdma': > > warning: unused variable 'srp' [-Wunused-variable] > > struct srp_cmd *srp = (struct srp_cmd *)iue->sbuf->buf; > > > > Signed-off-by: Bryant G. Ly <bryantly@linux.vnet.ibm.com> > > --- > > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c > > index 4bb5635..fe4ad65 100644 > > --- a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c > > +++ b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c > > @@ -3083,9 +3083,6 @@ static int ibmvscsis_rdma(struct ibmvscsis_cmd *cmd, struct scatterlist *sg, > > vscsi->dds.window[LOCAL].liobn, > > server_ioba); > > } else { > > - /* write to client */ > > - struct srp_cmd *srp = (struct srp_cmd *)iue->sbuf->buf; > > - > > /* The h_copy_rdma will cause phyp, running in another > > * partition, to read memory, so we need to make sure > > * the data has been written out, hence these syncs. > > Applied. Thanks Bryant. > Er, this doesn't assignment doesn't exist in v4.10-rc7..? -- To unsubscribe from this list: send the line "unsubscribe target-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c index 4bb5635..fe4ad65 100644 --- a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c +++ b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c @@ -3083,9 +3083,6 @@ static int ibmvscsis_rdma(struct ibmvscsis_cmd *cmd, struct scatterlist *sg, vscsi->dds.window[LOCAL].liobn, server_ioba); } else { - /* write to client */ - struct srp_cmd *srp = (struct srp_cmd *)iue->sbuf->buf; - /* The h_copy_rdma will cause phyp, running in another * partition, to read memory, so we need to make sure * the data has been written out, hence these syncs.
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_rdma': warning: unused variable 'srp' [-Wunused-variable] struct srp_cmd *srp = (struct srp_cmd *)iue->sbuf->buf; Signed-off-by: Bryant G. Ly <bryantly@linux.vnet.ibm.com> --- drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 3 --- 1 file changed, 3 deletions(-)