| Message ID | 20170210010521.78872-2-briannorris@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On Thu, Feb 9, 2017 at 5:05 PM, Brian Norris <briannorris@chromium.org> wrote: > From: Douglas Anderson <dianders@chromium.org> > > We'd like to be able to use the cros-ec-keyboard.dtsi and > cros-ec-sbs.dtsi snippets for arm64 devices. Currently those files live > in the arm/boot/dts directory. > > Let's follow the convention set by commit 8ee57b8182c4 ("ARM64: dts: > vexpress: Use a symlink to vexpress-v2m-rs1.dtsi from arch=arm") and use > a symlink. Note that in this case we put the files in a new > "include/common" directory since these snippets may need to be > referenced by dts files in many different subdirectories. I'd rather have something like this: https://marc.info/?m=147547436324674&w=2 Instead of having everybody move things over. I.e. make it easy to refer to the arm version from arm64 instead of creating a "common" layer inbetween. -Olof
Hi Olof, Am Dienstag, 21. Februar 2017, 15:47:31 CET schrieb Olof Johansson: > On Thu, Feb 9, 2017 at 5:05 PM, Brian Norris <briannorris@chromium.org> wrote: > > From: Douglas Anderson <dianders@chromium.org> > > > > We'd like to be able to use the cros-ec-keyboard.dtsi and > > cros-ec-sbs.dtsi snippets for arm64 devices. Currently those files live > > in the arm/boot/dts directory. > > > > Let's follow the convention set by commit 8ee57b8182c4 ("ARM64: dts: > > vexpress: Use a symlink to vexpress-v2m-rs1.dtsi from arch=arm") and use > > a symlink. Note that in this case we put the files in a new > > "include/common" directory since these snippets may need to be > > referenced by dts files in many different subdirectories. > > I'd rather have something like this: > > https://marc.info/?m=147547436324674&w=2 > > Instead of having everybody move things over. I.e. make it easy to > refer to the arm version from arm64 instead of creating a "common" > layer inbetween. just so it gets noticed, I've done and tested [0], which hopefully should implement your suggestions above. If that looks ok, how do you want that picked up? Should I just include them in my regular rockchip branches or do you to pick them into some immutable branch, if other surprise-users turn up in time for 4.12? Thanks Heiko [0] http://lists.infradead.org/pipermail/linux-rockchip/2017-February/014226.html
In case this thread is easier to notice... Olof, On Mon, Feb 27, 2017 at 07:20:48PM +0100, Heiko Stuebner wrote: > Am Dienstag, 21. Februar 2017, 15:47:31 CET schrieb Olof Johansson: > > On Thu, Feb 9, 2017 at 5:05 PM, Brian Norris <briannorris@chromium.org> wrote: > > > From: Douglas Anderson <dianders@chromium.org> > > > > > > We'd like to be able to use the cros-ec-keyboard.dtsi and > > > cros-ec-sbs.dtsi snippets for arm64 devices. Currently those files live > > > in the arm/boot/dts directory. > > > > > > Let's follow the convention set by commit 8ee57b8182c4 ("ARM64: dts: > > > vexpress: Use a symlink to vexpress-v2m-rs1.dtsi from arch=arm") and use > > > a symlink. Note that in this case we put the files in a new > > > "include/common" directory since these snippets may need to be > > > referenced by dts files in many different subdirectories. > > > > I'd rather have something like this: > > > > https://marc.info/?m=147547436324674&w=2 > > > > Instead of having everybody move things over. I.e. make it easy to > > refer to the arm version from arm64 instead of creating a "common" > > layer inbetween. > > just so it gets noticed, I've done and tested [0], which hopefully should > implement your suggestions above. > > If that looks ok, how do you want that picked up? Should I just include > them in my regular rockchip branches or do you to pick them into some > immutable branch, if other surprise-users turn up in time for 4.12? Ping? I suppose we can prevent users in 4.12 by never merging this :) Brian > > > [0] http://lists.infradead.org/pipermail/linux-rockchip/2017-February/014226.html > >
Hi, On Tue, Feb 28, 2017 at 3:20 AM, Heiko Stuebner <heiko@sntech.de> wrote: > Hi Olof, > > Am Dienstag, 21. Februar 2017, 15:47:31 CET schrieb Olof Johansson: >> On Thu, Feb 9, 2017 at 5:05 PM, Brian Norris <briannorris@chromium.org> wrote: >> > From: Douglas Anderson <dianders@chromium.org> >> > >> > We'd like to be able to use the cros-ec-keyboard.dtsi and >> > cros-ec-sbs.dtsi snippets for arm64 devices. Currently those files live >> > in the arm/boot/dts directory. >> > >> > Let's follow the convention set by commit 8ee57b8182c4 ("ARM64: dts: >> > vexpress: Use a symlink to vexpress-v2m-rs1.dtsi from arch=arm") and use >> > a symlink. Note that in this case we put the files in a new >> > "include/common" directory since these snippets may need to be >> > referenced by dts files in many different subdirectories. >> >> I'd rather have something like this: >> >> https://marc.info/?m=147547436324674&w=2 >> >> Instead of having everybody move things over. I.e. make it easy to >> refer to the arm version from arm64 instead of creating a "common" >> layer inbetween. > > just so it gets noticed, I've done and tested [0], which hopefully should > implement your suggestions above. > > If that looks ok, how do you want that picked up? Should I just include > them in my regular rockchip branches or do you to pick them into some > immutable branch, if other surprise-users turn up in time for 4.12? Sigh. I completely dropped the ball on this, and I didn't see it included in any of your pull requests for 4.12 since I never actually acked that approach. I've applied the patches onto a dt/include-paths stable branch, but we're late for merging dependent code on top of it for 4.12. -Olof
Am Mittwoch, 19. April 2017, 21:54:09 CEST schrieb Olof Johansson: > Hi, > > On Tue, Feb 28, 2017 at 3:20 AM, Heiko Stuebner <heiko@sntech.de> wrote: > > Hi Olof, > > > > Am Dienstag, 21. Februar 2017, 15:47:31 CET schrieb Olof Johansson: > >> On Thu, Feb 9, 2017 at 5:05 PM, Brian Norris <briannorris@chromium.org> wrote: > >> > From: Douglas Anderson <dianders@chromium.org> > >> > > >> > We'd like to be able to use the cros-ec-keyboard.dtsi and > >> > cros-ec-sbs.dtsi snippets for arm64 devices. Currently those files live > >> > in the arm/boot/dts directory. > >> > > >> > Let's follow the convention set by commit 8ee57b8182c4 ("ARM64: dts: > >> > vexpress: Use a symlink to vexpress-v2m-rs1.dtsi from arch=arm") and use > >> > a symlink. Note that in this case we put the files in a new > >> > "include/common" directory since these snippets may need to be > >> > referenced by dts files in many different subdirectories. > >> > >> I'd rather have something like this: > >> > >> https://marc.info/?m=147547436324674&w=2 > >> > >> Instead of having everybody move things over. I.e. make it easy to > >> refer to the arm version from arm64 instead of creating a "common" > >> layer inbetween. > > > > just so it gets noticed, I've done and tested [0], which hopefully should > > implement your suggestions above. > > > > If that looks ok, how do you want that picked up? Should I just include > > them in my regular rockchip branches or do you to pick them into some > > immutable branch, if other surprise-users turn up in time for 4.12? > > Sigh. I completely dropped the ball on this, and I didn't see it > included in any of your pull requests for 4.12 since I never actually > acked that approach. > > I've applied the patches onto a dt/include-paths stable branch, but > we're late for merging dependent code on top of it for 4.12. Didn't you merge the patches into a branch already and the rk3399-gru support on top of it? Aka https://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git/log/?h=shared/dt-symlinks Which one of my previous pull requests was already based on. Heiko
On Wed, Apr 19, 2017 at 10:25 PM, Heiko Stuebner <heiko@sntech.de> wrote: > Am Mittwoch, 19. April 2017, 21:54:09 CEST schrieb Olof Johansson: >> Hi, >> >> On Tue, Feb 28, 2017 at 3:20 AM, Heiko Stuebner <heiko@sntech.de> wrote: >> > Hi Olof, >> > >> > Am Dienstag, 21. Februar 2017, 15:47:31 CET schrieb Olof Johansson: >> >> On Thu, Feb 9, 2017 at 5:05 PM, Brian Norris <briannorris@chromium.org> wrote: >> >> > From: Douglas Anderson <dianders@chromium.org> >> >> > >> >> > We'd like to be able to use the cros-ec-keyboard.dtsi and >> >> > cros-ec-sbs.dtsi snippets for arm64 devices. Currently those files live >> >> > in the arm/boot/dts directory. >> >> > >> >> > Let's follow the convention set by commit 8ee57b8182c4 ("ARM64: dts: >> >> > vexpress: Use a symlink to vexpress-v2m-rs1.dtsi from arch=arm") and use >> >> > a symlink. Note that in this case we put the files in a new >> >> > "include/common" directory since these snippets may need to be >> >> > referenced by dts files in many different subdirectories. >> >> >> >> I'd rather have something like this: >> >> >> >> https://marc.info/?m=147547436324674&w=2 >> >> >> >> Instead of having everybody move things over. I.e. make it easy to >> >> refer to the arm version from arm64 instead of creating a "common" >> >> layer inbetween. >> > >> > just so it gets noticed, I've done and tested [0], which hopefully should >> > implement your suggestions above. >> > >> > If that looks ok, how do you want that picked up? Should I just include >> > them in my regular rockchip branches or do you to pick them into some >> > immutable branch, if other surprise-users turn up in time for 4.12? >> >> Sigh. I completely dropped the ball on this, and I didn't see it >> included in any of your pull requests for 4.12 since I never actually >> acked that approach. >> >> I've applied the patches onto a dt/include-paths stable branch, but >> we're late for merging dependent code on top of it for 4.12. > > Didn't you merge the patches into a branch already and the rk3399-gru > support on top of it? > > Aka > https://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git/log/?h=shared/dt-symlinks > > Which one of my previous pull requests was already based on. Yeah, ignore the above (the original branch is the one to use). I must be turning blind. Adding Maxime on Cc since I asked him to move over to the new include model post-rc1 for some of his stuff. -Olof
diff --git a/arch/arm64/boot/dts/include/common/cros-ec-keyboard.dtsi b/arch/arm64/boot/dts/include/common/cros-ec-keyboard.dtsi new file mode 120000 index 000000000000..1c1889f0a791 --- /dev/null +++ b/arch/arm64/boot/dts/include/common/cros-ec-keyboard.dtsi @@ -0,0 +1 @@ +../../../../../arm/boot/dts/cros-ec-keyboard.dtsi \ No newline at end of file diff --git a/arch/arm64/boot/dts/include/common/cros-ec-sbs.dtsi b/arch/arm64/boot/dts/include/common/cros-ec-sbs.dtsi new file mode 120000 index 000000000000..3d7ae9c88bcd --- /dev/null +++ b/arch/arm64/boot/dts/include/common/cros-ec-sbs.dtsi @@ -0,0 +1 @@ +../../../../../arm/boot/dts/cros-ec-sbs.dtsi \ No newline at end of file