Patchwork dma-buf/dma-fence: improve doc for dma_fence_add_callback()

login
register
mail settings
Submitter Gustavo F. Padovan
Date Feb. 15, 2017, 5:57 p.m.
Message ID <20170215175725.6692-1-gustavo@padovan.org>
Download mbox | patch
Permalink /patch/9574659/
State New
Headers show

Comments

Gustavo F. Padovan - Feb. 15, 2017, 5:57 p.m.
From: Gustavo Padovan <gustavo.padovan@collabora.com>

Document return values for this function.

Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
---
 drivers/dma-buf/dma-fence.c | 2 ++
 1 file changed, 2 insertions(+)
Chris Wilson - Feb. 15, 2017, 8:57 p.m.
On Wed, Feb 15, 2017 at 03:57:25PM -0200, Gustavo Padovan wrote:
> From: Gustavo Padovan <gustavo.padovan@collabora.com>
> 
> Document return values for this function.
> 
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
Sumit Semwal - Feb. 16, 2017, 4:31 a.m.
Hi Gustavo,


On 16 February 2017 at 02:27, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Wed, Feb 15, 2017 at 03:57:25PM -0200, Gustavo Padovan wrote:
>> From: Gustavo Padovan <gustavo.padovan@collabora.com>
>>
>> Document return values for this function.
>>
>> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> -Chris
>
Thanks, pushed to drm-misc.

> --
> Chris Wilson, Intel Open Source Technology Centre
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Patch

diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c
index d1f1f45..809b397 100644
--- a/drivers/dma-buf/dma-fence.c
+++ b/drivers/dma-buf/dma-fence.c
@@ -239,6 +239,8 @@  EXPORT_SYMBOL(dma_fence_enable_sw_signaling);
  * after it signals with dma_fence_signal. The callback itself can be called
  * from irq context.
  *
+ * Returns 0 in case of success, -ENOENT if the fence is already signaled
+ * and -EINVAL in case of error.
  */
 int dma_fence_add_callback(struct dma_fence *fence, struct dma_fence_cb *cb,
 			   dma_fence_func_t func)