diff mbox

[3/3] ARM: socfpga: PM: Drop useless check for PM_SUSPEND_STANDBY

Message ID 1487347836-14427-4-git-send-email-geert+renesas@glider.be (mailing list archive)
State New, archived
Headers show

Commit Message

Geert Uytterhoeven Feb. 17, 2017, 4:10 p.m. UTC
As SoCFPGA uses the standard suspend_valid_only_mem() for its
platform_suspend_ops.valid() callback, its platform_suspend_ops.enter()
callback will never be called with state equal to PM_SUSPEND_STANDBY.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/mach-socfpga/pm.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Dinh Nguyen Feb. 19, 2017, 8:15 p.m. UTC | #1
On 02/17/2017 10:10 AM, Geert Uytterhoeven wrote:
> As SoCFPGA uses the standard suspend_valid_only_mem() for its
> platform_suspend_ops.valid() callback, its platform_suspend_ops.enter()
> callback will never be called with state equal to PM_SUSPEND_STANDBY.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  arch/arm/mach-socfpga/pm.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/mach-socfpga/pm.c b/arch/arm/mach-socfpga/pm.c
> index c378ab0c24317ccf..d4866788702cb87a 100644
> --- a/arch/arm/mach-socfpga/pm.c
> +++ b/arch/arm/mach-socfpga/pm.c
> @@ -116,7 +116,6 @@ static int socfpga_pm_suspend(unsigned long arg)
>  static int socfpga_pm_enter(suspend_state_t state)
>  {
>  	switch (state) {
> -	case PM_SUSPEND_STANDBY:
>  	case PM_SUSPEND_MEM:
>  		outer_disable();
>  		cpu_suspend(0, socfpga_pm_suspend);
>

Acked-by: Dinh Nguyen <dinguyen@kernel.org>

Dinh

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/mach-socfpga/pm.c b/arch/arm/mach-socfpga/pm.c
index c378ab0c24317ccf..d4866788702cb87a 100644
--- a/arch/arm/mach-socfpga/pm.c
+++ b/arch/arm/mach-socfpga/pm.c
@@ -116,7 +116,6 @@  static int socfpga_pm_suspend(unsigned long arg)
 static int socfpga_pm_enter(suspend_state_t state)
 {
 	switch (state) {
-	case PM_SUSPEND_STANDBY:
 	case PM_SUSPEND_MEM:
 		outer_disable();
 		cpu_suspend(0, socfpga_pm_suspend);