[1/1] ASoC: Add AU1761 audio codec as selectable option
diff mbox

Message ID 1487970034-6003-1-git-send-email-me
State Accepted
Commit e54fde61715df828c2f06883a6eb756bb5d88006
Headers show

Commit Message

me@rockwellcollins.com Feb. 24, 2017, 9 p.m. UTC
From: Bryce Ferguson <bryce.ferguson@rockwellcollins.com>

This commit adds the ADI AU1761 audio codec as a selectable option
in the kernel config.  Currently the driver can only be selected
for ADI blackfin devices or if SND_SOC_ALL_CODECS is enabled.

Signed-off-by: Bryce Ferguson <bryce.ferguson@rockwellcollins.com>

Comments

Lars-Peter Clausen Feb. 27, 2017, 11:33 a.m. UTC | #1
On 02/24/2017 10:00 PM, me@rockwellcollins.com wrote:
> From: Bryce Ferguson <bryce.ferguson@rockwellcollins.com>
> 
> This commit adds the ADI AU1761 audio codec as a selectable option
> in the kernel config.  Currently the driver can only be selected
> for ADI blackfin devices or if SND_SOC_ALL_CODECS is enabled.
> 
> Signed-off-by: Bryce Ferguson <bryce.ferguson@rockwellcollins.com>

Looks good, makes sense.

Acked-by: Lars-Peter Clausen <lars@metafoo.de>

But you need to send the patch to the ASoC maintainers Mark
(<broonie@kernel.org>) and Liam (girdwood@gmail.com) to get it applied. The
patch should be send to the maintainers and with the mailinglist on CC.

- Lars

> 
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index e49e9da..43539c3b 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -303,12 +303,14 @@ config SND_SOC_ADAU1761
>  	select SND_SOC_ADAU17X1
>  
>  config SND_SOC_ADAU1761_I2C
> -	tristate
> +	tristate "Analog Devices AU1761 CODEC - I2C"
> +	depends on I2C
>  	select SND_SOC_ADAU1761
>  	select REGMAP_I2C
>  
>  config SND_SOC_ADAU1761_SPI
> -	tristate
> +	tristate "Analog Devices AU1761 CODEC - SPI"
> +	depends on SPI
>  	select SND_SOC_ADAU1761
>  	select REGMAP_SPI
>  
>
Bryce Ferguson Feb. 27, 2017, 2:01 p.m. UTC | #2
Lars,

On Mon, Feb 27, 2017 at 5:33 AM, Lars-Peter Clausen <lars@metafoo.de> wrote:
> On 02/24/2017 10:00 PM, me@rockwellcollins.com wrote:
>> From: Bryce Ferguson <bryce.ferguson@rockwellcollins.com>
>>
>> This commit adds the ADI AU1761 audio codec as a selectable option
>> in the kernel config.  Currently the driver can only be selected
>> for ADI blackfin devices or if SND_SOC_ALL_CODECS is enabled.
>>
>> Signed-off-by: Bryce Ferguson <bryce.ferguson@rockwellcollins.com>
>
> Looks good, makes sense.
>
> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
>
> But you need to send the patch to the ASoC maintainers Mark
> (<broonie@kernel.org>) and Liam (girdwood@gmail.com) to get it applied. The
> patch should be send to the maintainers and with the mailinglist on CC.
>
> - Lars
>

I will make sure to do that.  Thank you very much for the input and
the direction.

-Bryce

Patch
diff mbox

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index e49e9da..43539c3b 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -303,12 +303,14 @@  config SND_SOC_ADAU1761
 	select SND_SOC_ADAU17X1
 
 config SND_SOC_ADAU1761_I2C
-	tristate
+	tristate "Analog Devices AU1761 CODEC - I2C"
+	depends on I2C
 	select SND_SOC_ADAU1761
 	select REGMAP_I2C
 
 config SND_SOC_ADAU1761_SPI
-	tristate
+	tristate "Analog Devices AU1761 CODEC - SPI"
+	depends on SPI
 	select SND_SOC_ADAU1761
 	select REGMAP_SPI