From patchwork Mon Mar 6 09:49:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kinglong Mee X-Patchwork-Id: 9605675 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DE24B6046A for ; Mon, 6 Mar 2017 10:52:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 067E625EA6 for ; Mon, 6 Mar 2017 10:52:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EE9D926419; Mon, 6 Mar 2017 10:52:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 77BE125EA6 for ; Mon, 6 Mar 2017 10:52:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752881AbdCFKwT (ORCPT ); Mon, 6 Mar 2017 05:52:19 -0500 Received: from mail-it0-f66.google.com ([209.85.214.66]:33964 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752910AbdCFKwB (ORCPT ); Mon, 6 Mar 2017 05:52:01 -0500 Received: by mail-it0-f66.google.com with SMTP id r141so9109768ita.1 for ; Mon, 06 Mar 2017 02:50:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:from:subject:message-id:date:user-agent:mime-version :content-transfer-encoding; bh=uZswx0BgOq9hD8adL7jKL9P4CDOfubr7lbBfYKP4lNQ=; b=YDSP90lahv//Go2modv6Myn34GLJ3OTkgHi4rGMsh4mWYrrVPyoLt/6Mjxpk6rxKOL DwyzzS0ONukBBVux7jxRfD9qJkFVPQaWK85z/deNAN38o6z4Ol5zqvVz7SOuSiuyhEOb g37x1N48hY9UUqK8izQIM5LA5fTVCXF/u1mnJ2K9jaQ1EsNNFdvfPyRQ0eimwkmFjuWq cgG4xC7e9Pt8FHN7GW1jQ74EoPHLnmohtJVE7MLwm3m6kS5OE8FxzDb5UhpTdKIysxf7 D3WbnDpR26kKJbgzArH7jqILaZZxZDUgW/v5nyTUXEsKgaQmJWRWkodWREu9l0XPeXm1 9RNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:from:subject:message-id:date:user-agent :mime-version:content-transfer-encoding; bh=uZswx0BgOq9hD8adL7jKL9P4CDOfubr7lbBfYKP4lNQ=; b=hBliHXmciBfedwrKV+Ms9eGHxbVfKQQG2V0K50ypggLxRvWudxKrQP4TJuhfpXWO1P 7d5LltkajAAJtvCp0wQwmi0fPrwW2S8p+M56lKN8b7ynxIujW0o6eUzFXvEJ0Vrp1/Gm 5DEx6vhQW6GQtKLR54XL//PjtlxBa5NgSrqewvPeX8mwGctqJdy450TBdsAHblLSrig6 DJeoxxwYJ+awC23sBnffdHXhouRdZ67pVrrs+jhB3x6n3FprF3T1sNDtv8TRnjrAbJTQ /nOXrJ3f44TAacfu0qbCQHMkp9owQRKEteq+Ne+0Hs+46bwwR+koMVGEbWR6ULDNi2gm V4ew== X-Gm-Message-State: AMke39lfrNNCZ6rnvK8jjoangjjm7vdPCBMYUrCNdoyc085Y0fj08MPw6CjDsIhhzYN/gQ== X-Received: by 10.36.252.65 with SMTP id b62mr13876330ith.38.1488793793476; Mon, 06 Mar 2017 01:49:53 -0800 (PST) Received: from [192.168.0.107] ([183.228.28.90]) by smtp.gmail.com with ESMTPSA id r10sm3954159iod.33.2017.03.06.01.49.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Mar 2017 01:49:53 -0800 (PST) To: Trond Myklebust , "linux-nfs@vger.kernel.org" Cc: Anna Schumaker , Kinglong Mee From: Kinglong Mee Subject: [PATCH] nfs4: fix a typo of NFS_ATTR_FATTR_GROUP_NAME Message-ID: Date: Mon, 6 Mar 2017 17:49:42 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This typo cause a memory leak, and a bad client's group id. unreferenced object 0xffff96d8073998d0 (size 8): comm "kworker/0:3", pid 34224, jiffies 4295361338 (age 761.752s) hex dump (first 8 bytes): 30 00 39 07 d8 96 ff ff 0.9..... backtrace: [] kmemleak_alloc+0x4a/0xa0 [] __kmalloc+0x140/0x220 [] xdr_stream_decode_string_dup+0x7c/0x110 [sunrpc] [] decode_getfattr_attrs+0x940/0x1630 [nfsv4] [] decode_getfattr_generic.constprop.108+0x9b/0x100 [nfsv4] [] nfs4_xdr_dec_open+0xcf/0x100 [nfsv4] [] rpcauth_unwrap_resp+0xa7/0xe0 [sunrpc] [] call_decode+0x1e0/0x810 [sunrpc] [] __rpc_execute+0x8d/0x420 [sunrpc] [] rpc_async_schedule+0x12/0x20 [sunrpc] [] process_one_work+0x197/0x430 [] worker_thread+0x4e/0x4a0 [] kthread+0x101/0x140 [] ret_from_fork+0x2c/0x40 [] 0xffffffffffffffff Fixes: 686a816ab6 ("NFSv4: Clean up owner/group attribute decode") Signed-off-by: Kinglong Mee --- fs/nfs/nfs4xdr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfs/nfs4xdr.c b/fs/nfs/nfs4xdr.c index f0369e3..80ce289 100644 --- a/fs/nfs/nfs4xdr.c +++ b/fs/nfs/nfs4xdr.c @@ -3942,7 +3942,7 @@ static int decode_attr_group(struct xdr_stream *xdr, uint32_t *bitmap, if (len <= 0) goto out; dprintk("%s: name=%s\n", __func__, group_name->data); - return NFS_ATTR_FATTR_OWNER_NAME; + return NFS_ATTR_FATTR_GROUP_NAME; } else { len = xdr_stream_decode_opaque_inline(xdr, (void **)&p, XDR_MAX_NETOBJ);