[01/24] drm/doc: Add todo about connector_list_iter
diff mbox

Message ID 20170308141257.12119-2-daniel.vetter@ffwll.ch
State New
Headers show

Commit Message

Daniel Vetter March 8, 2017, 2:12 p.m. UTC
At least radeon, amdgpu and nouveau should be converted. We have
patches for i915 already.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 Documentation/gpu/todo.rst | 13 +++++++++++++
 1 file changed, 13 insertions(+)

Comments

Sean Paul March 8, 2017, 3:12 p.m. UTC | #1
On Wed, Mar 08, 2017 at 03:12:34PM +0100, Daniel Vetter wrote:
> At least radeon, amdgpu and nouveau should be converted. We have
> patches for i915 already.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>  Documentation/gpu/todo.rst | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
> index ce0f1a588e7f..63c7088cace3 100644
> --- a/Documentation/gpu/todo.rst
> +++ b/Documentation/gpu/todo.rst
> @@ -153,6 +153,19 @@ following drivers still use ``struct_mutex``: ``msm``, ``omapdrm`` and
>  
>  Contact: Daniel Vetter
>  
> +Switch to drm_connector_list_iter for any connector_list walking
> +----------------------------------------------------------------
> +
> +Connectors can be hotplugged, and we now have a special list of helpers to walk
> +the connector_list in a race-free fashion, without incuring deadlocks on mutexes

s/incuring/incurring/

With that,

Reviewed-by: Sean Paul <seanpaul@chromium.org>

> +and other fun stuff.
> +
> +Unfortunately most drivers are not converted yet. At least all those supporting
> +DP MST hotplug should be converted, since for those drivers the difference
> +matters. See drm_for_each_connector_iter() vs. drm_for_each_connector().
> +
> +Contact: Daniel Vetter
> +
>  Core refactorings
>  =================
>  
> -- 
> 2.11.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Patch
diff mbox

diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
index ce0f1a588e7f..63c7088cace3 100644
--- a/Documentation/gpu/todo.rst
+++ b/Documentation/gpu/todo.rst
@@ -153,6 +153,19 @@  following drivers still use ``struct_mutex``: ``msm``, ``omapdrm`` and
 
 Contact: Daniel Vetter
 
+Switch to drm_connector_list_iter for any connector_list walking
+----------------------------------------------------------------
+
+Connectors can be hotplugged, and we now have a special list of helpers to walk
+the connector_list in a race-free fashion, without incuring deadlocks on mutexes
+and other fun stuff.
+
+Unfortunately most drivers are not converted yet. At least all those supporting
+DP MST hotplug should be converted, since for those drivers the difference
+matters. See drm_for_each_connector_iter() vs. drm_for_each_connector().
+
+Contact: Daniel Vetter
+
 Core refactorings
 =================