diff mbox

[i-g-t,1/4] lib/intel_device_info: Remove unused whitney definition

Message ID 1488984275-8428-2-git-send-email-petri.latvala@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Petri Latvala March 8, 2017, 2:44 p.m. UTC
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
---
 lib/intel_device_info.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Chris Wilson March 8, 2017, 2:53 p.m. UTC | #1
On Wed, Mar 08, 2017 at 04:44:32PM +0200, Petri Latvala wrote:
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> ---
>  lib/intel_device_info.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
> index db4f383..41d94b5 100644
> --- a/lib/intel_device_info.c
> +++ b/lib/intel_device_info.c
> @@ -9,12 +9,6 @@ static const struct intel_device_info intel_generic_info = {
>  	.gen = 0,
>  };
>  
> -static const struct intel_device_info intel_i81x_info = {
> -	.gen = BIT(0),
> -	.is_whitney = true,
> -	.codename = "solano" /* 815 == "whitney" ? or vice versa? */
> -};

No!!! Send the patches to enable gen1 in the kernel... :)
-Chris
Chris Wilson March 8, 2017, 3:11 p.m. UTC | #2
On Wed, Mar 08, 2017 at 02:53:48PM +0000, Chris Wilson wrote:
> On Wed, Mar 08, 2017 at 04:44:32PM +0200, Petri Latvala wrote:
> > Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> > ---
> >  lib/intel_device_info.c | 6 ------
> >  1 file changed, 6 deletions(-)
> > 
> > diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
> > index db4f383..41d94b5 100644
> > --- a/lib/intel_device_info.c
> > +++ b/lib/intel_device_info.c
> > @@ -9,12 +9,6 @@ static const struct intel_device_info intel_generic_info = {
> >  	.gen = 0,
> >  };
> >  
> > -static const struct intel_device_info intel_i81x_info = {
> > -	.gen = BIT(0),
> > -	.is_whitney = true,
> > -	.codename = "solano" /* 815 == "whitney" ? or vice versa? */
> > -};
> 
> No!!! Send the patches to enable gen1 in the kernel... :)

To be more specific, we could just add the pci-ids to i915_pciids.h and
start preparing for the support.
-Chris
diff mbox

Patch

diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
index db4f383..41d94b5 100644
--- a/lib/intel_device_info.c
+++ b/lib/intel_device_info.c
@@ -9,12 +9,6 @@  static const struct intel_device_info intel_generic_info = {
 	.gen = 0,
 };
 
-static const struct intel_device_info intel_i81x_info = {
-	.gen = BIT(0),
-	.is_whitney = true,
-	.codename = "solano" /* 815 == "whitney" ? or vice versa? */
-};
-
 static const struct intel_device_info intel_i830_info = {
 	.gen = BIT(1),
 	.is_almador = true,