[01/16] tools: fix typo in tools/Rules.mk
diff mbox

Message ID 20170308144945.8934-2-jgross@suse.com
State New, archived
Headers show

Commit Message

Jürgen Groß March 8, 2017, 2:49 p.m. UTC
Commit 78fb69ad9 ("tools/Rules.mk: Properly handle libraries with
recursive dependencies.") introduced a copy and paste error in
tools/Rules.mk:

LDLIBS_libxenstore and SHLIB_libxenstore don't use SHDEPS_libxenstore
but SHDEPS_libxenguest. This will add a superfluous dependency of
libxenstore on libxenevtchn.

Correct this bug.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 tools/Rules.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Wei Liu March 13, 2017, 4:58 p.m. UTC | #1
On Wed, Mar 08, 2017 at 03:49:30PM +0100, Juergen Gross wrote:
> Commit 78fb69ad9 ("tools/Rules.mk: Properly handle libraries with
> recursive dependencies.") introduced a copy and paste error in
> tools/Rules.mk:
> 
> LDLIBS_libxenstore and SHLIB_libxenstore don't use SHDEPS_libxenstore
> but SHDEPS_libxenguest. This will add a superfluous dependency of
> libxenstore on libxenevtchn.
> 
> Correct this bug.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Acked-by: Wei Liu <wei.liu2@citrix.com>

Patch
diff mbox

diff --git a/tools/Rules.mk b/tools/Rules.mk
index e676c6b..835525a 100644
--- a/tools/Rules.mk
+++ b/tools/Rules.mk
@@ -139,8 +139,8 @@  SHLIB_libxenguest  = $(SHDEPS_libxenguest) -Wl,-rpath-link=$(XEN_LIBXC)
 
 CFLAGS_libxenstore = -I$(XEN_XENSTORE)/include $(CFLAGS_xeninclude)
 SHDEPS_libxenstore =
-LDLIBS_libxenstore = $(SHDEPS_libxenguest) $(XEN_XENSTORE)/libxenstore$(libextension)
-SHLIB_libxenstore  = $(SHDEPS_libxenguest) -Wl,-rpath-link=$(XEN_XENSTORE)
+LDLIBS_libxenstore = $(SHDEPS_libxenstore) $(XEN_XENSTORE)/libxenstore$(libextension)
+SHLIB_libxenstore  = $(SHDEPS_libxenstore) -Wl,-rpath-link=$(XEN_XENSTORE)
 
 CFLAGS_libxenstat  = -I$(XEN_LIBXENSTAT)
 SHDEPS_libxenstat  = $(SHLIB_libxenctrl) $(SHLIB_libxenstore)