[1/5] ASoC: cs35l35: Add missing return in probe
diff mbox

Message ID 1488991371-22513-1-git-send-email-ckeepax@opensource.wolfsonmicro.com
State Accepted
Commit 1bb06ada038548b4e2449159e80badf106bb779f
Headers show

Commit Message

Charles Keepax March 8, 2017, 4:42 p.m. UTC
A return statement is missing just before the error paths at the end of
probe. This causes us to fall straight into the error path and disable
the supplies and re-enable reset, as these are only controlled during
probe this causes the part to no longer function.

Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
 sound/soc/codecs/cs35l35.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Austin, Brian March 8, 2017, 7:55 p.m. UTC | #1
On 3/8/17, 10:42 AM, "alsa-devel-bounces@alsa-project.org on behalf of
Charles Keepax" <alsa-devel-bounces@alsa-project.org on behalf of
ckeepax@opensource.wolfsonmicro.com> wrote:

>A return statement is missing just before the error paths at the end of
>probe. This causes us to fall straight into the error path and disable
>the supplies and re-enable reset, as these are only controlled during
>probe this causes the part to no longer function.
>
>Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
>---

For the series
Acked-by: Brian Austin <brian.austin@cirrus.com>

Patch
diff mbox

diff --git a/sound/soc/codecs/cs35l35.c b/sound/soc/codecs/cs35l35.c
index 260ed42..48b45dc 100644
--- a/sound/soc/codecs/cs35l35.c
+++ b/sound/soc/codecs/cs35l35.c
@@ -1509,6 +1509,8 @@  static int cs35l35_i2c_probe(struct i2c_client *i2c_client,
 		goto err;
 	}
 
+	return 0;
+
 err:
 	regulator_bulk_disable(cs35l35->num_supplies,
 			       cs35l35->supplies);