Message ID | 20170308233748.54706-2-briannorris@chromium.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 64814602B4 for <patchwork-linux-rockchip@patchwork.kernel.org>; Wed, 8 Mar 2017 23:38:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 52A4528640 for <patchwork-linux-rockchip@patchwork.kernel.org>; Wed, 8 Mar 2017 23:38:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 42DB528643; Wed, 8 Mar 2017 23:38:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9F88D2863E for <patchwork-linux-rockchip@patchwork.kernel.org>; Wed, 8 Mar 2017 23:38:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=t5saB3CovFOdQJZsHMkGrMtdNJN6bwJoPm6eMGJdsss=; b=QmTrbZK13/d1C5gQ2GUw9GhIqB u/+RTNVrxxSBuqz9VTXqo9PsBfHaLQK5JaUHNHIdng99FOKETmJ6CNTG+9SJdvw4AeLFZKTYzo/C9 O80fisB3aQgy7x00NcaE1aPXlqbnDhSn6lyo3gnlf8OGGOTWZSeaGJScyqiGKL/1UsVKs0SFFfJr0 VA64ZxkAKL4AEo8QULEY1EdaMQ9LMgrrRar3wCAi2+Ei1N9zJQ0AnOpQb0NCtH0dGbRi2h/BdEWpP oe7rM/2BTqR8bUglL+S0uxpTnFLHfHHNfUu8t40xuLGxtzss71BrGwr+AouayyjWv5LFaEApoywD6 EmF31b9w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cllA1-0001Cg-Fb; Wed, 08 Mar 2017 23:38:25 +0000 Received: from mail-pf0-x231.google.com ([2607:f8b0:400e:c00::231]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cll9y-00019x-64 for linux-rockchip@lists.infradead.org; Wed, 08 Mar 2017 23:38:23 +0000 Received: by mail-pf0-x231.google.com with SMTP id v190so20802167pfb.1 for <linux-rockchip@lists.infradead.org>; Wed, 08 Mar 2017 15:38:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=B6KekmhpcmpOIsXoiPzpq895I0lQJynMplp+bOb82+4=; b=Eu2plSH9YWH05taQy4sHc8+miD/GnYpq9jzToV3UVJQg3xCX906uV7Mh/Rj9rNxz86 vmaQQ+vKIOjyMDDHxhyGJE+gBWt+Vo1EISYz20tAaCckJMvzYMdu1chyki1o7mNa0JPI qX48Ufe4YGuNuIQgtOenlAD25kPJIZW4/tWGI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=B6KekmhpcmpOIsXoiPzpq895I0lQJynMplp+bOb82+4=; b=jDusLW27b2l8fBrnPhl6kJ0SlHxPw7P5IYWplexItJ0zg0wiQXX9S5casu7W6uEP9f 74oV/PODLxhzcRxVWQyEYBEhhEBx/2cInRoQ0+MvZ9ZvalVyO+TlCsF6lRSbj27G4nOu nrPDKZ5Y3I1SPeIW8qdi++Er7uQ04mq/5BKkkJzqdJADgf6Fs2uh2nZCFHE0Ki6i/hTF /ggRdV/3lyTxFA2Xtb7zi5S4OHesC45hWXzwb1PM2WKN4g3Di8NJF6sKKde31HvjhNqN OiWevIIFU6lmviK3zHaQartCmWqUF7V5PZcKH+Tp4rBIVkRq+N1KECzJ3EWrvJ4CVh5o UVVw== X-Gm-Message-State: AMke39nfVvGH/R91Hk+8aoT0ybplMVy1b4z5sztejCeMFNTl13+IPcBuvrBdheuGs+rhb8GF X-Received: by 10.99.49.70 with SMTP id x67mr10052001pgx.128.1489016281104; Wed, 08 Mar 2017 15:38:01 -0800 (PST) Received: from ban.mtv.corp.google.com ([172.22.64.120]) by smtp.gmail.com with ESMTPSA id m21sm8266533pgh.4.2017.03.08.15.38.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 08 Mar 2017 15:38:00 -0800 (PST) From: Brian Norris <briannorris@chromium.org> To: Bjorn Helgaas <bhelgaas@google.com> Subject: [PATCH 2/3] PCI: rockchip: make 'return 0' more obvious in probe() Date: Wed, 8 Mar 2017 15:37:47 -0800 Message-Id: <20170308233748.54706-2-briannorris@chromium.org> X-Mailer: git-send-email 2.12.0.246.ga2ecc84866-goog In-Reply-To: <20170308233748.54706-1-briannorris@chromium.org> References: <20170308233748.54706-1-briannorris@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170308_153822_253763_4C898E00 X-CRM114-Status: UNSURE ( 8.89 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Upstream kernel work for Rockchip platforms <linux-rockchip.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-rockchip>, <mailto:linux-rockchip-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-rockchip/> List-Post: <mailto:linux-rockchip@lists.infradead.org> List-Help: <mailto:linux-rockchip-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-rockchip>, <mailto:linux-rockchip-request@lists.infradead.org?subject=subscribe> Cc: Jeffy Chen <jeffy.chen@rock-chips.com>, linux-pci@vger.kernel.org, Shawn Lin <shawn.lin@rock-chips.com>, Wenrui Li <wenrui.li@rock-chips.com>, linux-kernel@vger.kernel.org, Brian Norris <briannorris@chromium.org>, linux-rockchip@lists.infradead.org, Brian Norris <computersforpeace@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" <linux-rockchip-bounces@lists.infradead.org> Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/drivers/pci/host/pcie-rockchip.c b/drivers/pci/host/pcie-rockchip.c index d785f64ec03b..5d7b27b1e941 100644 --- a/drivers/pci/host/pcie-rockchip.c +++ b/drivers/pci/host/pcie-rockchip.c @@ -1398,7 +1398,7 @@ static int rockchip_pcie_probe(struct platform_device *pdev) pcie_bus_configure_settings(child); pci_bus_add_devices(bus); - return err; + return 0; err_free_res: pci_free_resource_list(&res);
There's no way to get here with 'err != 0'. Just return 0 to be more obvious and prevent future changes from accidentally erroring out here without going through the right error paths. Signed-off-by: Brian Norris <briannorris@chromium.org> --- drivers/pci/host/pcie-rockchip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)