diff mbox

drm: Forward declare struct platform_device

Message ID 20170309224651.16621-1-chris@chris-wilson.co.uk (mailing list archive)
State New, archived
Headers show

Commit Message

Chris Wilson March 9, 2017, 10:46 p.m. UTC
./include/drm/drm_pci.h:76:64: warning: ‘struct platform_device’ declared inside parameter list will not be visible outside of this definition or declaration
 extern int drm_platform_init(struct drm_driver *driver, struct platform_device *platform_device);

Fixes: 23ef59ef6dcc ("drm: Extract drm_pci.h")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Gustavo Padovan <gustavo.padovan@collabora.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>
---
 include/drm/drm_pci.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Emil Velikov March 10, 2017, 12:41 a.m. UTC | #1
On 9 March 2017 at 22:46, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> ./include/drm/drm_pci.h:76:64: warning: ‘struct platform_device’ declared inside parameter list will not be visible outside of this definition or declaration
>  extern int drm_platform_init(struct drm_driver *driver, struct platform_device *platform_device);
>
> Fixes: 23ef59ef6dcc ("drm: Extract drm_pci.h")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Gustavo Padovan <gustavo.padovan@collabora.com>
> Cc: Daniel Vetter <daniel.vetter@intel.com>
> ---
>  include/drm/drm_pci.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_pci.h b/include/drm/drm_pci.h
> index 5081b3eba309..9cd2173fc892 100644
> --- a/include/drm/drm_pci.h
> +++ b/include/drm/drm_pci.h
> @@ -73,6 +73,8 @@ extern int drm_pcie_get_speed_cap_mask(struct drm_device *dev, u32 *speed_mask);
>  extern int drm_pcie_get_max_link_width(struct drm_device *dev, u32 *mlw);
>
>  /* platform section */
> -extern int drm_platform_init(struct drm_driver *driver, struct platform_device *platform_device);
> +struct platform_device;
> +extern int drm_platform_init(struct drm_driver *driver,
> +                            struct platform_device *platform_device);
>
I wouldn't bother with the re-wrap, but regardless
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>

-Emil
Chris Wilson March 10, 2017, 12:54 a.m. UTC | #2
On Fri, Mar 10, 2017 at 12:41:30AM +0000, Emil Velikov wrote:
> On 9 March 2017 at 22:46, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > ./include/drm/drm_pci.h:76:64: warning: ‘struct platform_device’ declared inside parameter list will not be visible outside of this definition or declaration
> >  extern int drm_platform_init(struct drm_driver *driver, struct platform_device *platform_device);
> >
> > Fixes: 23ef59ef6dcc ("drm: Extract drm_pci.h")
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Gustavo Padovan <gustavo.padovan@collabora.com>
> > Cc: Daniel Vetter <daniel.vetter@intel.com>
> > ---
> >  include/drm/drm_pci.h | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/include/drm/drm_pci.h b/include/drm/drm_pci.h
> > index 5081b3eba309..9cd2173fc892 100644
> > --- a/include/drm/drm_pci.h
> > +++ b/include/drm/drm_pci.h
> > @@ -73,6 +73,8 @@ extern int drm_pcie_get_speed_cap_mask(struct drm_device *dev, u32 *speed_mask);
> >  extern int drm_pcie_get_max_link_width(struct drm_device *dev, u32 *mlw);
> >
> >  /* platform section */
> > -extern int drm_platform_init(struct drm_driver *driver, struct platform_device *platform_device);
> > +struct platform_device;
> > +extern int drm_platform_init(struct drm_driver *driver,
> > +                            struct platform_device *platform_device);
> >
> I wouldn't bother with the re-wrap, but regardless
> Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>

Step by step we become checkpatch clean.
-Chris
diff mbox

Patch

diff --git a/include/drm/drm_pci.h b/include/drm/drm_pci.h
index 5081b3eba309..9cd2173fc892 100644
--- a/include/drm/drm_pci.h
+++ b/include/drm/drm_pci.h
@@ -73,6 +73,8 @@  extern int drm_pcie_get_speed_cap_mask(struct drm_device *dev, u32 *speed_mask);
 extern int drm_pcie_get_max_link_width(struct drm_device *dev, u32 *mlw);
 
 /* platform section */
-extern int drm_platform_init(struct drm_driver *driver, struct platform_device *platform_device);
+struct platform_device;
+extern int drm_platform_init(struct drm_driver *driver,
+			     struct platform_device *platform_device);
 
 #endif /* _DRM_PCI_H_ */