From patchwork Fri Mar 10 04:32:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sean Paul X-Patchwork-Id: 9614641 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2286A60414 for ; Fri, 10 Mar 2017 04:36:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 156E028174 for ; Fri, 10 Mar 2017 04:36:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 09E90286EF; Fri, 10 Mar 2017 04:36:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id ADAF028174 for ; Fri, 10 Mar 2017 04:36:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iROPmlIznacS7L7od04AwPeRL07+C/kyc9++HPQg+QQ=; b=QsQz5whZwBmycD IKVaBpJUt4wKFIs1hrry3jNyBJKXcBi43pzUKidaMPFoiw3KVdzKIe/M1bRr24G7T3SAs8t1/CsP+ cSgfUMGO46jdqFSUwcQiED2FUryCzyMK4rSo+7RP4g04aUBsIu3R1aVLEA4L0fdW7zthsu1TT6Y+A 3ioTGt83IErMJ6mNH+rDsLL7KApUgqY6ajNmEBiP8pT382lg8pZN2uy5SzwO3XFcOJUwwpe47AikS HQCe3iQbXRDDodehSq9mtr/1Twq/hOqVTh1tJcXiYy8tkM6y5tbIxTI4YhSaJERA2hZ0jVyC9AtUf DxUatMJ3cRlUyX1Rx3AA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cmCIM-0001Ji-Ox; Fri, 10 Mar 2017 04:36:50 +0000 Received: from mail-qk0-x231.google.com ([2607:f8b0:400d:c09::231]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cmCGe-0006tJ-Se for linux-rockchip@lists.infradead.org; Fri, 10 Mar 2017 04:35:09 +0000 Received: by mail-qk0-x231.google.com with SMTP id 1so151502023qkl.3 for ; Thu, 09 Mar 2017 20:34:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=o13rbKYFIfASFo0oiINHYUND4hnOe+D26Thy4j1eZ60=; b=XVLlVeJ6yjNyrjH9aPGq0Cmpb0wtFlciN9GKqCu4grG4oyqn5MXHl3TcLrwZYuFemV iXWsqASr2NOlh704/nQG5d5zx0ed42f2XU2PtmMk2AaoqYYhIU2+6b2VuHf51kzU8bQt 0Fc+C24TCsJzyzUiq+g3YCiAOzO1v+H2CGJCY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=o13rbKYFIfASFo0oiINHYUND4hnOe+D26Thy4j1eZ60=; b=sTzLrfKaoMazBFFySyukC18dXXzTeis3oIQ7yW3zFiUHzKA/6PiJEmDYUoCtpI8PuN GZqmetaGK8TTaq9FWV7PeK0cj84uGn8r1sPg5YMnkwrMupOyQVlwqg4Tf95ufZAzDlft JGKQtvzYRrFn9xPCLtATFaWI78NpyaHWU9L0UMgswO7zWHYXe1syVxX7HR0pqkBsZdcZ diFiq1Xqyq15HffB5P65qoAplTlnRpc177rAWFpuhVeF9aLAl99qIQfb3Vd8mzeQuHKV CsA76vAq/YOdIEeCU7sNxq9fkNMA2Ltwq2njiUvRkR9nwQirU5UweIw96WEmuYS+2Dbl kqng== X-Gm-Message-State: AMke39n8xZtL+HFjtchNwEeQYrnTBeynXymmCEVRTzEG5AFLLTDhWeSVoIasBIdqdkD9Mk8F X-Received: by 10.55.17.206 with SMTP id 75mr18443708qkr.156.1489120483231; Thu, 09 Mar 2017 20:34:43 -0800 (PST) Received: from boxwood.roam.corp.google.com (cpe-75-189-128-87.nc.res.rr.com. [75.189.128.87]) by smtp.gmail.com with ESMTPSA id n19sm5697731qtn.35.2017.03.09.20.34.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 09 Mar 2017 20:34:42 -0800 (PST) From: Sean Paul To: linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org Subject: [PATCH 06/41] drm/bridge: analogix_dp: Don't power bridge in analogix_dp_bind Date: Thu, 9 Mar 2017 23:32:21 -0500 Message-Id: <20170310043305.17216-7-seanpaul@chromium.org> X-Mailer: git-send-email 2.12.0.246.ga2ecc84866-goog In-Reply-To: <20170310043305.17216-1-seanpaul@chromium.org> References: <20170310043305.17216-1-seanpaul@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170309_203505_750275_A3303A88 X-CRM114-Status: UNSURE ( 8.55 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Archit Taneja , zain wang , Lin Huang , Tomeu Vizoso , David Airlie , Douglas Anderson , Sean Paul , Yakir Yang , =?UTF-8?q?St=C3=A9phane=20Marchesin?= , Caesar Wang Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: zain wang The bridge does not need to be powered in analogix_dp_bind(), so remove the calls to pm_runtime_get()/phy_power_on()/analogix_dp_init_dp() as well as their power-off counterparts. Cc: Stéphane Marchesin Signed-off-by: zain wang Signed-off-by: Caesar Wang [the patch originally just removed the power_on portion, seanpaul removed the power off code as well as improved the commit message] Signed-off-by: Sean Paul Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index c26997afd3cf..f64592f52262 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -1385,11 +1385,6 @@ int analogix_dp_bind(struct device *dev, struct drm_device *drm_dev, pm_runtime_enable(dev); - pm_runtime_get_sync(dev); - phy_power_on(dp->phy); - - analogix_dp_init_dp(dp); - ret = devm_request_threaded_irq(&pdev->dev, dp->irq, analogix_dp_hardirq, analogix_dp_irq_thread, @@ -1418,15 +1413,10 @@ int analogix_dp_bind(struct device *dev, struct drm_device *drm_dev, goto err_disable_pm_runtime; } - phy_power_off(dp->phy); - pm_runtime_put(dev); - return 0; err_disable_pm_runtime: - phy_power_off(dp->phy); - pm_runtime_put(dev); pm_runtime_disable(dev); return ret;