diff mbox

ASoC: cs35l35: trivial fix to indentation

Message ID 20170311191922.6209-1-colin.king@canonical.com (mailing list archive)
State New, archived
Headers show

Commit Message

Colin King March 11, 2017, 7:19 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

Remove extraneous tab to correct the nesting level indentation

Detected by CoverityScan, CID#1416584 ("Nesting level does
not match indentation")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 sound/soc/codecs/cs35l35.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Walter Harms March 12, 2017, 2:55 p.m. UTC | #1 
Am 11.03.2017 20:19, schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Remove extraneous tab to correct the nesting level indentation
> 
> Detected by CoverityScan, CID#1416584 ("Nesting level does
> not match indentation")
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  sound/soc/codecs/cs35l35.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/cs35l35.c b/sound/soc/codecs/cs35l35.c
> index 260ed42..43d33f4 100644
> --- a/sound/soc/codecs/cs35l35.c
> +++ b/sound/soc/codecs/cs35l35.c
> @@ -1370,7 +1370,8 @@ static int cs35l35_i2c_probe(struct i2c_client *i2c_client,
>  
>  	for (i = 0; i < ARRAY_SIZE(cs35l35_supplies); i++)
>  		cs35l35->supplies[i].supply = cs35l35_supplies[i];
> -		cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);
> +
> +	cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);
>  


I have the feeling is better before the loop:

cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);

for (i = 0; i < cs35l35->num_supplies; i++)
     cs35l35->supplies[i].supply = cs35l35_supplies[i];

re,
 wh

>  	ret = devm_regulator_bulk_get(&i2c_client->dev,
>  			cs35l35->num_supplies,
diff mbox

Patch

diff --git a/sound/soc/codecs/cs35l35.c b/sound/soc/codecs/cs35l35.c
index 260ed42..43d33f4 100644
--- a/sound/soc/codecs/cs35l35.c
+++ b/sound/soc/codecs/cs35l35.c
@@ -1370,7 +1370,8 @@  static int cs35l35_i2c_probe(struct i2c_client *i2c_client,
 
 	for (i = 0; i < ARRAY_SIZE(cs35l35_supplies); i++)
 		cs35l35->supplies[i].supply = cs35l35_supplies[i];
-		cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);
+
+	cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);
 
 	ret = devm_regulator_bulk_get(&i2c_client->dev,
 			cs35l35->num_supplies,