From patchwork Sat Mar 11 20:52:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuck Lever X-Patchwork-Id: 9619083 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C8D15604A9 for ; Sat, 11 Mar 2017 20:52:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B079928646 for ; Sat, 11 Mar 2017 20:52:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A1D9628660; Sat, 11 Mar 2017 20:52:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 230D028646 for ; Sat, 11 Mar 2017 20:52:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753782AbdCKUwv (ORCPT ); Sat, 11 Mar 2017 15:52:51 -0500 Received: from mail-io0-f194.google.com ([209.85.223.194]:36673 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751325AbdCKUwu (ORCPT ); Sat, 11 Mar 2017 15:52:50 -0500 Received: by mail-io0-f194.google.com with SMTP id 68so10078115ioh.3 for ; Sat, 11 Mar 2017 12:52:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:from:to:cc:date:message-id:user-agent:mime-version :content-transfer-encoding; bh=OX/9ocl2+VPy/IPCkxzYz94ov94xf9OfKad5/nynMAU=; b=CajeDU6eQVhVMD+63PHKzUnW8C6cZktbbBsLFTiSNsDpOHX/pIEtlrjnYpTGXbuyis ZG5+2JQeWylGnTdg92KvLOUjwzNHPkSaERgDFYxJnuXa84TaVhDNVrVh/vlE079NIIjI MzpH2YFZA3+bsMQszAMvZUcvHJXuoziVDmkleDGB1wIJH7gmy2nN151l6u/S67qrartQ DW/6ZezulMgcULKG3SrsZXo55LGpdHNI55J/rw8lKnD83KxQDr488hF+blegQkOY3gfT kYjW6IYtO7VV+km7I6sCiNXNN+yiPiHiFwW+vcIfZjllT7yOsU1DavlTm4ECT4+48aq1 Z/gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:from:to:cc:date:message-id :user-agent:mime-version:content-transfer-encoding; bh=OX/9ocl2+VPy/IPCkxzYz94ov94xf9OfKad5/nynMAU=; b=WLX8ocVOQ+CXhy9OzRfAQTXYnHxlwbWXdvFr3XC5yC6w5ar/3V37/UC2r+s1HXSRkb DMqAf+I+QfzhX8DUvrbmzwIL4Uzl88dK4hTqHggpLM/mOtyUV21QQ7w5NQnMWC1b9gB6 l+4RoRk9i4t7moZjjGug3vckXTrmrpwRIF0PmgUA9X61voHdmDY9xfr1SRUcoOsYW8QH 9g1b5zZ+Fb9SNhPYAbqGD3M8TJAZNgzxs77BsMktBpHXcgXcGgkJV/4/2pvIYVmQqEAC 1L9luP9bU2L7EgeQZWhbkF6gr3l+f5Te6sUY7/xpVe3YyDBtWUrPXj2DkikLVY8V71AV zM3A== X-Gm-Message-State: AMke39mS0S+H9nJNdQMcsQ/MOc6+0ODL7lU/c4e/G2OAFDJnVoWNUl3/3F08IDGrJi/rrA== X-Received: by 10.107.55.68 with SMTP id e65mr22001565ioa.145.1489265568673; Sat, 11 Mar 2017 12:52:48 -0800 (PST) Received: from manet.1015granger.net ([2604:8800:100:81fc:ec4:7aff:fe6c:1dce]) by smtp.gmail.com with ESMTPSA id k16sm1548585itk.2.2017.03.11.12.52.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 11 Mar 2017 12:52:48 -0800 (PST) Subject: [PATCH] xprtrdma: Squelch kbuild sparse complaint From: Chuck Lever To: anna.schumaker@netapp.com Cc: linux-nfs@vger.kernel.org Date: Sat, 11 Mar 2017 15:52:47 -0500 Message-ID: <20170311205246.15791.28097.stgit@manet.1015granger.net> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP New complaint from kbuild for 4.9.y: net/sunrpc/xprtrdma/verbs.c:489:19: sparse: incompatible types in comparison expression (different type sizes) verbs.c: 489 max_sge = min(ia->ri_device->attrs.max_sge, RPCRDMA_MAX_SEND_SGES); I can't reproduce this running sparse here. Likewise, "make W=1 net/sunrpc/xprtrdma/verbs.o" never indicated any issue. A little poking suggests that because the range of its values is small, gcc can make the actual width of RPCRDMA_MAX_SEND_SGES smaller than the width of an unsigned integer. Fixes: 16f906d66cd7 ("xprtrdma: Reduce required number of send SGEs") Signed-off-by: Chuck Lever Cc: stable@kernel.org --- net/sunrpc/xprtrdma/verbs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c index 81cd31a..3b332b3 100644 --- a/net/sunrpc/xprtrdma/verbs.c +++ b/net/sunrpc/xprtrdma/verbs.c @@ -503,7 +503,8 @@ static void rpcrdma_destroy_id(struct rdma_cm_id *id) struct ib_cq *sendcq, *recvcq; int rc; - max_sge = min(ia->ri_device->attrs.max_sge, RPCRDMA_MAX_SEND_SGES); + max_sge = min_t(unsigned int, ia->ri_device->attrs.max_sge, + RPCRDMA_MAX_SEND_SGES); if (max_sge < RPCRDMA_MIN_SEND_SGES) { pr_warn("rpcrdma: HCA provides only %d send SGEs\n", max_sge); return -ENOMEM;