| Message ID | 1489457869-21815-1-git-send-email-andy.tang@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Mar 14, 2017 at 10:17:49AM +0800, Yuantian Tang wrote: > There is a thermal monitoring unit on ls1012a soc which can > monitor and record the temperature of cores so that appropriate actions > can be taken or alarm the user when the temperature exceeds a programmed > temperature threshold. > > Signed-off-by: Tang Yuantian <andy.tang@nxp.com> 'arm64: dts: ls1012a: ...' for subject prefix to make it more specific. > --- > v2: > -- rebased to latest kernel. > > arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 76 ++++++++++++++++++++++++++ > 1 file changed, 76 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi > index cffebb4..d9d9b0f 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi > @@ -43,6 +43,7 @@ > */ > > #include <dt-bindings/interrupt-controller/irq.h> > +#include <dt-bindings/thermal/thermal.h> > > / { > compatible = "fsl,ls1012a"; > @@ -126,6 +127,81 @@ > #clock-cells = <2>; > clocks = <&sysclk>; > }; Have a newline between nodes. > + tmu: tmu@1f00000 { > + compatible = "fsl,qoriq-tmu"; > + reg = <0x0 0x1f00000 0x0 0x10000>; > + interrupts = <0 33 0x4>; > + fsl,tmu-range = <0xb0000 0x9002a 0x6004c 0x30062>; > + fsl,tmu-calibration = <0x00000000 0x00000026 > + 0x00000001 0x0000002d > + 0x00000002 0x00000032 > + 0x00000003 0x00000039 > + 0x00000004 0x0000003f > + 0x00000005 0x00000046 > + 0x00000006 0x0000004d > + 0x00000007 0x00000054 > + 0x00000008 0x0000005a > + 0x00000009 0x00000061 > + 0x0000000a 0x0000006a > + 0x0000000b 0x00000071 > + > + 0x00010000 0x00000025 > + 0x00010001 0x0000002c > + 0x00010002 0x00000035 > + 0x00010003 0x0000003d > + 0x00010004 0x00000045 > + 0x00010005 0x0000004e > + 0x00010006 0x00000057 > + 0x00010007 0x00000061 > + 0x00010008 0x0000006b > + 0x00010009 0x00000076 > + > + 0x00020000 0x00000029 > + 0x00020001 0x00000033 > + 0x00020002 0x0000003d > + 0x00020003 0x00000049 > + 0x00020004 0x00000056 > + 0x00020005 0x00000061 > + 0x00020006 0x0000006d > + > + 0x00030000 0x00000021 > + 0x00030001 0x0000002a > + 0x00030002 0x0000003c > + 0x00030003 0x0000004e>; > + big-endian; > + #thermal-sensor-cells = <1>; > + }; > + > + thermal-zones { > + cpu_thermal: cpu-thermal { > + polling-delay-passive = <1000>; > + polling-delay = <5000>; > + We usually do not have any newline in middle of property list, so please drop it. > + thermal-sensors = <&tmu 0>; > + > + trips { > + cpu_alert: cpu-alert { > + temperature = <85000>; > + hysteresis = <2000>; > + type = "passive"; > + }; Have a newline between node. Shawn > + cpu_crit: cpu-crit { > + temperature = <95000>; > + hysteresis = <2000>; > + type = "critical"; > + }; > + }; > + > + cooling-maps { > + map0 { > + trip = <&cpu_alert>; > + cooling-device = > + <&cpu0 THERMAL_NO_LIMIT > + THERMAL_NO_LIMIT>; > + }; > + }; > + }; > + }; > > i2c0: i2c@2180000 { > compatible = "fsl,vf610-i2c"; > -- > 2.1.0.27.g96db324 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hi, Will fix them in next version. Thanks, Yuantian > -----Original Message----- > From: Shawn Guo [mailto:shawnguo@kernel.org] > Sent: Tuesday, March 14, 2017 4:08 PM > To: Andy Tang > Cc: mark.rutland@arm.com; devicetree@vger.kernel.org; > catalin.marinas@arm.com; will.deacon@arm.com; robh+dt@kernel.org; > linux-arm-kernel@lists.infradead.org > Subject: Re: [PATCH v2] arm64: dts: added thermal monitor node > > On Tue, Mar 14, 2017 at 10:17:49AM +0800, Yuantian Tang wrote: > > There is a thermal monitoring unit on ls1012a soc which can monitor > > and record the temperature of cores so that appropriate actions can be > > taken or alarm the user when the temperature exceeds a programmed > > temperature threshold. > > > > Signed-off-by: Tang Yuantian <andy.tang@nxp.com> > > 'arm64: dts: ls1012a: ...' for subject prefix to make it more specific. > > > --- > > v2: > > -- rebased to latest kernel. > > > > arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 76 > > ++++++++++++++++++++++++++ > > 1 file changed, 76 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi > > b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi > > index cffebb4..d9d9b0f 100644 > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi > > @@ -43,6 +43,7 @@ > > */ > > > > #include <dt-bindings/interrupt-controller/irq.h> > > +#include <dt-bindings/thermal/thermal.h> > > > > / { > > compatible = "fsl,ls1012a"; > > @@ -126,6 +127,81 @@ > > #clock-cells = <2>; > > clocks = <&sysclk>; > > }; > > Have a newline between nodes. > > > + tmu: tmu@1f00000 { > > + compatible = "fsl,qoriq-tmu"; > > + reg = <0x0 0x1f00000 0x0 0x10000>; > > + interrupts = <0 33 0x4>; > > + fsl,tmu-range = <0xb0000 0x9002a 0x6004c 0x30062>; > > + fsl,tmu-calibration = <0x00000000 0x00000026 > > + 0x00000001 0x0000002d > > + 0x00000002 0x00000032 > > + 0x00000003 0x00000039 > > + 0x00000004 0x0000003f > > + 0x00000005 0x00000046 > > + 0x00000006 0x0000004d > > + 0x00000007 0x00000054 > > + 0x00000008 0x0000005a > > + 0x00000009 0x00000061 > > + 0x0000000a 0x0000006a > > + 0x0000000b 0x00000071 > > + > > + 0x00010000 0x00000025 > > + 0x00010001 0x0000002c > > + 0x00010002 0x00000035 > > + 0x00010003 0x0000003d > > + 0x00010004 0x00000045 > > + 0x00010005 0x0000004e > > + 0x00010006 0x00000057 > > + 0x00010007 0x00000061 > > + 0x00010008 0x0000006b > > + 0x00010009 0x00000076 > > + > > + 0x00020000 0x00000029 > > + 0x00020001 0x00000033 > > + 0x00020002 0x0000003d > > + 0x00020003 0x00000049 > > + 0x00020004 0x00000056 > > + 0x00020005 0x00000061 > > + 0x00020006 0x0000006d > > + > > + 0x00030000 0x00000021 > > + 0x00030001 0x0000002a > > + 0x00030002 0x0000003c > > + 0x00030003 0x0000004e>; > > + big-endian; > > + #thermal-sensor-cells = <1>; > > + }; > > + > > + thermal-zones { > > + cpu_thermal: cpu-thermal { > > + polling-delay-passive = <1000>; > > + polling-delay = <5000>; > > + > > We usually do not have any newline in middle of property list, so please drop > it. > > > + thermal-sensors = <&tmu 0>; > > + > > + trips { > > + cpu_alert: cpu-alert { > > + temperature = <85000>; > > + hysteresis = <2000>; > > + type = "passive"; > > + }; > > Have a newline between node. > > Shawn > > > + cpu_crit: cpu-crit { > > + temperature = <95000>; > > + hysteresis = <2000>; > > + type = "critical"; > > + }; > > + }; > > + > > + cooling-maps { > > + map0 { > > + trip = <&cpu_alert>; > > + cooling-device = > > + <&cpu0 > THERMAL_NO_LIMIT > > + > THERMAL_NO_LIMIT>; > > + }; > > + }; > > + }; > > + }; > > > > i2c0: i2c@2180000 { > > compatible = "fsl,vf610-i2c"; > > -- > > 2.1.0.27.g96db324 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi index cffebb4..d9d9b0f 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi @@ -43,6 +43,7 @@ */ #include <dt-bindings/interrupt-controller/irq.h> +#include <dt-bindings/thermal/thermal.h> / { compatible = "fsl,ls1012a"; @@ -126,6 +127,81 @@ #clock-cells = <2>; clocks = <&sysclk>; }; + tmu: tmu@1f00000 { + compatible = "fsl,qoriq-tmu"; + reg = <0x0 0x1f00000 0x0 0x10000>; + interrupts = <0 33 0x4>; + fsl,tmu-range = <0xb0000 0x9002a 0x6004c 0x30062>; + fsl,tmu-calibration = <0x00000000 0x00000026 + 0x00000001 0x0000002d + 0x00000002 0x00000032 + 0x00000003 0x00000039 + 0x00000004 0x0000003f + 0x00000005 0x00000046 + 0x00000006 0x0000004d + 0x00000007 0x00000054 + 0x00000008 0x0000005a + 0x00000009 0x00000061 + 0x0000000a 0x0000006a + 0x0000000b 0x00000071 + + 0x00010000 0x00000025 + 0x00010001 0x0000002c + 0x00010002 0x00000035 + 0x00010003 0x0000003d + 0x00010004 0x00000045 + 0x00010005 0x0000004e + 0x00010006 0x00000057 + 0x00010007 0x00000061 + 0x00010008 0x0000006b + 0x00010009 0x00000076 + + 0x00020000 0x00000029 + 0x00020001 0x00000033 + 0x00020002 0x0000003d + 0x00020003 0x00000049 + 0x00020004 0x00000056 + 0x00020005 0x00000061 + 0x00020006 0x0000006d + + 0x00030000 0x00000021 + 0x00030001 0x0000002a + 0x00030002 0x0000003c + 0x00030003 0x0000004e>; + big-endian; + #thermal-sensor-cells = <1>; + }; + + thermal-zones { + cpu_thermal: cpu-thermal { + polling-delay-passive = <1000>; + polling-delay = <5000>; + + thermal-sensors = <&tmu 0>; + + trips { + cpu_alert: cpu-alert { + temperature = <85000>; + hysteresis = <2000>; + type = "passive"; + }; + cpu_crit: cpu-crit { + temperature = <95000>; + hysteresis = <2000>; + type = "critical"; + }; + }; + + cooling-maps { + map0 { + trip = <&cpu_alert>; + cooling-device = + <&cpu0 THERMAL_NO_LIMIT + THERMAL_NO_LIMIT>; + }; + }; + }; + }; i2c0: i2c@2180000 { compatible = "fsl,vf610-i2c";
There is a thermal monitoring unit on ls1012a soc which can monitor and record the temperature of cores so that appropriate actions can be taken or alarm the user when the temperature exceeds a programmed temperature threshold. Signed-off-by: Tang Yuantian <andy.tang@nxp.com> --- v2: -- rebased to latest kernel. arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 76 ++++++++++++++++++++++++++ 1 file changed, 76 insertions(+)