diff mbox

[RFC,2/2] ASoC: wm8994: delay aifxclk activation

Message ID 1489682483-13051-3-git-send-email-olivier.moysan@st.com (mailing list archive)
State New, archived
Headers show

Commit Message

Olivier MOYSAN March 16, 2017, 4:41 p.m. UTC 
Signed-off-by: olivier moysan <olivier.moysan@st.com>
---
 sound/soc/codecs/wm8994.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Mark Brown March 16, 2017, 5:51 p.m. UTC | #1 
On Thu, Mar 16, 2017 at 05:41:23PM +0100, olivier moysan wrote:
> Signed-off-by: olivier moysan <olivier.moysan@st.com>
> ---
>  sound/soc/codecs/wm8994.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

...with no changelog.  That's especially important here, we really don't
want to be messing with the clock activation ordering on this device
without a good and clear understanding of what's going on.
Olivier MOYSAN March 17, 2017, 3:37 p.m. UTC | #2 
Hello Mark,

On 03/16/2017 06:51 PM, Mark Brown wrote:
> On Thu, Mar 16, 2017 at 05:41:23PM +0100, olivier moysan wrote:
>> Signed-off-by: olivier moysan <olivier.moysan@st.com>
>> ---
>>  sound/soc/codecs/wm8994.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> ...with no changelog.  That's especially important here, we really don't
> want to be messing with the clock activation ordering on this device
> without a good and clear understanding of what's going on.
>

Sorry. I put it in cover letter only.
I send a v2 with more explanations.

regards
olivier
diff mbox

Patch

diff --git a/sound/soc/codecs/wm8994.c b/sound/soc/codecs/wm8994.c
index ccf640a..6782d9e 100644
--- a/sound/soc/codecs/wm8994.c
+++ b/sound/soc/codecs/wm8994.c
@@ -1262,7 +1262,7 @@  static int late_enable_ev(struct snd_soc_dapm_widget *w,
 	struct wm8994_priv *wm8994 = snd_soc_codec_get_drvdata(codec);
 
 	switch (event) {
-	case SND_SOC_DAPM_PRE_PMU:
+	case SND_SOC_DAPM_POST_PMU:
 		if (wm8994->aif1clk_enable) {
 			aif1clk_ev(w, kcontrol, SND_SOC_DAPM_PRE_PMU);
 			snd_soc_update_bits(codec, WM8994_AIF1_CLOCKING_1,
@@ -1615,6 +1615,8 @@  static SOC_ENUM_SINGLE_DECL(aif2dacr_src_enum,
 SND_SOC_DAPM_MUX_E("Right Headphone Mux", SND_SOC_NOPM, 0, 0, &wm_hubs_hpr_mux,
 		   late_enable_ev, SND_SOC_DAPM_PRE_PMU),
 
+SND_SOC_DAPM_POST("Late Enable PGA", late_enable_ev),
+
 SND_SOC_DAPM_POST("Late Disable PGA", late_disable_ev)
 };