[(TRIVIAL)] xfs: fix up inode validation failure message
diff mbox

Message ID 59d16175-1c24-4bc2-5cd9-ac7a062e5ae3@redhat.com
State Accepted
Headers show

Commit Message

Eric Sandeen March 17, 2017, 3:47 p.m. UTC
"xfs_iread: validation failed for inode 96 failed"

One "failed" seems like enough.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

Yo dawg, I heard you like failed so I put failed in your
failed so you can fail while you fail.


--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Alex Elder March 17, 2017, 4:35 p.m. UTC | #1
On 03/17/2017 10:47 AM, Eric Sandeen wrote:
> "xfs_iread: validation failed for inode 96 failed"
> 
> One "failed" seems like enough.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Reviewed-by: Alex Elder <elder@linaro.org>

> ---
> 
> Yo dawg, I heard you like failed so I put failed in your
> failed so you can fail while you fail.
> 
> diff --git a/fs/xfs/libxfs/xfs_inode_buf.c b/fs/xfs/libxfs/xfs_inode_buf.c
> index d93f9d9..09c3d1a 100644
> --- a/fs/xfs/libxfs/xfs_inode_buf.c
> +++ b/fs/xfs/libxfs/xfs_inode_buf.c
> @@ -508,7 +508,7 @@
>  
>  	/* even unallocated inodes are verified */
>  	if (!xfs_dinode_verify(mp, ip->i_ino, dip)) {
> -		xfs_alert(mp, "%s: validation failed for inode %lld failed",
> +		xfs_alert(mp, "%s: validation failed for inode %lld",
>  				__func__, ip->i_ino);
>  
>  		XFS_CORRUPTION_ERROR(__func__, XFS_ERRLEVEL_LOW, mp, dip);
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Bill O'Donnell March 17, 2017, 8:29 p.m. UTC | #2
On Fri, Mar 17, 2017 at 08:47:38AM -0700, Eric Sandeen wrote:
> "xfs_iread: validation failed for inode 96 failed"
> 
> One "failed" seems like enough.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Bill O'Donnell <billodo@redhat.com>
> ---
> 
> Yo dawg, I heard you like failed so I put failed in your
> failed so you can fail while you fail.
> 
> diff --git a/fs/xfs/libxfs/xfs_inode_buf.c b/fs/xfs/libxfs/xfs_inode_buf.c
> index d93f9d9..09c3d1a 100644
> --- a/fs/xfs/libxfs/xfs_inode_buf.c
> +++ b/fs/xfs/libxfs/xfs_inode_buf.c
> @@ -508,7 +508,7 @@
>  
>  	/* even unallocated inodes are verified */
>  	if (!xfs_dinode_verify(mp, ip->i_ino, dip)) {
> -		xfs_alert(mp, "%s: validation failed for inode %lld failed",
> +		xfs_alert(mp, "%s: validation failed for inode %lld",
>  				__func__, ip->i_ino);
>  
>  		XFS_CORRUPTION_ERROR(__func__, XFS_ERRLEVEL_LOW, mp, dip);
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Darrick J. Wong March 27, 2017, 3:21 p.m. UTC | #3
On Fri, Mar 17, 2017 at 08:47:38AM -0700, Eric Sandeen wrote:
> "xfs_iread: validation failed for inode 96 failed"
> 
> One "failed" seems like enough.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
> 
> Yo dawg, I heard you like failed so I put failed in your
> failed so you can fail while you fail.

Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

Will queue for 4.12.

--D

> 
> diff --git a/fs/xfs/libxfs/xfs_inode_buf.c b/fs/xfs/libxfs/xfs_inode_buf.c
> index d93f9d9..09c3d1a 100644
> --- a/fs/xfs/libxfs/xfs_inode_buf.c
> +++ b/fs/xfs/libxfs/xfs_inode_buf.c
> @@ -508,7 +508,7 @@
>  
>  	/* even unallocated inodes are verified */
>  	if (!xfs_dinode_verify(mp, ip->i_ino, dip)) {
> -		xfs_alert(mp, "%s: validation failed for inode %lld failed",
> +		xfs_alert(mp, "%s: validation failed for inode %lld",
>  				__func__, ip->i_ino);
>  
>  		XFS_CORRUPTION_ERROR(__func__, XFS_ERRLEVEL_LOW, mp, dip);
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/fs/xfs/libxfs/xfs_inode_buf.c b/fs/xfs/libxfs/xfs_inode_buf.c
index d93f9d9..09c3d1a 100644
--- a/fs/xfs/libxfs/xfs_inode_buf.c
+++ b/fs/xfs/libxfs/xfs_inode_buf.c
@@ -508,7 +508,7 @@ 
 
 	/* even unallocated inodes are verified */
 	if (!xfs_dinode_verify(mp, ip->i_ino, dip)) {
-		xfs_alert(mp, "%s: validation failed for inode %lld failed",
+		xfs_alert(mp, "%s: validation failed for inode %lld",
 				__func__, ip->i_ino);
 
 		XFS_CORRUPTION_ERROR(__func__, XFS_ERRLEVEL_LOW, mp, dip);