From patchwork Sun May 2 15:58:59 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Contreras X-Patchwork-Id: 96366 X-Patchwork-Delegate: tomi.valkeinen@nokia.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o42Fx8FH004954 for ; Sun, 2 May 2010 15:59:08 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757235Ab0EBP7H (ORCPT ); Sun, 2 May 2010 11:59:07 -0400 Received: from mail-bw0-f219.google.com ([209.85.218.219]:64017 "EHLO mail-bw0-f219.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757139Ab0EBP7B convert rfc822-to-8bit (ORCPT ); Sun, 2 May 2010 11:59:01 -0400 Received: by bwz19 with SMTP id 19so904078bwz.21 for ; Sun, 02 May 2010 08:59:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=qMRBHQ3dXFqaLIkci3iXNHwI3DGVlX5NwQ1s41LasHk=; b=bgH4L5URce0LHWO4WtX73vvuoK6gAXHpYWivgaBvnbT2VRzkYP507MJAt8RbZjRwqb jZtqnY41AUiDjYu/4pch9ZfZSw9LgSh68UU4xIuVNGe0IwTZl5X+bZORvmpZbVymj5Ac IvRYJROEu8fEfWoL8VPu2f0PWmf5TKRo7DpWg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=jL4JrKOhefPCnY58nIZ/LV1T8KzQ9QMRo8fdU/U5rBEj8f//F9RYYtXrPG442SwNbl pdjjLB8gKCtwEAhh44wgDnRB9iF8U69YumVj993o3gKta8kt7O3Z8Pf1Kdo1plLYrYEX CzHH8kfc0YgDisziZp+wmIM8vUecf9GOCyL2s= MIME-Version: 1.0 Received: by 10.204.22.16 with SMTP id l16mr8971956bkb.186.1272815939806; Sun, 02 May 2010 08:58:59 -0700 (PDT) Received: by 10.204.60.78 with HTTP; Sun, 2 May 2010 08:58:59 -0700 (PDT) In-Reply-To: <0BA15D46-D494-4402-9EC8-574AD5D7BAE8@dominion.thruhere.net> References: <1271924622-21043-1-git-send-email-koen@dominion.thruhere.net> <0BA15D46-D494-4402-9EC8-574AD5D7BAE8@dominion.thruhere.net> Date: Sun, 2 May 2010 18:58:59 +0300 Message-ID: Subject: Re: [PATCH v9] board-omap3-beagle: add DSS2 support From: Felipe Contreras To: Koen Kooi Cc: "linux-omap@vger.kernel.org List" , Tomi Valkeinen , Tony Lindgren Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Sun, 02 May 2010 15:59:09 +0000 (UTC) --- a/arch/arm/mach-omap2/board-omap3beagle.c +++ b/arch/arm/mach-omap2/board-omap3beagle.c @@ -39,11 +39,11 @@ #include #include -#include #include #include #include #include +#include #include "mux.h" #include "mmc-twl4030.h" @@ -169,6 +169,10 @@ static void __init beagle_display_init(void) { int r; +#if 0 + /* is this really needed? */ + omap_mux_init_gpio(beagle_dvi_device.reset_gpio, OMAP_PIN_INPUT); +#endif r = gpio_request(beagle_dvi_device.reset_gpio, "DVI reset"); if (r < 0) { printk(KERN_ERR "Unable to get DVI reset GPIO\n"); @@ -279,6 +283,7 @@ static struct regulator_init_data beagle_vdac = { .constraints = { .min_uV = 1800000, .max_uV = 1800000, + .apply_uV = true, .valid_modes_mask = REGULATOR_MODE_NORMAL | REGULATOR_MODE_STANDBY, .valid_ops_mask = REGULATOR_CHANGE_MODE @@ -414,9 +419,9 @@ static void __init omap3_beagle_init_irq(void) } static struct platform_device *omap3_beagle_devices[] __initdata = { + &beagle_dss_device, &leds_gpio, &keys_gpio, - &beagle_dss_device, }; static void __init omap3beagle_flash_init(void) @@ -485,20 +490,14 @@ static void __init omap3_beagle_init(void) ARRAY_SIZE(omap3_beagle_devices)); omap_serial_init(); - omap_mux_init_gpio(170, OMAP_PIN_INPUT); - gpio_request(170, "DVI_nPD"); - /* REVISIT leave DVI powered down until it's needed ... */ - gpio_direction_output(170, true); - usb_musb_init(); usb_ehci_init(&ehci_pdata); omap3beagle_flash_init(); + beagle_display_init(); /* Ensure SDRC pins are mux'd for self-refresh */ omap_mux_init_signal("sdrc_cke0", OMAP_PIN_OUTPUT); omap_mux_init_signal("sdrc_cke1", OMAP_PIN_OUTPUT); - - beagle_display_init(); } static void __init omap3_beagle_map_io(void)