| Message ID | 20170323115746.18474-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 23/03/17 12:57, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The call to v4ls_m2m_get_vq is only used to get the return value > which is not being used, so it appears to be redundant and can > be removed. > > Detected with CoverityScan, CID#1420674 ("Useless call") > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/media/platform/coda/coda-common.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/media/platform/coda/coda-common.c b/drivers/media/platform/coda/coda-common.c > index 800d2477f1a0..95e4648f18e6 100644 > --- a/drivers/media/platform/coda/coda-common.c > +++ b/drivers/media/platform/coda/coda-common.c > @@ -817,8 +817,6 @@ static int coda_qbuf(struct file *file, void *priv, > static bool coda_buf_is_end_of_stream(struct coda_ctx *ctx, > struct vb2_v4l2_buffer *buf) > { > - v4l2_m2m_get_vq(ctx->fh.m2m_ctx, V4L2_BUF_TYPE_VIDEO_OUTPUT); > - > return ((ctx->bit_stream_param & CODA_BIT_STREAM_END_FLAG) && > (buf->sequence == (ctx->qsequence - 1))); > } > Philipp, is this correct, or should this actually check whether the queue is an output queue? Regards, Hans
On Mon, 2017-03-27 at 11:46 +0200, Hans Verkuil wrote: > On 23/03/17 12:57, Colin King wrote: > > From: Colin Ian King <colin.king@canonical.com> > > > > The call to v4ls_m2m_get_vq is only used to get the return value > > which is not being used, so it appears to be redundant and can > > be removed. > > > > Detected with CoverityScan, CID#1420674 ("Useless call") > > > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > > --- > > drivers/media/platform/coda/coda-common.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/media/platform/coda/coda-common.c b/drivers/media/platform/coda/coda-common.c > > index 800d2477f1a0..95e4648f18e6 100644 > > --- a/drivers/media/platform/coda/coda-common.c > > +++ b/drivers/media/platform/coda/coda-common.c > > @@ -817,8 +817,6 @@ static int coda_qbuf(struct file *file, void *priv, > > static bool coda_buf_is_end_of_stream(struct coda_ctx *ctx, > > struct vb2_v4l2_buffer *buf) > > { > > - v4l2_m2m_get_vq(ctx->fh.m2m_ctx, V4L2_BUF_TYPE_VIDEO_OUTPUT); > > - > > return ((ctx->bit_stream_param & CODA_BIT_STREAM_END_FLAG) && > > (buf->sequence == (ctx->qsequence - 1))); > > } > > > > Philipp, is this correct, or should this actually check whether the queue is an > output queue? Yes, this was previously assigned to an unused local variable src_vq, since initial commit 918c66fd4126 ("[media] coda: add CODA7541 decoding support"). coda_buf_is_end_of_stream is called from coda_m2m_buf_done, which is exclusively used on destination buffers on the capture queue. Acked-by: Philipp Zabel <p.zabel@pengutronix.de> regards Philipp
Am 27.03.2017 12:10, schrieb Philipp Zabel: > On Mon, 2017-03-27 at 11:46 +0200, Hans Verkuil wrote: >> On 23/03/17 12:57, Colin King wrote: >>> From: Colin Ian King <colin.king@canonical.com> >>> >>> The call to v4ls_m2m_get_vq is only used to get the return value >>> which is not being used, so it appears to be redundant and can >>> be removed. >>> >>> Detected with CoverityScan, CID#1420674 ("Useless call") >>> >>> Signed-off-by: Colin Ian King <colin.king@canonical.com> >>> --- >>> drivers/media/platform/coda/coda-common.c | 2 -- >>> 1 file changed, 2 deletions(-) >>> >>> diff --git a/drivers/media/platform/coda/coda-common.c b/drivers/media/platform/coda/coda-common.c >>> index 800d2477f1a0..95e4648f18e6 100644 >>> --- a/drivers/media/platform/coda/coda-common.c >>> +++ b/drivers/media/platform/coda/coda-common.c >>> @@ -817,8 +817,6 @@ static int coda_qbuf(struct file *file, void *priv, >>> static bool coda_buf_is_end_of_stream(struct coda_ctx *ctx, >>> struct vb2_v4l2_buffer *buf) >>> { >>> - v4l2_m2m_get_vq(ctx->fh.m2m_ctx, V4L2_BUF_TYPE_VIDEO_OUTPUT); >>> - >>> return ((ctx->bit_stream_param & CODA_BIT_STREAM_END_FLAG) && >>> (buf->sequence == (ctx->qsequence - 1))); >>> } >>> >> >> Philipp, is this correct, or should this actually check whether the queue is an >> output queue? > > Yes, this was previously assigned to an unused local variable src_vq, > since initial commit 918c66fd4126 ("[media] coda: add CODA7541 decoding > support"). > > coda_buf_is_end_of_stream is called from coda_m2m_buf_done, which is > exclusively used on destination buffers on the capture queue. > > Acked-by: Philipp Zabel <p.zabel@pengutronix.de> > > regards > Philipp > Is that function needed at all ? re, wh
diff --git a/drivers/media/platform/coda/coda-common.c b/drivers/media/platform/coda/coda-common.c index 800d2477f1a0..95e4648f18e6 100644 --- a/drivers/media/platform/coda/coda-common.c +++ b/drivers/media/platform/coda/coda-common.c @@ -817,8 +817,6 @@ static int coda_qbuf(struct file *file, void *priv, static bool coda_buf_is_end_of_stream(struct coda_ctx *ctx, struct vb2_v4l2_buffer *buf) { - v4l2_m2m_get_vq(ctx->fh.m2m_ctx, V4L2_BUF_TYPE_VIDEO_OUTPUT); - return ((ctx->bit_stream_param & CODA_BIT_STREAM_END_FLAG) && (buf->sequence == (ctx->qsequence - 1))); }