| Message ID | 20170323143341.31549-2-hch@lst.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, 2017-03-23 at 10:33 -0400, Christoph Hellwig wrote: > Make life easy for implementations that needs to send a data buffer > to the device (e.g. SCSI) by numbering it as a data out command. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > include/linux/blk_types.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h > index d703acb55d0f..6393c13a6498 100644 > --- a/include/linux/blk_types.h > +++ b/include/linux/blk_types.h > @@ -160,7 +160,7 @@ enum req_opf { > /* write the same sector many times */ > REQ_OP_WRITE_SAME = 7, > /* write the zero filled sector many times */ > - REQ_OP_WRITE_ZEROES = 8, > + REQ_OP_WRITE_ZEROES = 9, > > /* SCSI passthrough using struct scsi_request */ > REQ_OP_SCSI_IN = 32, Hello Christoph, Since REQ_OP_WRITE_ZEROES was introduced in kernel v4.10, do we need "Cc: stable" and "Fixes: a6f0788ec2881" tags for this patch? Thanks, Bart.
On Tue, Mar 28, 2017 at 04:12:46PM +0000, Bart Van Assche wrote: > Since REQ_OP_WRITE_ZEROES was introduced in kernel v4.10, do we need > "Cc: stable" and "Fixes: a6f0788ec2881" tags for this patch? No. This just works around the way scsi_setup_cmnd sets up the data direction. Before this series it's not an issue because no one used the req_op data direction for setting up the dma direction.
diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h index d703acb55d0f..6393c13a6498 100644 --- a/include/linux/blk_types.h +++ b/include/linux/blk_types.h @@ -160,7 +160,7 @@ enum req_opf { /* write the same sector many times */ REQ_OP_WRITE_SAME = 7, /* write the zero filled sector many times */ - REQ_OP_WRITE_ZEROES = 8, + REQ_OP_WRITE_ZEROES = 9, /* SCSI passthrough using struct scsi_request */ REQ_OP_SCSI_IN = 32,
Make life easy for implementations that needs to send a data buffer to the device (e.g. SCSI) by numbering it as a data out command. Signed-off-by: Christoph Hellwig <hch@lst.de> --- include/linux/blk_types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)