| Message ID | 20170329183658.618942497@cogentembedded.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
Hello Sergei, > From: linux-renesas-soc-owner@vger.kernel.org [mailto:linux-renesas-soc- > owner@vger.kernel.org] On Behalf Of Sergei Shtylyov > Sent: 29 March 2017 19:37 > > The R8A7791 PFC driver was apparently based on the preliminary revisions of > the user's manual, which omitted the DVC_MUTE signal altogether in the > PFC section. The modern manual has the signal described, so just add the > necassary data to the driver... > > Fixes: 508845196238 ("pinctrl: sh-pfc: r8a7791 PFC support") > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Should this patch also CC stable? (Patch 1/2 does) Kind regards, Chris > > --- > drivers/pinctrl/sh-pfc/pfc-r8a7791.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > Index: linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7791.c > ========================================================== > ========= > --- linux-pinctrl.orig/drivers/pinctrl/sh-pfc/pfc-r8a7791.c > +++ linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7791.c > @@ -203,7 +203,7 @@ enum { > > /* IPSR6 */ > FN_AUDIO_CLKB, FN_STP_OPWM_0_B, FN_MSIOF1_SCK_B, > - FN_SCIF_CLK, FN_BPFCLK_E, > + FN_SCIF_CLK, FN_DVC_MUTE, FN_BPFCLK_E, > FN_AUDIO_CLKC, FN_SCIFB0_SCK_C, FN_MSIOF1_SYNC_B, FN_RX2, > FN_SCIFA2_RXD, FN_FMIN_E, > FN_AUDIO_CLKOUT, FN_MSIOF1_SS1_B, FN_TX2, FN_SCIFA2_TXD, > @@ -573,7 +573,7 @@ enum { > > /* IPSR6 */ > AUDIO_CLKB_MARK, STP_OPWM_0_B_MARK, > MSIOF1_SCK_B_MARK, > - SCIF_CLK_MARK, BPFCLK_E_MARK, > + SCIF_CLK_MARK, DVC_MUTE_MARK, BPFCLK_E_MARK, > AUDIO_CLKC_MARK, SCIFB0_SCK_C_MARK, > MSIOF1_SYNC_B_MARK, RX2_MARK, > SCIFA2_RXD_MARK, FMIN_E_MARK, > AUDIO_CLKOUT_MARK, MSIOF1_SS1_B_MARK, TX2_MARK, > SCIFA2_TXD_MARK, @@ -1093,6 +1093,7 @@ static const u16 pinmux_data[] > = { > PINMUX_IPSR_MSEL(IP6_2_0, STP_OPWM_0_B, SEL_SSP_1), > PINMUX_IPSR_MSEL(IP6_2_0, MSIOF1_SCK_B, SEL_SOF1_1), > PINMUX_IPSR_MSEL(IP6_2_0, SCIF_CLK, SEL_SCIF_0), > + PINMUX_IPSR_GPSR (IP6_2_0, DVC_MUTE), > PINMUX_IPSR_MSEL(IP6_2_0, BPFCLK_E, SEL_FM_4), > PINMUX_IPSR_GPSR(IP6_5_3, AUDIO_CLKC), > PINMUX_IPSR_MSEL(IP6_5_3, SCIFB0_SCK_C, SEL_SCIFB_2), @@ - > 5899,7 +5900,7 @@ static const struct pinmux_cfg_reg pinmu > 0, 0, > /* IP6_2_0 [3] */ > FN_AUDIO_CLKB, FN_STP_OPWM_0_B, FN_MSIOF1_SCK_B, > - FN_SCIF_CLK, 0, FN_BPFCLK_E, > + FN_SCIF_CLK, FN_DVC_MUTE, FN_BPFCLK_E, > 0, 0, } > }, > { PINMUX_CFG_REG_VAR("IPSR7", 0xE606003C, 32,
On Thu, Mar 30, 2017 at 9:33 AM, Chris Paterson <Chris.Paterson2@renesas.com> wrote: >> From: linux-renesas-soc-owner@vger.kernel.org [mailto:linux-renesas-soc- >> owner@vger.kernel.org] On Behalf Of Sergei Shtylyov >> Sent: 29 March 2017 19:37 >> >> The R8A7791 PFC driver was apparently based on the preliminary revisions of >> the user's manual, which omitted the DVC_MUTE signal altogether in the >> PFC section. The modern manual has the signal described, so just add the >> necassary data to the driver... >> >> Fixes: 508845196238 ("pinctrl: sh-pfc: r8a7791 PFC support") >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > Should this patch also CC stable? (Patch 1/2 does) No need to spam stable with all these patches and reviews. If it has a Fixes-tag, the stable team will pick it up anyway. After it has ended up upstream. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Wed, Mar 29, 2017 at 8:36 PM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > The R8A7791 PFC driver was apparently based on the preliminary revisions > of the user's manual, which omitted the DVC_MUTE signal altogether in > the PFC section. The modern manual has the signal described, so just add > the necassary data to the driver... > > Fixes: 508845196238 ("pinctrl: sh-pfc: r8a7791 PFC support") > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Chris, On Thu, Mar 30, 2017 at 11:00 AM, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Thu, Mar 30, 2017 at 9:33 AM, Chris Paterson > <Chris.Paterson2@renesas.com> wrote: >>> From: linux-renesas-soc-owner@vger.kernel.org [mailto:linux-renesas-soc- >>> owner@vger.kernel.org] On Behalf Of Sergei Shtylyov >>> Sent: 29 March 2017 19:37 >>> >>> The R8A7791 PFC driver was apparently based on the preliminary revisions of >>> the user's manual, which omitted the DVC_MUTE signal altogether in the >>> PFC section. The modern manual has the signal described, so just add the >>> necassary data to the driver... >>> >>> Fixes: 508845196238 ("pinctrl: sh-pfc: r8a7791 PFC support") >>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >> >> Should this patch also CC stable? (Patch 1/2 does) > > No need to spam stable with all these patches and reviews. > If it has a Fixes-tag, the stable team will pick it up anyway. After > it has ended > up upstream. And in this case, there's not really a need to backport it to stable, as there cannot be any users due to lack of pins using these definitions. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hello Geert, > From: geert.uytterhoeven@gmail.com > [mailto:geert.uytterhoeven@gmail.com] On Behalf Of Geert Uytterhoeven > Sent: 30 March 2017 10:11 > > Hi Chris, > > On Thu, Mar 30, 2017 at 11:00 AM, Geert Uytterhoeven <geert@linux- > m68k.org> wrote: > > On Thu, Mar 30, 2017 at 9:33 AM, Chris Paterson > > <Chris.Paterson2@renesas.com> wrote: > >>> From: linux-renesas-soc-owner@vger.kernel.org > >>> [mailto:linux-renesas-soc- owner@vger.kernel.org] On Behalf Of > >>> Sergei Shtylyov > >>> Sent: 29 March 2017 19:37 > >>> > >>> The R8A7791 PFC driver was apparently based on the preliminary > >>> revisions of the user's manual, which omitted the DVC_MUTE signal > >>> altogether in the PFC section. The modern manual has the signal > >>> described, so just add the necassary data to the driver... > >>> > >>> Fixes: 508845196238 ("pinctrl: sh-pfc: r8a7791 PFC support") > >>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > >> > >> Should this patch also CC stable? (Patch 1/2 does) > > > > No need to spam stable with all these patches and reviews. > > If it has a Fixes-tag, the stable team will pick it up anyway. After > > it has ended up upstream. Okay. > > And in this case, there's not really a need to backport it to stable, as there > cannot be any users due to lack of pins using these definitions. Whereas the first patch in the series fixes a problem that *is* currently seen by users, so will need backporting. Makes sense now, thanks! Kind regards, Chris > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
Hello! On 3/30/2017 12:16 PM, Chris Paterson wrote: >>>>> From: linux-renesas-soc-owner@vger.kernel.org >>>>> [mailto:linux-renesas-soc- owner@vger.kernel.org] On Behalf Of >>>>> Sergei Shtylyov >>>>> Sent: 29 March 2017 19:37 >>>>> >>>>> The R8A7791 PFC driver was apparently based on the preliminary >>>>> revisions of the user's manual, which omitted the DVC_MUTE signal >>>>> altogether in the PFC section. The modern manual has the signal >>>>> described, so just add the necassary data to the driver... >>>>> >>>>> Fixes: 508845196238 ("pinctrl: sh-pfc: r8a7791 PFC support") >>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >>>> >>>> Should this patch also CC stable? (Patch 1/2 does) >>> >>> No need to spam stable with all these patches and reviews. >>> If it has a Fixes-tag, the stable team will pick it up anyway. After >>> it has ended up upstream. > > Okay. > >> >> And in this case, there's not really a need to backport it to stable, as there >> cannot be any users due to lack of pins using these definitions. > > Whereas the first patch in the series fixes a problem that *is* currently seen by users, so will need backporting. Makes sense now, thanks! Note that it might only be seen by some out-of-tree boards, as neither upstream supported R8A7791-based board enables HSCIF1... > Kind regards, Chris > >> >> Gr{oetje,eeting}s, >> >> Geert MBR, Sergei
Index: linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7791.c =================================================================== --- linux-pinctrl.orig/drivers/pinctrl/sh-pfc/pfc-r8a7791.c +++ linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7791.c @@ -203,7 +203,7 @@ enum { /* IPSR6 */ FN_AUDIO_CLKB, FN_STP_OPWM_0_B, FN_MSIOF1_SCK_B, - FN_SCIF_CLK, FN_BPFCLK_E, + FN_SCIF_CLK, FN_DVC_MUTE, FN_BPFCLK_E, FN_AUDIO_CLKC, FN_SCIFB0_SCK_C, FN_MSIOF1_SYNC_B, FN_RX2, FN_SCIFA2_RXD, FN_FMIN_E, FN_AUDIO_CLKOUT, FN_MSIOF1_SS1_B, FN_TX2, FN_SCIFA2_TXD, @@ -573,7 +573,7 @@ enum { /* IPSR6 */ AUDIO_CLKB_MARK, STP_OPWM_0_B_MARK, MSIOF1_SCK_B_MARK, - SCIF_CLK_MARK, BPFCLK_E_MARK, + SCIF_CLK_MARK, DVC_MUTE_MARK, BPFCLK_E_MARK, AUDIO_CLKC_MARK, SCIFB0_SCK_C_MARK, MSIOF1_SYNC_B_MARK, RX2_MARK, SCIFA2_RXD_MARK, FMIN_E_MARK, AUDIO_CLKOUT_MARK, MSIOF1_SS1_B_MARK, TX2_MARK, SCIFA2_TXD_MARK, @@ -1093,6 +1093,7 @@ static const u16 pinmux_data[] = { PINMUX_IPSR_MSEL(IP6_2_0, STP_OPWM_0_B, SEL_SSP_1), PINMUX_IPSR_MSEL(IP6_2_0, MSIOF1_SCK_B, SEL_SOF1_1), PINMUX_IPSR_MSEL(IP6_2_0, SCIF_CLK, SEL_SCIF_0), + PINMUX_IPSR_GPSR(IP6_2_0, DVC_MUTE), PINMUX_IPSR_MSEL(IP6_2_0, BPFCLK_E, SEL_FM_4), PINMUX_IPSR_GPSR(IP6_5_3, AUDIO_CLKC), PINMUX_IPSR_MSEL(IP6_5_3, SCIFB0_SCK_C, SEL_SCIFB_2), @@ -5899,7 +5900,7 @@ static const struct pinmux_cfg_reg pinmu 0, 0, /* IP6_2_0 [3] */ FN_AUDIO_CLKB, FN_STP_OPWM_0_B, FN_MSIOF1_SCK_B, - FN_SCIF_CLK, 0, FN_BPFCLK_E, + FN_SCIF_CLK, FN_DVC_MUTE, FN_BPFCLK_E, 0, 0, } }, { PINMUX_CFG_REG_VAR("IPSR7", 0xE606003C, 32,
The R8A7791 PFC driver was apparently based on the preliminary revisions of the user's manual, which omitted the DVC_MUTE signal altogether in the PFC section. The modern manual has the signal described, so just add the necassary data to the driver... Fixes: 508845196238 ("pinctrl: sh-pfc: r8a7791 PFC support") Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- drivers/pinctrl/sh-pfc/pfc-r8a7791.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)