fscrypt: Remove __packed from fscrypt_policy
diff mbox

Message ID 20170404224040.63624-1-joerichey94@gmail.com
State Superseded
Headers show

Commit Message

Joe Richey April 4, 2017, 10:40 p.m. UTC
From: Joe Richey <joerichey@google.com>

This commit removes __packed from fscrypt_policy as it does not contain
any implicit padding and does not refer to an on-disk structure. Even
though this is a change to a UAPI file, no users will be broken as the
structure doesn't change.

Change-Id: I6075696cee284c3bd4aefa3e9e2dae735602c583
Signed-off-by: Joe Richey <joerichey@google.com>
---
 include/uapi/linux/fs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Richard Weinberger April 6, 2017, 7:17 p.m. UTC | #1
On Wed, Apr 5, 2017 at 12:40 AM, Joe Richey <joerichey94@gmail.com> wrote:
> From: Joe Richey <joerichey@google.com>
>
> This commit removes __packed from fscrypt_policy as it does not contain
> any implicit padding and does not refer to an on-disk structure. Even
> though this is a change to a UAPI file, no users will be broken as the
> structure doesn't change.
>
> Change-Id: I6075696cee284c3bd4aefa3e9e2dae735602c583

Please remove this internal id.

> Signed-off-by: Joe Richey <joerichey@google.com>
> ---
>  include/uapi/linux/fs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/fs.h b/include/uapi/linux/fs.h
> index 048a85e9f017..f6e1c54ac5e2 100644
> --- a/include/uapi/linux/fs.h
> +++ b/include/uapi/linux/fs.h
> @@ -279,7 +279,7 @@ struct fscrypt_policy {
>         __u8 filenames_encryption_mode;
>         __u8 flags;
>         __u8 master_key_descriptor[FS_KEY_DESCRIPTOR_SIZE];
> -} __packed;
> +};

Reviewed-by: Richard Weinberger <richard@nod.at>

Patch
diff mbox

diff --git a/include/uapi/linux/fs.h b/include/uapi/linux/fs.h
index 048a85e9f017..f6e1c54ac5e2 100644
--- a/include/uapi/linux/fs.h
+++ b/include/uapi/linux/fs.h
@@ -279,7 +279,7 @@  struct fscrypt_policy {
 	__u8 filenames_encryption_mode;
 	__u8 flags;
 	__u8 master_key_descriptor[FS_KEY_DESCRIPTOR_SIZE];
-} __packed;
+};
 
 #define FS_IOC_SET_ENCRYPTION_POLICY	_IOR('f', 19, struct fscrypt_policy)
 #define FS_IOC_GET_ENCRYPTION_PWSALT	_IOW('f', 20, __u8[16])