Patchwork exynos: add C++ support to exynos_drmif header

login
register
mail settings
Submitter Tobias Jakobi
Date April 5, 2017, 2:22 p.m.
Message ID <1491402144-3298-1-git-send-email-tjakobi@math.uni-bielefeld.de>
Download mbox | patch
Permalink /patch/9664273/
State New
Headers show

Comments

Tobias Jakobi - April 5, 2017, 2:22 p.m.
Add the usual extern "C" when compiling in C++ mode.

Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
---
 exynos/exynos_drmif.h | 8 ++++++++
 1 file changed, 8 insertions(+)
Eric Engestrom - April 5, 2017, 3:48 p.m.
On Wednesday, 2017-04-05 16:22:24 +0200, Tobias Jakobi wrote:
> Add the usual extern "C" when compiling in C++ mode.

Thanks, but why specifically this header? The other exynos/*.h headers
also lack the c++ mangling guard.

A quick grep shows that only 15/101 headers in libdrm have it.
Can I interest you in fixing a few more headers? :)

In any case, this patch is:
Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>
(I assume you'll push it yourself?)

Btw, can you run this in your local libdrm repo?
  $ git config --local format.subjectPrefix "PATCH libdrm"

Cheers,
  Eric


> 
> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
> ---
>  exynos/exynos_drmif.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/exynos/exynos_drmif.h b/exynos/exynos_drmif.h
> index 626e399..154439b 100644
> --- a/exynos/exynos_drmif.h
> +++ b/exynos/exynos_drmif.h
> @@ -31,6 +31,10 @@
>  #include <stdint.h>
>  #include "exynos_drm.h"
>  
> +#if defined(__cplusplus)
> +extern "C" {
> +#endif
> +
>  struct exynos_device {
>  	int fd;
>  };
> @@ -109,4 +113,8 @@ int exynos_handle_event(struct exynos_device *dev,
>  				struct exynos_event_context *ctx);
>  
>  
> +#if defined(__cplusplus)
> +}
> +#endif
> +
>  #endif /* EXYNOS_DRMIF_H_ */
> -- 
> 2.7.3
>
Tobias Jakobi - April 5, 2017, 4:23 p.m.
Hello Eric,


Eric Engestrom wrote:
> On Wednesday, 2017-04-05 16:22:24 +0200, Tobias Jakobi wrote:
>> Add the usual extern "C" when compiling in C++ mode.
> 
> Thanks, but why specifically this header? The other exynos/*.h headers
> also lack the c++ mangling guard.
I'm currently writing a small C++ project using the
exynos_bo_{create,destroy}() calls, and noticed this.

> A quick grep shows that only 15/101 headers in libdrm have it.
> Can I interest you in fixing a few more headers? :)
Not at the moment.


- Tobias

> In any case, this patch is:
> Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>
> (I assume you'll push it yourself?)
> 
> Btw, can you run this in your local libdrm repo?
>   $ git config --local format.subjectPrefix "PATCH libdrm"
> 
> Cheers,
>   Eric
> 
> 
>>
>> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
>> ---
>>  exynos/exynos_drmif.h | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/exynos/exynos_drmif.h b/exynos/exynos_drmif.h
>> index 626e399..154439b 100644
>> --- a/exynos/exynos_drmif.h
>> +++ b/exynos/exynos_drmif.h
>> @@ -31,6 +31,10 @@
>>  #include <stdint.h>
>>  #include "exynos_drm.h"
>>  
>> +#if defined(__cplusplus)
>> +extern "C" {
>> +#endif
>> +
>>  struct exynos_device {
>>  	int fd;
>>  };
>> @@ -109,4 +113,8 @@ int exynos_handle_event(struct exynos_device *dev,
>>  				struct exynos_event_context *ctx);
>>  
>>  
>> +#if defined(__cplusplus)
>> +}
>> +#endif
>> +
>>  #endif /* EXYNOS_DRMIF_H_ */
>> -- 
>> 2.7.3
>>
Emil Velikov - April 8, 2017, 8:45 p.m.
On 5 April 2017 at 17:23, Tobias Jakobi <tjakobi@math.uni-bielefeld.de> wrote:
> Hello Eric,
>
>
> Eric Engestrom wrote:
>> On Wednesday, 2017-04-05 16:22:24 +0200, Tobias Jakobi wrote:
>>> Add the usual extern "C" when compiling in C++ mode.
>>
>> Thanks, but why specifically this header? The other exynos/*.h headers
>> also lack the c++ mangling guard.
> I'm currently writing a small C++ project using the
> exynos_bo_{create,destroy}() calls, and noticed this.
>
>> A quick grep shows that only 15/101 headers in libdrm have it.
>> Can I interest you in fixing a few more headers? :)
> Not at the moment.
>
FTR, only the installed headers (~50) need the extern C guard.
None of that is not a blocker for this patch, so I've just pushed it to master.

Thanks!
Emil
Tobias Jakobi - April 8, 2017, 10:47 p.m.
Emil Velikov wrote:
> FTR, only the installed headers (~50) need the extern C guard.
> None of that is not a blocker for this patch, so I've just pushed it to master.
Thanks Emil. I'll see what I can do about the other ones.

- Tobias


> Thanks!
> Emil
>

Patch

diff --git a/exynos/exynos_drmif.h b/exynos/exynos_drmif.h
index 626e399..154439b 100644
--- a/exynos/exynos_drmif.h
+++ b/exynos/exynos_drmif.h
@@ -31,6 +31,10 @@ 
 #include <stdint.h>
 #include "exynos_drm.h"
 
+#if defined(__cplusplus)
+extern "C" {
+#endif
+
 struct exynos_device {
 	int fd;
 };
@@ -109,4 +113,8 @@  int exynos_handle_event(struct exynos_device *dev,
 				struct exynos_event_context *ctx);
 
 
+#if defined(__cplusplus)
+}
+#endif
+
 #endif /* EXYNOS_DRMIF_H_ */