diff mbox

[v2,8/8] blk-mq: clean up direct issue blk_mq_queue_data initialization

Message ID e0eac74e541e9f85403fd4cf887a7f288768f00e.1491416593.git.osandov@fb.com (mailing list archive)
State New, archived
Headers show

Commit Message

Omar Sandoval April 5, 2017, 6:28 p.m. UTC
From: Omar Sandoval <osandov@fb.com>

Trivial cleanup.

Signed-off-by: Omar Sandoval <osandov@fb.com>
---
 block/blk-mq.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Bart Van Assche April 5, 2017, 6:35 p.m. UTC | #1
On Wed, 2017-04-05 at 11:28 -0700, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
> 
> Trivial cleanup.
> 
> Signed-off-by: Omar Sandoval <osandov@fb.com>
> ---
>  block/blk-mq.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index 71dc8608f3a8..779249a5999b 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -1451,8 +1451,7 @@ static void __blk_mq_try_issue_directly(struct request *rq, blk_qc_t *cookie,
>  	struct request_queue *q = rq->q;
>  	struct blk_mq_queue_data bd = {
>  		.rq = rq,
> -		.list = NULL,
> -		.last = 1
> +		.last = true,
>  	};
>  	struct blk_mq_hw_ctx *hctx;
>  	blk_qc_t new_cookie;

Hello Omar,

Although this patch looks fine to me I'm afraid that since this morning
it no longer applies to Jens' for-next branch.

Bart.
Omar Sandoval April 5, 2017, 6:37 p.m. UTC | #2
On Wed, Apr 05, 2017 at 06:35:58PM +0000, Bart Van Assche wrote:
> On Wed, 2017-04-05 at 11:28 -0700, Omar Sandoval wrote:
> > From: Omar Sandoval <osandov@fb.com>
> > 
> > Trivial cleanup.
> > 
> > Signed-off-by: Omar Sandoval <osandov@fb.com>
> > ---
> >  block/blk-mq.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/block/blk-mq.c b/block/blk-mq.c
> > index 71dc8608f3a8..779249a5999b 100644
> > --- a/block/blk-mq.c
> > +++ b/block/blk-mq.c
> > @@ -1451,8 +1451,7 @@ static void __blk_mq_try_issue_directly(struct request *rq, blk_qc_t *cookie,
> >  	struct request_queue *q = rq->q;
> >  	struct blk_mq_queue_data bd = {
> >  		.rq = rq,
> > -		.list = NULL,
> > -		.last = 1
> > +		.last = true,
> >  	};
> >  	struct blk_mq_hw_ctx *hctx;
> >  	blk_qc_t new_cookie;
> 
> Hello Omar,
> 
> Although this patch looks fine to me I'm afraid that since this morning
> it no longer applies to Jens' for-next branch.
> 
> Bart.

Oh, I forgot to rebase. Thanks, Bart, I'll send out an updated version.
diff mbox

Patch

diff --git a/block/blk-mq.c b/block/blk-mq.c
index 71dc8608f3a8..779249a5999b 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -1451,8 +1451,7 @@  static void __blk_mq_try_issue_directly(struct request *rq, blk_qc_t *cookie,
 	struct request_queue *q = rq->q;
 	struct blk_mq_queue_data bd = {
 		.rq = rq,
-		.list = NULL,
-		.last = 1
+		.last = true,
 	};
 	struct blk_mq_hw_ctx *hctx;
 	blk_qc_t new_cookie;