xfsprogs: document barrier deprecation in xfs(5)
diff mbox

Message ID d24e1def-2f2d-5699-46e0-633d613004da@redhat.com
State Accepted
Headers show

Commit Message

Eric Sandeen April 10, 2017, 4:53 p.m. UTC
Since kernel v4.10, the barrier mount option is deprecated:

2291dab2 xfs: Always flush caches when integrity is required
4cf4573d xfs: deprecate barrier/nobarrier mount option

Document this fact in the xfs(5) manpage.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---


--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Darrick J. Wong April 10, 2017, 10:38 p.m. UTC | #1
On Mon, Apr 10, 2017 at 11:53:53AM -0500, Eric Sandeen wrote:
> Since kernel v4.10, the barrier mount option is deprecated:
> 
> 2291dab2 xfs: Always flush caches when integrity is required
> 4cf4573d xfs: deprecate barrier/nobarrier mount option
> 
> Document this fact in the xfs(5) manpage.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Looks ok.
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
> 
> diff --git a/man/man5/xfs.5 b/man/man5/xfs.5
> index c7fb780..745dad4 100644
> --- a/man/man5/xfs.5
> +++ b/man/man5/xfs.5
> @@ -133,6 +133,12 @@ CRC enabled filesystems always use the attr2 format, and so
>  will reject the noattr2 mount option if it is set.
>  .TP
>  .BR barrier | nobarrier
> +Note: This option has been
> +.B deprecated
> +as of kernel v4.10; in that version, integrity operations are
> +always performed and the mount option is ignored.  These mount
> +options will be removed no earlier than kernel v4.15.
> +.sp
>  Enables/disables the use of block layer write barriers for
>  writes into the journal and for data integrity operations.
>  This allows for drive level write caching to be enabled, for
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/man/man5/xfs.5 b/man/man5/xfs.5
index c7fb780..745dad4 100644
--- a/man/man5/xfs.5
+++ b/man/man5/xfs.5
@@ -133,6 +133,12 @@  CRC enabled filesystems always use the attr2 format, and so
 will reject the noattr2 mount option if it is set.
 .TP
 .BR barrier | nobarrier
+Note: This option has been
+.B deprecated
+as of kernel v4.10; in that version, integrity operations are
+always performed and the mount option is ignored.  These mount
+options will be removed no earlier than kernel v4.15.
+.sp
 Enables/disables the use of block layer write barriers for
 writes into the journal and for data integrity operations.
 This allows for drive level write caching to be enabled, for