From patchwork Mon Apr 10 18:40:49 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 9673985 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 12C6F60244 for ; Mon, 10 Apr 2017 18:41:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 084852847B for ; Mon, 10 Apr 2017 18:41:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EE5F628488; Mon, 10 Apr 2017 18:41:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A1ABC2847B for ; Mon, 10 Apr 2017 18:41:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751949AbdDJSlB (ORCPT ); Mon, 10 Apr 2017 14:41:01 -0400 Received: from esa1.hgst.iphmx.com ([68.232.141.245]:49936 "EHLO esa1.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751273AbdDJSk7 (ORCPT ); Mon, 10 Apr 2017 14:40:59 -0400 X-IronPort-AV: E=Sophos;i="5.37,182,1488816000"; d="scan'208";a="111948249" Received: from mail-dm3nam03lp0016.outbound.protection.outlook.com (HELO NAM03-DM3-obe.outbound.protection.outlook.com) ([207.46.163.16]) by ob1.hgst.iphmx.com with ESMTP; 11 Apr 2017 02:40:57 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=S4CtKVxgh/jkn7OfajSeOyigDAUJDYetgpzPIuCvsnc=; b=U1Z1Sp9lpMlQr8z72M2D/rT7GMOBK8a19lfvK4jh8rM3BRY/zK5n6DOoOZe8Hh+J4VsDGNSebbIugFA5ldf+dU3pbpeBwBWbm/KVL6/K77WpLJTUZsZYigzhCwckWpb8BSXm5SEVK75zYvoMMM+4CjvlJVhjzu8VqYtcIb6efgs= Received: from CO2PR04CA0117.namprd04.prod.outlook.com (10.165.95.19) by BN1PR04MB391.namprd04.prod.outlook.com (10.141.60.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1005.10; Mon, 10 Apr 2017 18:40:56 +0000 Received: from BN3NAM04FT036.eop-NAM04.prod.protection.outlook.com (2a01:111:f400:7e4e::204) by CO2PR04CA0117.outlook.office365.com (2603:10b6:104:7::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1019.17 via Frontend Transport; Mon, 10 Apr 2017 18:40:56 +0000 Authentication-Results: spf=pass (sender IP is 63.163.107.21) smtp.mailfrom=sandisk.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=sandisk.com; Received-SPF: Pass (protection.outlook.com: domain of sandisk.com designates 63.163.107.21 as permitted sender) receiver=protection.outlook.com; client-ip=63.163.107.21; helo=milsmgep15.sandisk.com; Received: from milsmgep15.sandisk.com (63.163.107.21) by BN3NAM04FT036.mail.protection.outlook.com (10.152.93.184) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.1019.14 via Frontend Transport; Mon, 10 Apr 2017 18:40:55 +0000 Received: from MILHUBIP04.sdcorp.global.sandisk.com (Unknown_Domain [10.201.67.162]) (using TLS with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by (Symantec Messaging Gateway) with SMTP id 07.06.29323.4B1DBE85; Mon, 10 Apr 2017 11:40:55 -0700 (PDT) Received: from milsmgip12.sandisk.com (10.177.9.6) by MILHUBIP04.sdcorp.global.sandisk.com (10.177.9.97) with Microsoft SMTP Server id 14.3.319.2; Mon, 10 Apr 2017 11:40:52 -0700 X-AuditID: 0ac94369-1c3ff7000000728b-73-58ebd1b4e2e0 Received: from exp-402881.sandisk.com ( [10.177.9.6]) by (Symantec Messaging Gateway) with SMTP id C6.21.18148.1B1DBE85; Mon, 10 Apr 2017 11:40:52 -0700 (PDT) Subject: Re: [PATCH 0/2] Export more queue state information through debugfs To: Jens Axboe References: <20170330182127.24288-1-bart.vanassche@sandisk.com> <826af944-2316-8352-118c-91887d747eca@kernel.dk> CC: "linux-block@vger.kernel.org" From: Bart Van Assche Message-ID: <51f5cd27-4ae4-0a21-63e2-c7a2ec95e257@sandisk.com> Date: Mon, 10 Apr 2017 11:40:49 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <826af944-2316-8352-118c-91887d747eca@kernel.dk> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGLMWRmVeSWpSXmKPExsXCddJ5ke72i68jDOadYLZYfbefzWLvLW0H Jo/LZ0s9Pm+SC2CK4rJJSc3JLEst0rdL4MqY+fYCU0GLYMXT/dfZGxhf8nYxcnBICJhIPNsi 3MXIxSEksJRJ4vra6WwQzjZGic09T5i6GDnBihaff8UEkVjMKLH24l2whLCAj8THn09ZQGwR AQWJnt8r2UBsIYEiia45+1hBbGYBe4m9t1sZQWw2ASOJb+9ngtXzCthJrJzZyQxiswioSnw/ 3MUOYosKREg87NzFDlEjKHFy5hOwek4BW4mtU+6ygVzNLKApsX6XPsR4eYntb+cwg9wmIdDF KvHz2iJGiBvUJU4umc80gVF4FpJRsxDaZyFpX8DIvIpRLDczpzg3PbXA0FSvODEvJbM4Wy85 P3cTIyS0M3cw3n3ifYhRgINRiYf3RNXrCCHWxLLiytxDjBIczEoivHqHgEK8KYmVValF+fFF pTmpxYcYpTlYlMR5z8lMjRASSE8sSc1OTS1ILYLJMnFwSjUwbik9mhYknGrYdKItt3Z9Z9uK tMxrEdebIh5M2bn+oPeJD50+e0TVbPalf5RN/rfs3cv5Tu+P74hnVr7gcOCvdciTCxPSzh5+ veCwRfiCLUl2Z699uTIn+ti0GcE+uwMPaoSVHdUUaHTJymec+V3o7IP79W9+hgvaW6Xt2r48 8pL+1Hy/DW+tapVYijMSDbWYi4oTAZoqOlxpAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHJMWRmVeSWpSXmKPExsXCtZGTTXfLxdcRBvseslisvtvPZrH3lrYD k8fls6UenzfJBTBFcdmkpOZklqUW6dslcGXMfHuBqaBFsOLp/uvsDYwvebsYOTkkBEwkFp9/ xdTFyMUhJLCQUeLclSZWkISwgI/Ex59PWUBsEQEFiZ7fK9lAbCGBIomuOfvAapgF7CXObJ8K ZrMJGEl8ez8TrJ5XwE5i5cxOZhCbRUBV4vvhLnYQW1QgQuJh5y52iBpBiZMzn4DVcwrYSmyd cpcNYqa6xJ95l5ghbHmJ7W/nME9g5JuFpGUWkrJZSMoWMDKvYhTLzcwpzk3PLDA00itOzEvJ LM7WS87P3cQICbGoHYzXJ5ofYmTi4JRqYKxO23D2btLyu9wPbyYXnr3+ba4Gh1trgarSJ0nj 2rApc6XvXjM0n8r29/bvp+eeKx7ybYjJuP1xL0fAxuN8tWm2z0Qfq1xTY9Jur9yntVlalWXB 8/LJbHu/lzKknxc/cjr3U4ysz81pwSVSu6USjv2ddlmlQuDrpfaNOQ6lXkKK1R5/lx5vNFBi Kc5INNRiLipOBAAip9x04QEAAA== X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:63.163.107.21; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(39850400002)(39400400002)(39450400003)(39860400002)(39840400002)(39410400002)(2980300002)(438002)(189002)(199003)(377454003)(24454002)(9170700003)(81166006)(8676002)(106466001)(8936002)(23676002)(54356999)(50986999)(86362001)(76176999)(65956001)(47776003)(31696002)(31686004)(64126003)(305945005)(5660300001)(53416004)(65826007)(50466002)(83506001)(36756003)(4001350100001)(53546009)(77096006)(2950100002)(6666003)(6916009)(33646002)(230700001)(229853002)(2906002)(110136004)(38730400002)(189998001)(4326008)(53936002); DIR:OUT; SFP:1102; SCL:1; SRVR:BN1PR04MB391; H:milsmgep15.sandisk.com; FPR:; SPF:Pass; MLV:sfv; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN3NAM04FT036; 1:VhR6kroFD/z9X2by3t1fZNqn1MdRKzvOY5kZZ0HUoruLH7nh4W4qcizjoGOxfwaJDg2vEesMvPdRD0jrhObRNna0vkWkF2ixT4PTo47xnrAauUi5sAHHob2pRAB0rZMJxnyDE1Rwz7BsgdjUXGo6TLS9bXK7QijszY8tS4sfbioImZ64uXV46e58f8eVrJpdSBx1KRWuNsDf87Jn+ndZmqGWK4JU/HpsAzm4uyZzjrhevHco3gNSreuj6JRHVHOCT9Y1AFTbihGkW4VqrCP/QaKjSUEDw+QJ/JzGdJJt0fh+jEk7waw+ShxLjs4GuW0yODzNJyHBy8L2oLTK+16fny5/ZBqrb6OfAkEVGX9ItjLF8/YFb73VwT6FstxCtbIwXU3sxrBJbKfL+diyUdCvGy2GZxa4I5q1wRYN4YOazEhjbC2AdOOFOuJPQ7qUZ4M5eFLO3LYEBf963mo5NbqP0HVC/iM/iHYQEWaZGOV9zpxdRJY2sr5BcswIGa/XwtjxshX6P4kGF/b5bBi+wjyxI8KNWC1NO3zdTfjz3r9zXyY= X-MS-Office365-Filtering-Correlation-Id: 495a911b-0004-4ddf-2d39-08d480411f7f X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(8251501002)(2017030254075)(201703131423075)(201703031133081); SRVR:BN1PR04MB391; X-Microsoft-Exchange-Diagnostics: 1; BN1PR04MB391; 3:2z0+Iaxqn0gptOyVvz8Vp8GQHU5ect+boU5mW1KU8pj0iQcHj/rAYa6NWCgtXh4e1rFFCp+LUqA7eb3PgbBzVvnK5vodMsZuKoNvP0hYoShoU6+8m6RfcbcMqtVobQtKQ2/b5kr715H9QkVtjoQltEyGL52UTRIJ0z2SHy+GXKrjoFpZUsO07JSNLw8okmwO6oKtrnrzY8sutZ5tAtsujRWayEJaaieHzgSPtf7LGBT1lvRLEOHLHZSTvVlqvMb9Y+AUo3gEkMgu55veBPrAZKTfunb4ntYGAktgFzGDTLcKztHqNLsrygYnkZBdglgoq9PTexYyT0q4NAfzPAv1lGrgfaE5g+07/5mAcLpYn5L50oeKRoGKDFgykc8GXqemxu6QZ/SvzEsNewRwnB2KJIZuwB0aQGhCwnWH60jbEJGTH/SrcdiyjU8vyWKyj28bd/q/QY/iGlGhlGGiGLrqs1v4q3I8z9NXhslX8Z7+ZkrlS9tm7o4eUzOTU1yUAukD X-Microsoft-Exchange-Diagnostics: 1; BN1PR04MB391; 25:lsrkWlKG0Y85c+dpvwHC6cm0bZMg7s9sXjUwqCr4xDrzT33qZsqmwteyKjAzxdvrkwhycl7ACzM5PwN6boNBleIsT0ho1azuBhxGus6xd7kdfMQbfFcQMG7T+LYiTIOzjVA8fP4zSIJe4mehQntV1MmrNHXOcSsqnGYuzk8VS8WjBf7FmfCpFJtEtOg/Re9RI/vTzji9I0LA/z5ssaqk7Tpvs/bdee3PdliGYv0vCP2UjL1+7YL0lJkWqk+jKAktsYB0jdz7fEeCutIy4V6eQ02ZjhAV+XHalFRPs95p3kWduNN+s4rUlPtmwDcfra18Zt1bHL4jNDMVahE972kvl6UeN5o5zcps/c8NuXW/JW9m/WAPAf09dFQfvQ9SU6ctBzTtxBZWE1uN3F+z1SXumK3IqQbEt9aChpcV4zi9ebw8Yf788Jz63pBRBJPFxNycGzSzKqrPsrV0v76V5SPRYQ==; 31:4njxD4CIVHMWkCf1T3vxctc1ZPQinYsZ5fBWZpGZHoIXS1kH41gp2hWyeDXqKcN7cMGenRMF5azbC7n1tC5gyPrykjjRAr6m+bGvWXH1HlAgVPZ5tJEW/4tc9sTaKh+aeZam15b0hxxwR++ySVhMOoC2xPeJLmstL9JdT6V7X7mdWajFt1TXHueUkO/DjBct2BsusOBJtSXflpYLi7lBh/AUurOVfRdlmZuHWVr4XGGu4Fwlr4q4Vb4Mr/zNty9ZdsmbuhqGLHvUyLLrTU7GfBX/W/rsoQlVuLnnVOphKOY= WDCIPOUTBOUND: EOP-TRUE X-Microsoft-Exchange-Diagnostics: 1; BN1PR04MB391; 20:VGtymczwWReZI91ZPmVl9rZIeuHKcKjB7VPw4Bk2i/Uy7kq6ykhsmFAUgRP/jfvCfASalHPiPk8BQd/WRq+Wgaa3OMu8ylqOn0uQZHjzJpEQkrR3Oiw0CZhdafE+W/9KNnV5wNL1Mros5qZ+t8dyB/bc7KYrpu0ho3qnKpvezxK0SmwRu1hPlCHhts+DF6Q3FvYkdphlephhskMznb7m39htWgmZDd4bBCEon6AEtv76r6CHYFnH35nGy5anCibZN5I8aSTvVa9KOdbWVqKAO3jWnFUMYf1s9/+JdlOzaX7eEKO3znbLwAfY5WHEiKNlNLff3qHWHqcV/1alMdxDgIfLIsXVfAOGxLm4RWQFDE62Bpke3+kAnpmb2PHXhw2q/khTFDqF80V53NI0SItMHu1iIW2eXFkkyx+c5dtevH/FvaDr6umwFlM+urEocPAEgC94WJS5GwuU1niu5CNW+/BJ3g/+N/tPgoEWKxmEOEAN6YM/9U/dJEccOvxcSP8C X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(42932892334569); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(13018025)(13016025)(10201501046)(3002001)(93006095)(93004095)(6055026)(6041248)(20161123564025)(20161123560025)(20161123555025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(6072148); SRVR:BN1PR04MB391; BCL:0; PCL:0; RULEID:; SRVR:BN1PR04MB391; X-Microsoft-Exchange-Diagnostics: 1; BN1PR04MB391; 4:OcmPUbFM32PFkvVLSeGR3FJd2NK/n5daIlyQyrPftixVdhaqH33L5HONNueY6/PWP4TJtDOwrsRssGSDcUdoAS9tiQa+KEe+W1FLsloAp0CunPyXaOIRLPmwIqqFqeyl2bkhrj0n7W6WNNH6JmnLEjm4p6VPBJVx24nSxIePk6GrQ5QEtUCmG+4gFagCb7jJluNTkUjCu3pKmzJ0kXUyP7J3oVHKULzIWt7SeGd1jNfnblCVDQeCNbMosTCXGiIXmjafiLRH1YaEG68V5AFAPanUkAkVERbjyW+GOAiagpdeXZjBmxjHf566i657sfLqR4ERiGDbQcSS0JXzNpgrltYGsmqkqFtjDQHgrxx+s3wcXvwDCpInNHBZaHYNgXGxfnlgY9rdPHHmQbWe8RLeUWQpROR3bemTwxYYAGqrcvgPTs/RdAgVQ+bHJ54lKUdTm+nBWgLILky8iCW2lKCFlda3vVI94sPuc+/7cmuB5TL/SEgS63I7OHv9Lq27fLPX288tLgyYN+XzFqQRXVlLlWHuAuBjybtAok9c2+eJ7GAwF+mhYXWOusL+pTYD6225yoh8WcTmqAGfQtWfRd6+8IyfGP9JBxJ391y+0j77UPGPw4eiMbZrJq36dHrKTsyn0Pwrj/GlZUZORxbqpecRjIAkmp4EIlrRZbdKBUCf68dMa1swwbluvKuInKktgbhfDe2vorWrUPQ0MRkZx5/Iqc3EDKmyWsPfmE/3j9kbOHKu4r0q+sjI/ZUyEaWWoOaBfNpp2HYtTbrqEfUlnkX/Ddkd0oGA2QUxeFKX2x3X80Rr6NP5AnwgY2bLLEWYUauo X-Forefront-PRVS: 027367F73D X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjFQUjA0TUIzOTE7MjM6MmdmMDVqNEpBdE1laUpsbjVwVHY4L3FwanBO?= =?utf-8?B?bGU5Q2sxMVB5eEhwRzNoUGh1YitDL1IrVTNZRWpuTzBycGhnRXBsS085Tkk0?= =?utf-8?B?QnU4OGpGSFgweXIrekk5am5HTTFQcGdsZ3c4WncvRXVNb0dHWHpGMVFvSmdT?= =?utf-8?B?RkM3TjUxMGt2WmJWMEc2cE9zdWh2RFJ0MGxRb3c1d0pmSTlqUnJ4dDBnREpw?= =?utf-8?B?bXltc1ZiM3M4eUQ1WFd5MnM2czJLY01NR0xDNmZuSXl2WGdiUENmNWp2ZkhP?= =?utf-8?B?dCt4eFdrOEJqSTgrSVJWVzhBM1JsY3J2bm80eXJ2bXViL005VGVmSEtibnpP?= =?utf-8?B?dmtYODAybFJrV0JiMHc2VVpuOHdJWXhIVHREYzVJVGFqUTBZcU4wVzZwbVFN?= =?utf-8?B?V1BEbUpTWHdvY3Qyd01PdEk1UnNyNzBiTktrNUU1YVI0VFhpcmZjNEl2WHNk?= =?utf-8?B?dHpmcDJjcW12cGxndEk4aHFFVm1JLzE0QVozZnlBaEtyZ3BaYVQvWU9DMlNO?= =?utf-8?B?WHMrWDVnYmJrRGtuaEFENGhUSnRiT3JNVUM4UW5xZWxMeWt6M1JDS2lrUEda?= =?utf-8?B?WWc5ODNXTm1EQkNnTEQzWjlBN1ZjQit5ZWZEc0RnNXV3NTRydFFvMFBqa0ti?= =?utf-8?B?Z3NQbDdSL1FaSHI2MU55Sm9CYzl5Ykc4ZkFvTVBxMHA3Ylh3RGV4Unlhc0s3?= =?utf-8?B?cXQxNmErYmc3N3lNUkZRcWxsOGJDUmRucFVLMmVZb21VVCs1QitrZGdxUjhN?= =?utf-8?B?K2VIQzcxNEhYSGo3OVpLNHNDSlpiZ1lpQUtSNUdDa1Z1eEtTQnF1Z0ppdkFH?= =?utf-8?B?ZUQwbWtKc0VoS0dmZFFtRnVzZlY1WVNSSjYzRFZEM0o0blRLM2QyZ09nWFBw?= =?utf-8?B?WHNHalI5YmJ6ZHdNd0hsL0VCS3hNS0N1M1U2YVlHSUNuWFg1aUlFbitoOGdV?= =?utf-8?B?TDB1TzZmTWdQZXJhN0FxaHJSaWV2NERzYlVDalJlaG9sbWpOeDRzMUhqb25q?= =?utf-8?B?V2RqUm1XZ3FKR3lSYVBGNy91alU5c1F3ekRZc0V4cHlnNHBLaTVIOFNrUTNv?= =?utf-8?B?UHBWUGtqa2J2R0ZJZkxyakQwRmJYNllESC8wRE9ZM1JFcGxScVIzWS9TRG9T?= =?utf-8?B?cmhBaURacFU3eWpKbnI3SmJHYkppMUcvYS92SEUzSk9OUHpwZjhKVTQ4VU04?= =?utf-8?B?eUt6bkpXN1V2emxFNURma2RHU0p1MVJqRHhHeWlCM0E4WTZtZzE5b1Z6Zm9k?= =?utf-8?B?RGZ1N05wb2FkQVFoaDZRSVVLMllQb0djdTdoZk4yRE1BSWZaL1RwKzA4enVM?= =?utf-8?B?eEEwYll4eEMxNWViKzdjOGowWWdZMkdIUHNmMWdIa3diWlgxT1V6emhyK2VV?= =?utf-8?B?MU5qYjNXaVVmM0t5YTIxMit0a0hiNnl6UExkMGlFSU5vSzVqNWhrTFZYR3Rt?= =?utf-8?B?aUlKUFJSNnYwN0V2S1RBWWJFWXdkbVhZTVU1MmZucnJNQkZqckFLdGNNN0dl?= =?utf-8?B?cGI4TVM0U094RCs4OWNZVUhTR2hHN3FTOFFiV21paU8vcWI0TVJ2cWNBSFIy?= =?utf-8?B?QlJDaHRQdk5kOHNVRXJnQVNpTXp6Y01jUHVLUnpla0syK0g2dXBINGhoYVh6?= =?utf-8?B?UXlMQXhQYXg1WU9ieWwvTTdScGIyanI3NEhvVzBjMnY3aTNaam5GbjByNmVq?= =?utf-8?Q?MucWRR0oboQKm1C8A=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN1PR04MB391; 6:Eh1LdmXWfqwh58iJHMMvnoEuiXdkY3Iy17G9toNIl4pPCqTQq56rSgn7O14NselGoD/z+qjI0cWjbReCqH1189rxLFgj4Yx2UvwzWy3Bqy7mxcnNI1Mkai+sBn4YcmDzIsVJ+dLGjaU55yLEDYwCIC8j24uVISnCQEKWe5DZlAaFnMEAZJiF56ZSVyfPVno5hJA5qIkGbgd9nPpjVafqJl6LjSY9lL0cQUNVdVS1xjHG9suf4mSJ2Yj0zk2+P2BG5cfKJNcoS3etnaW/wG79n//gvG0QTmWIXozzErmgZJGDwrnYmUmZp6omj05hPGhUqeQuA2Phw62iHvexNKIX9hcnVsUC8IrKa+Bsj6uc7a1/R1kcpC+gsDKO+NamwRWMiwpB4E/XJDqhWuZ/taDgKI+xPasgVKB+mkKZDabdbRUcHw+NsHV4qE11XqMhkJG9uSdQ9j7kS7EXZX7lVOYmdjerLOWORVFS71wtyYCQdwI=; 5:IcnX2VfHqnjmXmXxAhsMVQhIPujS0cPsuwDuDDNOlG681i088BLvUq/zQAv+zew/IOvQkzf8VtsxSKik8ddvq6+8OX9iS4SahgMVxuw6n8bN4NpdZzqI5J3lG4fF9ZqV7ZkiDmxDcADjG+Zprmgqfw==; 24:Yw9mnKsMOCSrReqKFWRmX+jDZy52ntRsDlANHi816zxJUbKuBEt8MPKPLhOMEI72Vmoc2Z1KiD1DgNqlTCTYxmfbYqw+7zf4+Pk0M4HwOWo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN1PR04MB391; 7:4dfcR3EOTkPLybDW/uNKHkNiEu5MzSS2BtS+aT8+m/XkFVCF0G46oitKv5+fNarLglPZreqw+z0RLgmALmcxCaZvsmhhpcCfU/6TyDIzvHcugF/0iCWzzAX/E1esQmrerBgAR3M+wYc3Ka6QCeqPxNIb3LaBLKhhdth0hXvUUad/OduBzt2vWfrbjTL+2x72Pio7gEzNb2SlfhTlg55x2IkE//686XR31UvQFEbknXu9fcc3wJoXSNPqSCrGtRwGClJ3t8h4F4iGA0lFatPcBGP/lJSIOIL4JrQNSmCVt8ZvLLYRK/nhiduspO6gFyovyAQ0Hl20egNtVBxW1qKZoQ==; 20:b3hclQVfgoAL6r7vqYMxNkwZ9PRWWTRK4TVQjsJ3qBp2VHAi74djk8A246ptYXfKNI9kbMwqJd8dsCcgf7RoHuWnj1TPOfgwHEDbZqnYLVC8P40/mS4XHcYNGbV6ajTB8mkiQpsM1T7pyM0vzFsZyCHwN39ISYk6M+VDQvN26lk= X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2017 18:40:55.1356 (UTC) X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=b61c8803-16f3-4c35-9b17-6f65f441df86; Ip=[63.163.107.21]; Helo=[milsmgep15.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR04MB391 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 04/10/2017 11:28 AM, Jens Axboe wrote: > On 03/30/2017 12:21 PM, Bart Van Assche wrote: >> This is a short patch series with one patch that exports the queue state >> and another patch that shows symbolic names for hctx state and flags >> instead of a numerical bitmask. >> >> Please consider these patches for kernel v4.12. > > Thanks, added for 4.12. Hello Jens, Thanks! This infrastructure was essential while analyzing queue stalls. After I had posted this series I improved and extended the blk-mq debugfs functionality further. Please consider including the patch below in v4.12. Thanks, Bart. From: Bart Van Assche Subject: [PATCH] blk-mq: Two fixes for the code that exports the queue state Remove the array entry for QUEUE_FLAG_RESTART since that flag has been removed after the blk-mq-debugfs patch that introduced this array entry was posted. Avoid that querying the queue state of a dead queue triggers a kernel crash. Signed-off-by: Bart Van Assche --- block/blk-mq-debugfs.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c index 91d09f58a596..a1ce823578c7 100644 --- a/block/blk-mq-debugfs.c +++ b/block/blk-mq-debugfs.c @@ -92,7 +92,6 @@ static const char *const blk_queue_flag_name[] = { [QUEUE_FLAG_FLUSH_NQ] = "FLUSH_NQ", [QUEUE_FLAG_DAX] = "DAX", [QUEUE_FLAG_STATS] = "STATS", - [QUEUE_FLAG_RESTART] = "RESTART", [QUEUE_FLAG_POLL_STATS] = "POLL_STATS", [QUEUE_FLAG_REGISTERED] = "REGISTERED", }; @@ -112,6 +111,14 @@ static ssize_t blk_queue_flags_store(struct file *file, const char __user *ubuf, struct request_queue *q = file_inode(file)->i_private; char op[16] = { }, *s; + /* + * The debugfs attributes are removed after blk_cleanup_queue() has + * called blk_mq_free_queue(). Return if QUEUE_FLAG_DEAD has been set + * to avoid triggering a use-after-free. + */ + if (blk_queue_dead(q)) + return -ENOENT; + len = min(len, sizeof(op) - 1); if (copy_from_user(op, ubuf, len)) return -EFAULT;