| Message ID | 20170412171526.32393-2-l.stach@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Apr 12, 2017 at 07:15:26PM +0200, Lucas Stach wrote: > This adds support for the NLT Technologies NL192108AC18-02D > 15.6" LVDS FullHD TFT LCD panel, which can be supported > by the simple panel driver. > > Timings are taken from the preliminary datasheet, as a final > one is not yet available. > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > --- > .../display/panel/nlt,nl192108ac18-02d.txt | 7 ++++++ > drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++ > 2 files changed, 36 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/nlt,nl192108ac18-02d.txt > > diff --git a/Documentation/devicetree/bindings/display/panel/nlt,nl192108ac18-02d.txt b/Documentation/devicetree/bindings/display/panel/nlt,nl192108ac18-02d.txt > new file mode 100644 > index 000000000000..edc34fbd2131 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/nlt,nl192108ac18-02d.txt > @@ -0,0 +1,7 @@ > +NLT Technologies, Ltd. 15.6" FHD (1920x1080) LVDS TFT LCD panel > + > +Required properties: > +- compatible: should be "nlt,nl192108ac18-02d" Please define the power supply. Is power-supply used or are there multiple supplies? > + > +This binding is compatible with the simple-panel binding, which is specified > +in simple-panel.txt in this directory.
Hi Rob, Am Mittwoch, den 19.04.2017, 16:15 -0500 schrieb Rob Herring: > On Wed, Apr 12, 2017 at 07:15:26PM +0200, Lucas Stach wrote: > > This adds support for the NLT Technologies NL192108AC18-02D > > 15.6" LVDS FullHD TFT LCD panel, which can be supported > > by the simple panel driver. > > > > Timings are taken from the preliminary datasheet, as a final > > one is not yet available. > > > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > > --- > > .../display/panel/nlt,nl192108ac18-02d.txt | 7 ++++++ > > drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++ > > 2 files changed, 36 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/panel/nlt,nl192108ac18-02d.txt > > > > diff --git a/Documentation/devicetree/bindings/display/panel/nlt,nl192108ac18-02d.txt b/Documentation/devicetree/bindings/display/panel/nlt,nl192108ac18-02d.txt > > new file mode 100644 > > index 000000000000..edc34fbd2131 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/panel/nlt,nl192108ac18-02d.txt > > @@ -0,0 +1,7 @@ > > +NLT Technologies, Ltd. 15.6" FHD (1920x1080) LVDS TFT LCD panel > > + > > +Required properties: > > +- compatible: should be "nlt,nl192108ac18-02d" > > Please define the power supply. Is power-supply used or are there > multiple supplies? How would you like to have that done? I thought that the sentence below is clear enough that this panel uses the simple panel binding where the power-supply property is non-optional. To me it feels a bit redundant to say in this binding document that, yes this panel is compatible to the binding it claims to be compatible with. And yes, this panel has a single supply for the digital logic. > > + > > +This binding is compatible with the simple-panel binding, which is specified > > +in simple-panel.txt in this directory. Regards, Lucas
diff --git a/Documentation/devicetree/bindings/display/panel/nlt,nl192108ac18-02d.txt b/Documentation/devicetree/bindings/display/panel/nlt,nl192108ac18-02d.txt new file mode 100644 index 000000000000..edc34fbd2131 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/nlt,nl192108ac18-02d.txt @@ -0,0 +1,7 @@ +NLT Technologies, Ltd. 15.6" FHD (1920x1080) LVDS TFT LCD panel + +Required properties: +- compatible: should be "nlt,nl192108ac18-02d" + +This binding is compatible with the simple-panel binding, which is specified +in simple-panel.txt in this directory. diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 89eb0422821c..888c3a22dcd9 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1346,6 +1346,32 @@ static const struct panel_desc netron_dy_e231732 = { .bus_format = MEDIA_BUS_FMT_RGB666_1X18, }; +static const struct display_timing nlt_nl192108ac18_02d_timing = { + .pixelclock = { 130000000, 148350000, 163000000 }, + .hactive = { 1920, 1920, 1920 }, + .hfront_porch = { 80, 100, 100 }, + .hback_porch = { 100, 120, 120 }, + .hsync_len = { 50, 60, 60 }, + .vactive = { 1080, 1080, 1080 }, + .vfront_porch = { 12, 30, 30 }, + .vback_porch = { 4, 10, 10 }, + .vsync_len = { 4, 5, 5 }, +}; + +static const struct panel_desc nlt_nl192108ac18_02d = { + .timings = &nlt_nl192108ac18_02d_timing, + .num_timings = 1, + .bpc = 8, + .size = { + .width = 344, + .height = 194, + }, + .delay = { + .unprepare = 500, + }, + .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG, +}; + static const struct drm_display_mode nvd_9128_mode = { .clock = 29500, .hdisplay = 800, @@ -1925,6 +1951,9 @@ static const struct of_device_id platform_of_match[] = { .compatible = "netron-dy,e231732", .data = &netron_dy_e231732, }, { + .compatible = "nlt,nl192108ac18-02d", + .data = &nlt_nl192108ac18_02d, + }, { .compatible = "nvd,9128", .data = &nvd_9128, }, {
This adds support for the NLT Technologies NL192108AC18-02D 15.6" LVDS FullHD TFT LCD panel, which can be supported by the simple panel driver. Timings are taken from the preliminary datasheet, as a final one is not yet available. Signed-off-by: Lucas Stach <l.stach@pengutronix.de> --- .../display/panel/nlt,nl192108ac18-02d.txt | 7 ++++++ drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++ 2 files changed, 36 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/nlt,nl192108ac18-02d.txt