| Message ID | 20170413234923.GA38321@dtor-ws (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 2017-04-14 01:49, Dmitry Torokhov wrote: > We should not be forcing edge triggered interrupt, but rather let platform > decide the kind of trigger it needs to use. Also, the driver is not quite > safe with regard to edge-triggered interrupts as it does not try to kick > the controller after requesting/enabling IRQ. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > --- > drivers/input/touchscreen/ar1021_i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/ar1021_i2c.c b/drivers/input/touchscreen/ar1021_i2c.c > index 6797e123925a..6c3c79b7ff51 100644 > --- a/drivers/input/touchscreen/ar1021_i2c.c > +++ b/drivers/input/touchscreen/ar1021_i2c.c > @@ -109,7 +109,7 @@ static int ar1021_i2c_probe(struct i2c_client *client, > > error = devm_request_threaded_irq(&client->dev, client->irq, > NULL, ar1021_i2c_irq, > - IRQF_TRIGGER_RISING | IRQF_ONESHOT, > + IRQF_ONESHOT, > "ar1021_i2c", ar1021); > if (error) { > dev_err(&client->dev, > makes sense, if users have to expect that this default can change. it works. Tested-by: Martin Kepplinger <martin.kepplinger@ginzinger.com> martin -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
2017-04-14 1:49 GMT+02:00 Dmitry Torokhov <dmitry.torokhov@gmail.com>: > We should not be forcing edge triggered interrupt, but rather let platform > decide the kind of trigger it needs to use. Also, the driver is not quite > safe with regard to edge-triggered interrupts as it does not try to kick > the controller after requesting/enabling IRQ. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Reviewed-By: Christian Gmeiner <christian.gmeiner@gmail.com> greets -- Christian Gmeiner, MSc https://www.youtube.com/user/AloryOFFICIAL https://soundcloud.com/christian-gmeiner -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 13 Apr 2017 16:49:23 -0700, Dmitry Torokhov wrote: > We should not be forcing edge triggered interrupt, but rather let platform > decide the kind of trigger it needs to use. Also, the driver is not quite > safe with regard to edge-triggered interrupts as it does not try to kick > the controller after requesting/enabling IRQ. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > --- > drivers/input/touchscreen/ar1021_i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/ar1021_i2c.c b/drivers/input/touchscreen/ar1021_i2c.c > index 6797e123925a..6c3c79b7ff51 100644 > --- a/drivers/input/touchscreen/ar1021_i2c.c > +++ b/drivers/input/touchscreen/ar1021_i2c.c > @@ -109,7 +109,7 @@ static int ar1021_i2c_probe(struct i2c_client *client, > > error = devm_request_threaded_irq(&client->dev, client->irq, > NULL, ar1021_i2c_irq, > - IRQF_TRIGGER_RISING | IRQF_ONESHOT, > + IRQF_ONESHOT, > "ar1021_i2c", ar1021); > if (error) { > dev_err(&client->dev, Acked-by: Jean Delvare <jdelvare@suse.de>
diff --git a/drivers/input/touchscreen/ar1021_i2c.c b/drivers/input/touchscreen/ar1021_i2c.c index 6797e123925a..6c3c79b7ff51 100644 --- a/drivers/input/touchscreen/ar1021_i2c.c +++ b/drivers/input/touchscreen/ar1021_i2c.c @@ -109,7 +109,7 @@ static int ar1021_i2c_probe(struct i2c_client *client, error = devm_request_threaded_irq(&client->dev, client->irq, NULL, ar1021_i2c_irq, - IRQF_TRIGGER_RISING | IRQF_ONESHOT, + IRQF_ONESHOT, "ar1021_i2c", ar1021); if (error) { dev_err(&client->dev,
We should not be forcing edge triggered interrupt, but rather let platform decide the kind of trigger it needs to use. Also, the driver is not quite safe with regard to edge-triggered interrupts as it does not try to kick the controller after requesting/enabling IRQ. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- drivers/input/touchscreen/ar1021_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)