diff mbox

generic: fix statx definition for non-x86 architecture

Message ID 20170419235453.8237-1-gwendal@chromium.org (mailing list archive)
State New, archived
Headers show

Commit Message

Gwendal Grignou April 19, 2017, 11:54 p.m. UTC
Fix a compilation error for ARM:
__ILP32__ is defined but not __X32_SYSCALL_BIT.

The check should only apply for x86_64 architecture, statx for other
architectures is not implemented yet - see commit 7acc839c9e57
"statx: Add a system call to make enhanced file info available".

Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
---
 src/statx.h | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

Comments

Eric Sandeen April 20, 2017, 12:27 a.m. UTC | #1
On 4/19/17 6:54 PM, Gwendal Grignou wrote:
> Fix a compilation error for ARM:
> __ILP32__ is defined but not __X32_SYSCALL_BIT.
> 
> The check should only apply for x86_64 architecture, statx for other
> architectures is not implemented yet - see commit 7acc839c9e57
> "statx: Add a system call to make enhanced file info available".
> 
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

probably needs fixing in xfs_io too, thanks.

-Eric

> ---
>  src/statx.h | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/src/statx.h b/src/statx.h
> index b491c018..5d58208a 100644
> --- a/src/statx.h
> +++ b/src/statx.h
> @@ -19,10 +19,12 @@
>  #ifndef __NR_statx
>  # ifdef __i386__
>  #  define __NR_statx 383
> -# elif defined (__ILP32__)
> -#  define __NR_statx (__X32_SYSCALL_BIT + 332)
>  # elif defined(__x86_64__)
> -#  define __NR_statx 332
> +#  if defined (__ILP32__)
> +#   define __NR_statx (__X32_SYSCALL_BIT + 332)
> +#  else
> +#   define __NR_statx 332
> +#  endif
>  # endif
>  #endif
>  
> 
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/src/statx.h b/src/statx.h
index b491c018..5d58208a 100644
--- a/src/statx.h
+++ b/src/statx.h
@@ -19,10 +19,12 @@ 
 #ifndef __NR_statx
 # ifdef __i386__
 #  define __NR_statx 383
-# elif defined (__ILP32__)
-#  define __NR_statx (__X32_SYSCALL_BIT + 332)
 # elif defined(__x86_64__)
-#  define __NR_statx 332
+#  if defined (__ILP32__)
+#   define __NR_statx (__X32_SYSCALL_BIT + 332)
+#  else
+#   define __NR_statx 332
+#  endif
 # endif
 #endif