x86/intel_idle: add GLK support
diff mbox

Message ID 20170423060625.4593-1-david.e.box@linux.intel.com
State Mainlined
Delegated to: Rafael Wysocki
Headers show

Commit Message

David E. Box April 23, 2017, 6:06 a.m. UTC
From: "Box, David E" <david.e.box@intel.com>

Gemini Lake uses the same C-states as Broxton and also uses the
IRTL MSR's to determine maximum C-state latency.

Signed-off-by: David E. Box <david.e.box@linux.intel.com>
---
 drivers/idle/intel_idle.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Rafael J. Wysocki April 26, 2017, 10:36 p.m. UTC | #1
On Saturday, April 22, 2017 11:06:25 PM David E. Box wrote:
> From: "Box, David E" <david.e.box@intel.com>
> 
> Gemini Lake uses the same C-states as Broxton and also uses the
> IRTL MSR's to determine maximum C-state latency.
> 
> Signed-off-by: David E. Box <david.e.box@linux.intel.com>

You could use the code names consistently in your subjects (but I can fix this up).

Jacob, any concerns?

> ---
>  drivers/idle/intel_idle.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
> index e045a5c..778af71 100644
> --- a/drivers/idle/intel_idle.c
> +++ b/drivers/idle/intel_idle.c
> @@ -1097,6 +1097,7 @@ static const struct x86_cpu_id intel_idle_ids[] __initconst = {
>  	ICPU(INTEL_FAM6_XEON_PHI_KNL,		idle_cpu_knl),
>  	ICPU(INTEL_FAM6_XEON_PHI_KNM,		idle_cpu_knl),
>  	ICPU(INTEL_FAM6_ATOM_GOLDMONT,		idle_cpu_bxt),
> +	ICPU(INTEL_FAM6_ATOM_GEMINI_LAKE,	idle_cpu_bxt),
>  	ICPU(INTEL_FAM6_ATOM_DENVERTON,		idle_cpu_dnv),
>  	{}
>  };
> @@ -1309,6 +1310,7 @@ static void intel_idle_state_table_update(void)
>  		ivt_idle_state_table_update();
>  		break;
>  	case INTEL_FAM6_ATOM_GOLDMONT:
> +	case INTEL_FAM6_ATOM_GEMINI_LAKE:
>  		bxt_idle_state_table_update();
>  		break;
>  	case INTEL_FAM6_SKYLAKE_DESKTOP:
>
Len Brown April 29, 2017, 3:56 a.m. UTC | #2
Acked-by: Len Brown <len.brown@intel.com>

On Sun, Apr 23, 2017 at 2:06 AM, David E. Box
<david.e.box@linux.intel.com> wrote:
> From: "Box, David E" <david.e.box@intel.com>
>
> Gemini Lake uses the same C-states as Broxton and also uses the
> IRTL MSR's to determine maximum C-state latency.
>
> Signed-off-by: David E. Box <david.e.box@linux.intel.com>
> ---
>  drivers/idle/intel_idle.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
> index e045a5c..778af71 100644
> --- a/drivers/idle/intel_idle.c
> +++ b/drivers/idle/intel_idle.c
> @@ -1097,6 +1097,7 @@ static const struct x86_cpu_id intel_idle_ids[] __initconst = {
>         ICPU(INTEL_FAM6_XEON_PHI_KNL,           idle_cpu_knl),
>         ICPU(INTEL_FAM6_XEON_PHI_KNM,           idle_cpu_knl),
>         ICPU(INTEL_FAM6_ATOM_GOLDMONT,          idle_cpu_bxt),
> +       ICPU(INTEL_FAM6_ATOM_GEMINI_LAKE,       idle_cpu_bxt),
>         ICPU(INTEL_FAM6_ATOM_DENVERTON,         idle_cpu_dnv),
>         {}
>  };
> @@ -1309,6 +1310,7 @@ static void intel_idle_state_table_update(void)
>                 ivt_idle_state_table_update();
>                 break;
>         case INTEL_FAM6_ATOM_GOLDMONT:
> +       case INTEL_FAM6_ATOM_GEMINI_LAKE:
>                 bxt_idle_state_table_update();
>                 break;
>         case INTEL_FAM6_SKYLAKE_DESKTOP:
> --
> 2.9.3
>
Jacob Pan May 4, 2017, 11:35 p.m. UTC | #3
On Thu, 27 Apr 2017 00:36:42 +0200
"Rafael J. Wysocki" <rjw@rjwysocki.net> wrote:

> > From: "Box, David E" <david.e.box@intel.com>
> > 
> > Gemini Lake uses the same C-states as Broxton and also uses the
> > IRTL MSR's to determine maximum C-state latency.
> > 
> > Signed-off-by: David E. Box <david.e.box@linux.intel.com>  
> 
> You could use the code names consistently in your subjects (but I can
> fix this up).
> 
> Jacob, any concerns?

No. Sorry for the delay.
Acked-by: Pan, Jacob jun <jacob.jun.pan@intel.com>

Patch
diff mbox

diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
index e045a5c..778af71 100644
--- a/drivers/idle/intel_idle.c
+++ b/drivers/idle/intel_idle.c
@@ -1097,6 +1097,7 @@  static const struct x86_cpu_id intel_idle_ids[] __initconst = {
 	ICPU(INTEL_FAM6_XEON_PHI_KNL,		idle_cpu_knl),
 	ICPU(INTEL_FAM6_XEON_PHI_KNM,		idle_cpu_knl),
 	ICPU(INTEL_FAM6_ATOM_GOLDMONT,		idle_cpu_bxt),
+	ICPU(INTEL_FAM6_ATOM_GEMINI_LAKE,	idle_cpu_bxt),
 	ICPU(INTEL_FAM6_ATOM_DENVERTON,		idle_cpu_dnv),
 	{}
 };
@@ -1309,6 +1310,7 @@  static void intel_idle_state_table_update(void)
 		ivt_idle_state_table_update();
 		break;
 	case INTEL_FAM6_ATOM_GOLDMONT:
+	case INTEL_FAM6_ATOM_GEMINI_LAKE:
 		bxt_idle_state_table_update();
 		break;
 	case INTEL_FAM6_SKYLAKE_DESKTOP: