Patchwork drm/atomic: fix doc to use new name for commit types

login
register
mail settings
Submitter Gustavo F. Padovan
Date April 27, 2017, 2:35 p.m.
Message ID <20170427143506.32650-1-gustavo@padovan.org>
Download mbox | patch
Permalink /patch/9702949/
State New
Headers show

Comments

Gustavo F. Padovan - April 27, 2017, 2:35 p.m.
From: Gustavo Padovan <gustavo.padovan@collabora.com>

Use "non-blocking" and "blocking" instead of old names.

Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
---
 drivers/gpu/drm/drm_atomic_helper.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Daniel Vetter - May 2, 2017, 9:19 a.m.
On Thu, Apr 27, 2017 at 11:35:06AM -0300, Gustavo Padovan wrote:
> From: Gustavo Padovan <gustavo.padovan@collabora.com>
> 
> Use "non-blocking" and "blocking" instead of old names.
> 
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

> ---
>  drivers/gpu/drm/drm_atomic_helper.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c
> index cfeda5f..5a3c9c0 100644
> --- a/drivers/gpu/drm/drm_atomic_helper.c
> +++ b/drivers/gpu/drm/drm_atomic_helper.c
> @@ -1070,8 +1070,8 @@ EXPORT_SYMBOL(drm_atomic_helper_commit_modeset_enables);
>   *
>   * Note that @pre_swap is needed since the point where we block for fences moves
>   * around depending upon whether an atomic commit is blocking or
> - * non-blocking. For async commit all waiting needs to happen after
> - * drm_atomic_helper_swap_state() is called, but for synchronous commits we want
> + * non-blocking. For non-blocking commit all waiting needs to happen after
> + * drm_atomic_helper_swap_state() is called, but for blocking commits we want
>   * to wait **before** we do anything that can't be easily rolled back. That is
>   * before we call drm_atomic_helper_swap_state().
>   *
> -- 
> 2.9.3
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Gustavo F. Padovan - May 3, 2017, 3:14 p.m.
2017-05-02 Daniel Vetter <daniel@ffwll.ch>:

> On Thu, Apr 27, 2017 at 11:35:06AM -0300, Gustavo Padovan wrote:
> > From: Gustavo Padovan <gustavo.padovan@collabora.com>
> > 
> > Use "non-blocking" and "blocking" instead of old names.
> > 
> > Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
> 
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Thanks for the review. Pushed to drm-misc-next.

Gustavo

Patch

diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c
index cfeda5f..5a3c9c0 100644
--- a/drivers/gpu/drm/drm_atomic_helper.c
+++ b/drivers/gpu/drm/drm_atomic_helper.c
@@ -1070,8 +1070,8 @@  EXPORT_SYMBOL(drm_atomic_helper_commit_modeset_enables);
  *
  * Note that @pre_swap is needed since the point where we block for fences moves
  * around depending upon whether an atomic commit is blocking or
- * non-blocking. For async commit all waiting needs to happen after
- * drm_atomic_helper_swap_state() is called, but for synchronous commits we want
+ * non-blocking. For non-blocking commit all waiting needs to happen after
+ * drm_atomic_helper_swap_state() is called, but for blocking commits we want
  * to wait **before** we do anything that can't be easily rolled back. That is
  * before we call drm_atomic_helper_swap_state().
  *