target: fixup error message in target_tg_pt_gp_alua_access_type_store()
diff mbox

Message ID 1493366618-8460-1-git-send-email-hare@suse.de
State New, archived
Headers show

Commit Message

Hannes Reinecke April 28, 2017, 8:03 a.m. UTC
When setting up a target the error message:

Unable to do set ##_name ALUA state on non valid tg_pt_gp ID: 0

is displayed.
Apparently concatenation doesn't work in a string; one should be using
implicit string concatenation here.

Signed-off-by: Hannes Reinecke <hare@suse.com>
Reviewed-by: Bart van Assche <bart.vanassche@sandisk.com>
---
 drivers/target/target_core_configfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Nicholas A. Bellinger May 2, 2017, 5:16 a.m. UTC | #1
On Fri, 2017-04-28 at 10:03 +0200, Hannes Reinecke wrote:
> When setting up a target the error message:
> 
> Unable to do set ##_name ALUA state on non valid tg_pt_gp ID: 0
> 
> is displayed.
> Apparently concatenation doesn't work in a string; one should be using
> implicit string concatenation here.
> 
> Signed-off-by: Hannes Reinecke <hare@suse.com>
> Reviewed-by: Bart van Assche <bart.vanassche@sandisk.com>
> ---
>  drivers/target/target_core_configfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied.

Thanks Hannes.

--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
index 54b36c9..e8850ae 100644
--- a/drivers/target/target_core_configfs.c
+++ b/drivers/target/target_core_configfs.c
@@ -2507,7 +2507,7 @@  static ssize_t target_tg_pt_gp_alua_access_type_store(struct config_item *item,
 	int ret;							\
 									\
 	if (!t->tg_pt_gp_valid_id) {					\
-		pr_err("Unable to do set ##_name ALUA state on non"	\
+		pr_err("Unable to do set " #_name " ALUA state on non"	\
 		       " valid tg_pt_gp ID: %hu\n",			\
 		       t->tg_pt_gp_valid_id);				\
 		return -EINVAL;						\