| Message ID | 20170430193853.10958-1-martink@posteo.de (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Sun, Apr 30, 2017 at 09:38:53PM +0200, Martin Kepplinger wrote: > The MSB for the first byte of touch data transmission is always 1. Make > it a little more obvious we're testing this bit by using BIT(7). > > Signed-off-by: Martin Kepplinger <martink@posteo.de> Applied, thank you. > --- > > I'd still use the definition :) but otherwise I'd write the following. > It really doesn't matter though. > > thanks for the quick support Dmitry, > > martin > > > drivers/input/touchscreen/ar1021_i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/ar1021_i2c.c b/drivers/input/touchscreen/ar1021_i2c.c > index eb1874fe52c2..8c76aa435903 100644 > --- a/drivers/input/touchscreen/ar1021_i2c.c > +++ b/drivers/input/touchscreen/ar1021_i2c.c > @@ -44,7 +44,7 @@ static irqreturn_t ar1021_i2c_irq(int irq, void *dev_id) > goto out; > > /* sync bit set ? */ > - if ((data[0] & 0x80) == 0) > + if (!(data[0] & BIT(7))) > goto out; > > button = data[0] & BIT(0); > -- > 2.11.0 >
diff --git a/drivers/input/touchscreen/ar1021_i2c.c b/drivers/input/touchscreen/ar1021_i2c.c index eb1874fe52c2..8c76aa435903 100644 --- a/drivers/input/touchscreen/ar1021_i2c.c +++ b/drivers/input/touchscreen/ar1021_i2c.c @@ -44,7 +44,7 @@ static irqreturn_t ar1021_i2c_irq(int irq, void *dev_id) goto out; /* sync bit set ? */ - if ((data[0] & 0x80) == 0) + if (!(data[0] & BIT(7))) goto out; button = data[0] & BIT(0);
The MSB for the first byte of touch data transmission is always 1. Make it a little more obvious we're testing this bit by using BIT(7). Signed-off-by: Martin Kepplinger <martink@posteo.de> --- I'd still use the definition :) but otherwise I'd write the following. It really doesn't matter though. thanks for the quick support Dmitry, martin drivers/input/touchscreen/ar1021_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)