| Message ID | 149365468723.12922.7216057583221400867.stgit@zeus.hardeman.nu (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, May 01, 2017 at 06:04:47PM +0200, David Härdeman wrote: > Remove superfluous includes and defines. > > Signed-off-by: David Härdeman <david@hardeman.nu> > --- > drivers/media/rc/lirc_dev.c | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) > > diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c > index 7db7d4c57991..4ba6c7e2d41b 100644 > --- a/drivers/media/rc/lirc_dev.c > +++ b/drivers/media/rc/lirc_dev.c > @@ -15,20 +15,11 @@ > * > */ > > -#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > - > #include <linux/module.h> > -#include <linux/kernel.h> > #include <linux/sched/signal.h> > -#include <linux/errno.h> > #include <linux/ioctl.h> > -#include <linux/fs.h> > #include <linux/poll.h> > -#include <linux/completion.h> > #include <linux/mutex.h> > -#include <linux/wait.h> > -#include <linux/unistd.h> > -#include <linux/bitops.h> > #include <linux/device.h> > #include <linux/cdev.h> > #include <linux/idr.h> > @@ -37,7 +28,6 @@ > #include <media/lirc.h> > #include <media/lirc_dev.h> > > -#define IRCTL_DEV_NAME "BaseRemoteCtl" > #define LOGHEAD "lirc_dev (%s[%d]): " > > static dev_t lirc_base_dev; > @@ -545,7 +535,7 @@ static int __init lirc_dev_init(void) > } > > retval = alloc_chrdev_region(&lirc_base_dev, 0, LIRC_MAX_DEVICES, > - IRCTL_DEV_NAME); > + "BaseRemoteCtl"); This has always surprised/annoyed me. Why is this called BaseRemoteCtl? As far as I know, this is only used for /proc/devices, where it says: $ grep 239 /proc/devices 239 BaseRemoteCtl And not lirc, as you would expect. Sean
On Fri, May 19, 2017 at 07:21:23PM +0100, Sean Young wrote: >On Mon, May 01, 2017 at 06:04:47PM +0200, David Härdeman wrote: >> Remove superfluous includes and defines. >> >> Signed-off-by: David Härdeman <david@hardeman.nu> >> --- >> drivers/media/rc/lirc_dev.c | 12 +----------- >> 1 file changed, 1 insertion(+), 11 deletions(-) >> >> diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c >> index 7db7d4c57991..4ba6c7e2d41b 100644 >> --- a/drivers/media/rc/lirc_dev.c >> +++ b/drivers/media/rc/lirc_dev.c >> @@ -15,20 +15,11 @@ >> * >> */ >> >> -#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt >> - >> #include <linux/module.h> >> -#include <linux/kernel.h> >> #include <linux/sched/signal.h> >> -#include <linux/errno.h> >> #include <linux/ioctl.h> >> -#include <linux/fs.h> >> #include <linux/poll.h> >> -#include <linux/completion.h> >> #include <linux/mutex.h> >> -#include <linux/wait.h> >> -#include <linux/unistd.h> >> -#include <linux/bitops.h> >> #include <linux/device.h> >> #include <linux/cdev.h> >> #include <linux/idr.h> >> @@ -37,7 +28,6 @@ >> #include <media/lirc.h> >> #include <media/lirc_dev.h> >> >> -#define IRCTL_DEV_NAME "BaseRemoteCtl" >> #define LOGHEAD "lirc_dev (%s[%d]): " >> >> static dev_t lirc_base_dev; >> @@ -545,7 +535,7 @@ static int __init lirc_dev_init(void) >> } >> >> retval = alloc_chrdev_region(&lirc_base_dev, 0, LIRC_MAX_DEVICES, >> - IRCTL_DEV_NAME); >> + "BaseRemoteCtl"); > >This has always surprised/annoyed me. Why is this called BaseRemoteCtl? As >far as I know, this is only used for /proc/devices, where it says: > >$ grep 239 /proc/devices >239 BaseRemoteCtl > >And not lirc, as you would expect. Yeah, I also find it a bit of an ugly wart. I didn't dare to change it though since userspace might rely on "BaseRemoteCtl". For example: https://build.opensuse.org/package/view_file/openSUSE:12.2/lirc/rc.lirc?expand=1)
diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c index 7db7d4c57991..4ba6c7e2d41b 100644 --- a/drivers/media/rc/lirc_dev.c +++ b/drivers/media/rc/lirc_dev.c @@ -15,20 +15,11 @@ * */ -#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt - #include <linux/module.h> -#include <linux/kernel.h> #include <linux/sched/signal.h> -#include <linux/errno.h> #include <linux/ioctl.h> -#include <linux/fs.h> #include <linux/poll.h> -#include <linux/completion.h> #include <linux/mutex.h> -#include <linux/wait.h> -#include <linux/unistd.h> -#include <linux/bitops.h> #include <linux/device.h> #include <linux/cdev.h> #include <linux/idr.h> @@ -37,7 +28,6 @@ #include <media/lirc.h> #include <media/lirc_dev.h> -#define IRCTL_DEV_NAME "BaseRemoteCtl" #define LOGHEAD "lirc_dev (%s[%d]): " static dev_t lirc_base_dev; @@ -545,7 +535,7 @@ static int __init lirc_dev_init(void) } retval = alloc_chrdev_region(&lirc_base_dev, 0, LIRC_MAX_DEVICES, - IRCTL_DEV_NAME); + "BaseRemoteCtl"); if (retval) { class_destroy(lirc_class); pr_err("alloc_chrdev_region failed\n");
Remove superfluous includes and defines. Signed-off-by: David Härdeman <david@hardeman.nu> --- drivers/media/rc/lirc_dev.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-)