[RFC] btrfs: clean up qgroup trace event
diff mbox

Message ID 20170504140411.26723-1-anand.jain@oracle.com
State New
Headers show

Commit Message

Anand Jain May 4, 2017, 2:04 p.m. UTC
Hi Qu,

The commit 81fb6f77a026 (btrfs: qgroup: Add new trace point for
qgroup data reserve) added the following events which aren't used.
  btrfs__qgroup_data_map
  btrfs_qgroup_init_data_rsv_map
  btrfs_qgroup_free_data_rsv_map
I wonder if it is better to remove or keep it for future use.

Signed-off-by: Anand Jain <anand.jain@oracle.com>
cc: quwenruo@cn.fujitsu.com
---
 include/trace/events/btrfs.h | 36 ------------------------------------
 1 file changed, 36 deletions(-)

Comments

Qu Wenruo May 5, 2017, 12:31 a.m. UTC | #1
At 05/04/2017 10:04 PM, Anand Jain wrote:
> Hi Qu,
> 
> The commit 81fb6f77a026 (btrfs: qgroup: Add new trace point for
> qgroup data reserve) added the following events which aren't used.
>    btrfs__qgroup_data_map
>    btrfs_qgroup_init_data_rsv_map
>    btrfs_qgroup_free_data_rsv_map
> I wonder if it is better to remove or keep it for future use.

Please remove them.

These 2 old tracepoints are never used due to later patch split.
Some of the old caller doesn't ever exist.

Reviewed-by: Qu Wenruo <quwenruo@cn.fujitsu.com>

Thanks for catching this,
Qu

> 
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> cc: quwenruo@cn.fujitsu.com
> ---
>   include/trace/events/btrfs.h | 36 ------------------------------------
>   1 file changed, 36 deletions(-)
> 
> diff --git a/include/trace/events/btrfs.h b/include/trace/events/btrfs.h
> index a3c3cab643a9..5471f9b4dc9e 100644
> --- a/include/trace/events/btrfs.h
> +++ b/include/trace/events/btrfs.h
> @@ -1270,42 +1270,6 @@ DEFINE_EVENT(btrfs__workqueue_done, btrfs_workqueue_destroy,
>   	TP_ARGS(wq)
>   );
>   
> -DECLARE_EVENT_CLASS(btrfs__qgroup_data_map,
> -
> -	TP_PROTO(struct inode *inode, u64 free_reserved),
> -
> -	TP_ARGS(inode, free_reserved),
> -
> -	TP_STRUCT__entry_btrfs(
> -		__field(	u64,		rootid		)
> -		__field(	unsigned long,	ino		)
> -		__field(	u64,		free_reserved	)
> -	),
> -
> -	TP_fast_assign_btrfs(btrfs_sb(inode->i_sb),
> -		__entry->rootid		=	BTRFS_I(inode)->root->objectid;
> -		__entry->ino		=	inode->i_ino;
> -		__entry->free_reserved	=	free_reserved;
> -	),
> -
> -	TP_printk_btrfs("rootid=%llu ino=%lu free_reserved=%llu",
> -		  __entry->rootid, __entry->ino, __entry->free_reserved)
> -);
> -
> -DEFINE_EVENT(btrfs__qgroup_data_map, btrfs_qgroup_init_data_rsv_map,
> -
> -	TP_PROTO(struct inode *inode, u64 free_reserved),
> -
> -	TP_ARGS(inode, free_reserved)
> -);
> -
> -DEFINE_EVENT(btrfs__qgroup_data_map, btrfs_qgroup_free_data_rsv_map,
> -
> -	TP_PROTO(struct inode *inode, u64 free_reserved),
> -
> -	TP_ARGS(inode, free_reserved)
> -);
> -
>   #define BTRFS_QGROUP_OPERATIONS				\
>   	{ QGROUP_RESERVE,	"reserve"	},	\
>   	{ QGROUP_RELEASE,	"release"	},	\
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/include/trace/events/btrfs.h b/include/trace/events/btrfs.h
index a3c3cab643a9..5471f9b4dc9e 100644
--- a/include/trace/events/btrfs.h
+++ b/include/trace/events/btrfs.h
@@ -1270,42 +1270,6 @@  DEFINE_EVENT(btrfs__workqueue_done, btrfs_workqueue_destroy,
 	TP_ARGS(wq)
 );
 
-DECLARE_EVENT_CLASS(btrfs__qgroup_data_map,
-
-	TP_PROTO(struct inode *inode, u64 free_reserved),
-
-	TP_ARGS(inode, free_reserved),
-
-	TP_STRUCT__entry_btrfs(
-		__field(	u64,		rootid		)
-		__field(	unsigned long,	ino		)
-		__field(	u64,		free_reserved	)
-	),
-
-	TP_fast_assign_btrfs(btrfs_sb(inode->i_sb),
-		__entry->rootid		=	BTRFS_I(inode)->root->objectid;
-		__entry->ino		=	inode->i_ino;
-		__entry->free_reserved	=	free_reserved;
-	),
-
-	TP_printk_btrfs("rootid=%llu ino=%lu free_reserved=%llu",
-		  __entry->rootid, __entry->ino, __entry->free_reserved)
-);
-
-DEFINE_EVENT(btrfs__qgroup_data_map, btrfs_qgroup_init_data_rsv_map,
-
-	TP_PROTO(struct inode *inode, u64 free_reserved),
-
-	TP_ARGS(inode, free_reserved)
-);
-
-DEFINE_EVENT(btrfs__qgroup_data_map, btrfs_qgroup_free_data_rsv_map,
-
-	TP_PROTO(struct inode *inode, u64 free_reserved),
-
-	TP_ARGS(inode, free_reserved)
-);
-
 #define BTRFS_QGROUP_OPERATIONS				\
 	{ QGROUP_RESERVE,	"reserve"	},	\
 	{ QGROUP_RELEASE,	"release"	},	\