| Message ID | 87r303opcw.fsf@notabene.neil.brown.name (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | Mike Snitzer |
| Headers | show |
On 05/05/2017 01:16 AM, NeilBrown wrote: > > As pointed out by Peter Rajnoha, the correct usage in udev is > TEST=="file", not TEST="file". > > Also improve a related comment which was a bit informal. > > Reported-by: Peter Rajnoha <prajnoha@redhat.com> > Fixes: cd6cbb08c458 ("Create: tell udev md device is not ready when first created.") > Signed-off-by: NeilBrown <neilb@suse.com> > --- > > Thanks Peter! Properly tested as well :-) > > NeilBrown Applied! Thanks both of you! Jes -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel
diff --git a/lib.c b/lib.c index 7e44b1f27fcc..be093e8c30cb 100644 --- a/lib.c +++ b/lib.c @@ -165,7 +165,7 @@ char *fd2devnm(int fd) /* When we create a new array, we don't want the content to * be immediately examined by udev - it is probably meaningless. - * So create /run/mdadm/creating-FOO and expect that a udev + * So create /run/mdadm/creating-mdXXX and expect that a udev * rule will noticed this and act accordingly. */ static char block_path[] = "/run/mdadm/creating-%s"; diff --git a/udev-md-raid-creating.rules b/udev-md-raid-creating.rules index 2be466bcefd2..9bef8d1103f5 100644 --- a/udev-md-raid-creating.rules +++ b/udev-md-raid-creating.rules @@ -4,4 +4,4 @@ # the array is not "ready" and we should make sure the # content is ignored. -KERNEL=="md*", TEST="/run/mdadm/creating-$kernel", ENV{SYSTEMD_READY}="0" +KERNEL=="md*", TEST=="/run/mdadm/creating-$kernel", ENV{SYSTEMD_READY}="0"
As pointed out by Peter Rajnoha, the correct usage in udev is TEST=="file", not TEST="file". Also improve a related comment which was a bit informal. Reported-by: Peter Rajnoha <prajnoha@redhat.com> Fixes: cd6cbb08c458 ("Create: tell udev md device is not ready when first created.") Signed-off-by: NeilBrown <neilb@suse.com> --- Thanks Peter! Properly tested as well :-) NeilBrown lib.c | 2 +- udev-md-raid-creating.rules | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)