[02/10] policycoreutils: fixfiles: remove two unused variables
diff mbox

Message ID 20170507110556.7740-2-alan.christopher.jenkins@gmail.com
State Not Applicable
Headers show

Commit Message

Alan Jenkins May 7, 2017, 11:05 a.m. UTC
DIRS was suspicious because you can't store file names in a normal variable,
and it's not that common to use arrays in bash.  It's not actually used.

While we're here, there's another variable which is never used
and should just be removed.  (Pointed out by `shellcheck`.
It makes a couple of other points too, but I have more specific
patches I want to put those in).
---
 policycoreutils/scripts/fixfiles | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Patch
diff mbox

diff --git a/policycoreutils/scripts/fixfiles b/policycoreutils/scripts/fixfiles
index e416dfc..da79f47 100755
--- a/policycoreutils/scripts/fixfiles
+++ b/policycoreutils/scripts/fixfiles
@@ -107,13 +107,11 @@  fullFlag=0
 BOOTTIME=""
 VERBOSE="-p"
 FORCEFLAG=""
-DIRS=""
 RPMILES=""
 SETFILES=/sbin/setfiles
 RESTORECON=/sbin/restorecon
 FILESYSTEMSRW=`get_rw_labeled_mounts`
 FILESYSTEMSRO=`get_ro_labeled_mounts`
-FILESYSTEMS="$FILESYSTEMSRW $FILESYSTEMSRO"
 SELINUXTYPE="targeted"
 if [ -e /etc/selinux/config ]; then
     . /etc/selinux/config
@@ -373,7 +371,7 @@  fi
 shift
 
 #
-# check if they specified both DIRS and RPMFILES
+# check if they specified both RPMFILES and FILEPATHs
 #
 
 if [ ! -z "$RPMFILES" ]; then