From patchwork Mon May 8 02:10:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?5oi05ZGo?= X-Patchwork-Id: 9715697 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E341760234 for ; Mon, 8 May 2017 02:10:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BC9602818A for ; Mon, 8 May 2017 02:10:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9E8C4281E1; Mon, 8 May 2017 02:10:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 321082818A for ; Mon, 8 May 2017 02:10:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751398AbdEHCKT (ORCPT ); Sun, 7 May 2017 22:10:19 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:33614 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750943AbdEHCKS (ORCPT ); Sun, 7 May 2017 22:10:18 -0400 Received: by mail-pg0-f68.google.com with SMTP id s62so8449492pgc.0 for ; Sun, 07 May 2017 19:10:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=fa6rsR8OVwMNKc+a7NhKYMtQ8gLZAmerDatYejtY5wA=; b=MtCFRXblxhXZwenQWSWhlA2xQk0y0UIXDSnS0Qzip/ikMwgS+ziPlJ7MIMo0m4RHgo ZwaF+0dIqqRJFGPsawsG1ftkuAgpWIMMq8UYsHa6pmkeLUgc5qyHvoNrcyHCZz9NlrmO gHuYziHadoxm14kGEs/6IdtVwRboZlmYEC5Clq2a6pRCukt90Jxth8Y73oAO7xoQQTxg 9yuXYSYdn0/JLfMGhY0E/htlpPRygJ41kZbbeg5qsuSY8G5EIPNDiiXFN64QvB8v2PgW 9TEqZWlw96bgugF8TqDNPhN/k5foZCvgc9+mQKF/lBGgICL0yhaxv5k6y/q1htVS59y5 5Guw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=fa6rsR8OVwMNKc+a7NhKYMtQ8gLZAmerDatYejtY5wA=; b=t0PKHt170KuUjEZt5kZNFpt1pctL7Rj4uGJ1gSOfjAuBPRBPEwYpOnYX7qSNSiKKHq cmzHRORAH5puJtaetD2boh0/LFR6Lq8VrOrOPWc/HosnrvNCsBLE6IqCalLUV/GozH6Y Nfsslb5qrxeZEmmYQUAPJh3U3X7t/C/6aGKscnVTSPIBzAvduU/2lmo0CLRq9drNp8lc 96ZQXoIGxIEsPePyPvAjzbRy6YF5D9uN9y60WQgW1OBa1rIJPZTeCINednuCgvYU7YR5 mjZr8i93SkiHM0PIrFF1KleYjYhgrIa6ltu+gGcyRuGg20ONRy6AcBQADw4xgrtrDiO5 CLog== X-Gm-Message-State: AN3rC/6em7Rpeb3FkTFKZEG6KBevYIxIHu0LR9+t4bNTxR0w0ir/mKRd Dd6zdWDEkF59Yg== X-Received: by 10.99.167.3 with SMTP id d3mr15751247pgf.70.1494209417918; Sun, 07 May 2017 19:10:17 -0700 (PDT) Received: from localhost.localdomain (NCTU-Wireless-NAT217.nctu.edu.tw. [140.113.136.217]) by smtp.gmail.com with ESMTPSA id r1sm12179166pfj.68.2017.05.07.19.10.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 07 May 2017 19:10:16 -0700 (PDT) From: Daichou To: clm@fb.com, jbacik@fb.com, dsterba@suse.com, linux-btrfs@vger.kernel.org Cc: Daichou Subject: [PATCH] Btrfs:Unused comments:"FIXME: check if the IDs really exist" in ioctl.c Date: Mon, 8 May 2017 10:10:02 +0800 Message-Id: <20170508021002.12262-1-tommy0705c@gmail.com> X-Mailer: git-send-email 2.12.2 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP These comments were already fixed in 2013. btrfs_add_qgroup_relation, btrfs_ioctl_qgroup_create, btrfs_limit_qgroup btrfs_add_qgroup_relation, btrfs_del_qgroup_relation have checked qgroupid existed. Signed-off-by: Daichou --- fs/btrfs/ioctl.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index a29dc3fd7152..6db06f4708f7 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -4900,7 +4900,6 @@ static long btrfs_ioctl_qgroup_assign(struct file *file, void __user *arg) goto out; } - /* FIXME: check if the IDs really exist */ if (sa->assign) { ret = btrfs_add_qgroup_relation(trans, fs_info, sa->src, sa->dst); @@ -4959,7 +4958,6 @@ static long btrfs_ioctl_qgroup_create(struct file *file, void __user *arg) goto out; } - /* FIXME: check if the IDs really exist */ if (sa->create) { ret = btrfs_create_qgroup(trans, fs_info, sa->qgroupid); } else { @@ -5013,7 +5011,6 @@ static long btrfs_ioctl_qgroup_limit(struct file *file, void __user *arg) qgroupid = root->root_key.objectid; } - /* FIXME: check if the IDs really exist */ ret = btrfs_limit_qgroup(trans, fs_info, qgroupid, &sa->lim); err = btrfs_end_transaction(trans);